From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l1ouO-0004lg-2J for mharc-grub-devel@gnu.org; Tue, 19 Jan 2021 06:10:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1ouJ-0004lT-4n for grub-devel@gnu.org; Tue, 19 Jan 2021 06:10:44 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:36662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1ouF-0004uZ-7z for grub-devel@gnu.org; Tue, 19 Jan 2021 06:10:42 -0500 Received: by mail-ed1-x52e.google.com with SMTP id b2so20996606edm.3 for ; Tue, 19 Jan 2021 03:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=w0u3Mue3b4h/mbfIYBFvInHqpll7E9+442JJsNbBn7c=; b=e3d3Dh69ErhWfx14Yg54C5wgq5N7tG8T4C5zu187uMyH7IebjdmTuARB0PlyVf5PRu PQKs/qjIASd4y7t9bDDlVdREYNrGizxQnb7eINFPF4dPVa6z9drYn+nFtEjSmbnPbGz5 fG5/TnapNIjon7hqg0I1ZdqCPFVLjcg1PB5TnPOlXAOMOHt0IG3EAue1Dij8SXOMDGkY kTZIgsdSlApvvVVZe3G6B4RsPkJ8dfGbwAHtINvEQNPeXaFlrxxQf1Fe2Z6x7X72GCqC DxyYsAC+T0RJEuk3TrhZaxCcVKitzW3f9Sgz9Gqb94//xPNsjwbAnFfEMmCesYlYVg4s 4f5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=w0u3Mue3b4h/mbfIYBFvInHqpll7E9+442JJsNbBn7c=; b=pNdnfjuguk4dSvx2zWZPmv2z0eQ3sLYBBa33IHZ6ZmPgoUw956GT8Ru2wOf8x2p88U hhNEihI2+K7HOHWZHXMKnaFRYxvxn4ouWO4e5/0jAsLh3PRbe6PYxZzKYygAwHJ7mePH yXwEyziPT4Ocyr3XWy1Q6xZLq8n45NyLOlx8A54OoC1QZaWwcHzZnvyWQrXAh/tXPtlq GWPMZwaQMfQTPtIIqkFwRjgPHgePDjflB2uYhHeNTfGQYAt9ViuNapqYCYWBLS76hlHj dbM3X/py3yP2LndKy4WXZbCu9H+G7PfdxMfw94a3bmsvlFYOFfcEpkXpJMckA8k6bWBH 2y7w== X-Gm-Message-State: AOAM5330xtpKAuCT/NNk9+TdVPUPdC/lS6fo+bB4BR90TnkeImRGopyc xkt702IbgXYOthnXoBqgMgXd0ZM1Xdm3GmULoQuhFeWQHpU= X-Google-Smtp-Source: ABdhPJy5kIoRbZiHQ1eBAfr+Tq8IhvUR1vZ8/6HExuRSxwW1hmVNra/5hf8uVV+wU6PmYTtrDHueDNSgXXnkcjpkUEo= X-Received: by 2002:a05:6402:2289:: with SMTP id cw9mr2922030edb.319.1611054635968; Tue, 19 Jan 2021 03:10:35 -0800 (PST) MIME-Version: 1.0 References: <20210119000758.GA178434@pevik> In-Reply-To: <20210119000758.GA178434@pevik> From: Dmitry Date: Tue, 19 Jan 2021 14:10:35 +0300 Message-ID: Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup To: The development of GNU GRUB Cc: Patrick Steinhardt , petr.vorel@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=reagentoo@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 11:10:45 -0000 Please try to build only for the "efi-64" platform. (not "pc") Dmitry =D0=B2=D1=82, 19 =D1=8F=D0=BD=D0=B2. 2021 =D0=B3. =D0=B2 03:08, Petr Vorel = : > > Hi Patrick, > > I know that this patchset needs some changes and is not planned to be inc= luded > in 2.06. But anyway, testing it I found: > > ... > > +++ b/grub-core/lib/argon2/core.c > > +/* for explicit_bzero() on glibc */ > > +#define _DEFAULT_SOURCE > ... > > +#if defined(__OpenBSD__) > > +#define HAVE_EXPLICIT_BZERO 1 > > +#elif defined(__GLIBC__) && defined(__GLIBC_PREREQ) > > +#if __GLIBC_PREREQ(2,25) > > +#define HAVE_EXPLICIT_BZERO 1 > > +#endif > Does this work? I get: > > grub-core/lib/argon2/core.c: In function =E2=80=98secure_wipe_memory= =E2=80=99: > grub-core/lib/argon2/core.c:135:5: error: implicit declaration of fun= ction =E2=80=98explicit_bzero=E2=80=99 [-Werror=3Dimplicit-function-declara= tion] > 135 | explicit_bzero(v, n); > > Including isn't obviously a good idea. > What's wrong? I have to miss something obvious. > > > +#endif > > If I remove HAVE_EXPLICIT_BZERO definition, I get errors when generating > moddep.lst: > > make[3]: Entering directory '/home/pevik/install/src/grub.git/grub-core' > cat syminfo.lst | sort | gawk -f ./genmoddep.awk > moddep.lst || (rm -f m= oddep.lst; exit 1) > __moddi3 in argon2 is not defined > __umoddi3 in argon2 is not defined > > My config-util.h does not have HAVE___MODDI3 and HAVE___UMODDI3. > What's wrong? > > I'm compiling on recent distro. > Thanks for any hint. > > Kind regards, > Petr > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel