From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04DFA3C13 for ; Mon, 30 Jan 2023 16:05:35 +0000 (UTC) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-15085b8a2f7so15595663fac.2 for ; Mon, 30 Jan 2023 08:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=L98bAAgAmuX9bFEDS6fk6Q+27l6gFYkFOLbjKNDsS8RTOTjiBEdK702pVpPk8K8v2x FZ40wxfCgagdDgLZgDQSMy99FG0HrFXxnw5fTYnrvOwXT+BwXCieEpFIg3/SsmQJP+EC kDBQkrBuzGcoU7ndvROuyFWLZFE/ctHdUqpLQ8WEW7ATErXDt8JgWyaIg4+oPKIiIIG2 E/5aPbIUxghZjhtNR71JXB5xvYRjiu0AUliaWGmF3G0g05pRTLYrCoXS9OGzaRGBOFGs DpgHoQDXj4lObIjncle+96AxxcpMoBLOLxT1OwqPpaSjYjWU66vw4Foj9apT1oscVN7h RTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=ziuWadnA8DmxkyZUuwXFe5OuAcl2fd0nabXLl3xk1gw+RSI7WcwMgi3IoCznLNrNRr 4x7An8uIPV4hmDujX/ZdIwEMlvOwLMixpxYdJgHdUS4a1kODm84JX/jXY/1vexQNfb4F wlzl/IO8K4gH1oj+T8S6q7ULBCSji7ZfO3Gqyb0+M7mk0JgpAHvev0Q/Ye5VJwxYuGAu MWQGLIhi5hubcYYdSzQVubJHn9UEgIuVhXDfOeUcFWxHZdFVnyQPjUkCO6pGJuZ9ZVk8 03QmHlW8mULr5Q8ZZ0mgcC/R3dkF6Qow2mUPK7PZEBj0BdvHtsn/RzdqxQ2GtMWUGTn2 k1SQ== X-Gm-Message-State: AO0yUKXhc7qzyCeLbYwp/nZvjuqymFIOfXOZfr42Vqr4irhzn3eAkoTT dSC08JlLxxwFdb0/TYtvxrLFM8yIFSnwTCD/YPQ= X-Google-Smtp-Source: AK7set8EqeKjODeZxYSFoNuOQNRomzjZI0eXWH0l8P+aWs8vNWEn7kSRbZqFFz4w7fzpO/miv8K0++Fx3wa5+PLBAtg= X-Received: by 2002:a05:6870:4588:b0:163:3c39:d0c7 with SMTP id y8-20020a056870458800b001633c39d0c7mr1249465oao.54.1675094735057; Mon, 30 Jan 2023 08:05:35 -0800 (PST) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230127103959.5nqk57sb7qchtaw6@wslaptop> In-Reply-To: From: Nicolas Chauvet Date: Mon, 30 Jan 2023 17:05:23 +0100 Message-ID: Subject: Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79 To: Ben Skeggs Cc: Diogo Ivo , airlied@redhat.com, nouveau@lists.freedesktop.org, regressions@lists.linux.dev, dri-devel@lists.freedesktop.org, kherbst@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le dim. 29 janv. 2023 =C3=A0 23:36, Ben Skeggs a =C3=A9= crit : > > On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wr= ote: > > > > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > > > > > As a quick check can you try changing > > > > > > > > > > > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_me= m_target > > > > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ? > > > > > > > > > In addition to Dave's change, can you try changing the > > > > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to: > > > > > > > > > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM, addr_args, > > > > > sizeof(args), 0, false); > > > > > > > > Chiming in just to say that with this change I see the same as Nico= las > > > > except that the init message size is 255 instead of 0: > > > > > > > > [ 2.196934] nouveau 57000000.gpu: pmu: unexpected init message s= ize 255 vs 42 > > > I've attached an entirely untested patch (to go on top of the other > > > hacks/fixes so far), that will hopefully get us a little further. > > > > Hello, > > > > Thank you for the patch! I can confirm that it fixes the problem > > on the Pixel C, and everything works as before the regression. > > With this, for the combination of patches > > > > Tested-by: Diogo Ivo > > > > which I can resend after testing the final patch version. > Thank you (both!) for testing! > > I've attached a "final" version of a patch that I'll send (assuming it > still works ;)) after re-testing. There's only a minor change to > avoid breaking the non-Tegra path, so I expect it should be fine. Fine with me. Tested-By: Nicolas Chauvet Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E598EC54EAA for ; Mon, 30 Jan 2023 16:05:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8105510E033; Mon, 30 Jan 2023 16:05:37 +0000 (UTC) Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBBAD10E033; Mon, 30 Jan 2023 16:05:35 +0000 (UTC) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1636eae256cso11290089fac.0; Mon, 30 Jan 2023 08:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=L98bAAgAmuX9bFEDS6fk6Q+27l6gFYkFOLbjKNDsS8RTOTjiBEdK702pVpPk8K8v2x FZ40wxfCgagdDgLZgDQSMy99FG0HrFXxnw5fTYnrvOwXT+BwXCieEpFIg3/SsmQJP+EC kDBQkrBuzGcoU7ndvROuyFWLZFE/ctHdUqpLQ8WEW7ATErXDt8JgWyaIg4+oPKIiIIG2 E/5aPbIUxghZjhtNR71JXB5xvYRjiu0AUliaWGmF3G0g05pRTLYrCoXS9OGzaRGBOFGs DpgHoQDXj4lObIjncle+96AxxcpMoBLOLxT1OwqPpaSjYjWU66vw4Foj9apT1oscVN7h RTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=mgNIka54hnXtMzhq3yZbY1/whFq9auPBAvhjqa4lzq+UVXVq2MV72fyE/FJpyDdoFd 5mQ+TM0h7fbTvE4Vb3yTMlOxi3v9XEN097rLt8mSNBFoKTuQzIQC/8UES/EEV9wrdbPW Mggf9jkF55+BQKZde6Y8KQWHvnVVpg6j0ULWROwvLGTBs7XD3fVAPdZMykzTyy2XqOIB vH+tsPo7RxJ/t0H+NnEaeai0vvMpUzm/hRzK0+873BrBttmUYl4suuJw+3PTxCGEu1SW T6Xea2Ce1pTXVzatzsos/0gjb/9ximmKmd3ihl8Nb1uOn3X9Tv+KvPITYLLtBAFazP38 P9hw== X-Gm-Message-State: AO0yUKWl9i2LYh0APk+pkfCsnycK2S2HiAAS6FZAuAqMoR3U1V1rp3QN BgjGgffCE26SrdonxjcBMqzryRtGy393BQf9SVc0SlyW/m8= X-Google-Smtp-Source: AK7set8EqeKjODeZxYSFoNuOQNRomzjZI0eXWH0l8P+aWs8vNWEn7kSRbZqFFz4w7fzpO/miv8K0++Fx3wa5+PLBAtg= X-Received: by 2002:a05:6870:4588:b0:163:3c39:d0c7 with SMTP id y8-20020a056870458800b001633c39d0c7mr1249465oao.54.1675094735057; Mon, 30 Jan 2023 08:05:35 -0800 (PST) MIME-Version: 1.0 References: <20230127103959.5nqk57sb7qchtaw6@wslaptop> In-Reply-To: From: Nicolas Chauvet Date: Mon, 30 Jan 2023 17:05:23 +0100 Message-ID: To: Ben Skeggs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Nouveau] [REGRESSION] GM20B probe fails after commit 2541626cfb79 X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: regressions@lists.linux.dev, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Diogo Ivo , airlied@redhat.com Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Le dim. 29 janv. 2023 =C3=A0 23:36, Ben Skeggs a =C3=A9= crit : > > On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wr= ote: > > > > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > > > > > As a quick check can you try changing > > > > > > > > > > > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_me= m_target > > > > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ? > > > > > > > > > In addition to Dave's change, can you try changing the > > > > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to: > > > > > > > > > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM, addr_args, > > > > > sizeof(args), 0, false); > > > > > > > > Chiming in just to say that with this change I see the same as Nico= las > > > > except that the init message size is 255 instead of 0: > > > > > > > > [ 2.196934] nouveau 57000000.gpu: pmu: unexpected init message s= ize 255 vs 42 > > > I've attached an entirely untested patch (to go on top of the other > > > hacks/fixes so far), that will hopefully get us a little further. > > > > Hello, > > > > Thank you for the patch! I can confirm that it fixes the problem > > on the Pixel C, and everything works as before the regression. > > With this, for the combination of patches > > > > Tested-by: Diogo Ivo > > > > which I can resend after testing the final patch version. > Thank you (both!) for testing! > > I've attached a "final" version of a patch that I'll send (assuming it > still works ;)) after re-testing. There's only a minor change to > avoid breaking the non-Tegra path, so I expect it should be fine. Fine with me. Tested-By: Nicolas Chauvet Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D9B3C54EED for ; Mon, 30 Jan 2023 16:05:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B563010E056; Mon, 30 Jan 2023 16:05:37 +0000 (UTC) Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBBAD10E033; Mon, 30 Jan 2023 16:05:35 +0000 (UTC) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1636eae256cso11290089fac.0; Mon, 30 Jan 2023 08:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=L98bAAgAmuX9bFEDS6fk6Q+27l6gFYkFOLbjKNDsS8RTOTjiBEdK702pVpPk8K8v2x FZ40wxfCgagdDgLZgDQSMy99FG0HrFXxnw5fTYnrvOwXT+BwXCieEpFIg3/SsmQJP+EC kDBQkrBuzGcoU7ndvROuyFWLZFE/ctHdUqpLQ8WEW7ATErXDt8JgWyaIg4+oPKIiIIG2 E/5aPbIUxghZjhtNR71JXB5xvYRjiu0AUliaWGmF3G0g05pRTLYrCoXS9OGzaRGBOFGs DpgHoQDXj4lObIjncle+96AxxcpMoBLOLxT1OwqPpaSjYjWU66vw4Foj9apT1oscVN7h RTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=51bRkvWujNd4jPcMG9BJhLnAdVGH8Ah/pwvY7OLYBxg=; b=mgNIka54hnXtMzhq3yZbY1/whFq9auPBAvhjqa4lzq+UVXVq2MV72fyE/FJpyDdoFd 5mQ+TM0h7fbTvE4Vb3yTMlOxi3v9XEN097rLt8mSNBFoKTuQzIQC/8UES/EEV9wrdbPW Mggf9jkF55+BQKZde6Y8KQWHvnVVpg6j0ULWROwvLGTBs7XD3fVAPdZMykzTyy2XqOIB vH+tsPo7RxJ/t0H+NnEaeai0vvMpUzm/hRzK0+873BrBttmUYl4suuJw+3PTxCGEu1SW T6Xea2Ce1pTXVzatzsos/0gjb/9ximmKmd3ihl8Nb1uOn3X9Tv+KvPITYLLtBAFazP38 P9hw== X-Gm-Message-State: AO0yUKWl9i2LYh0APk+pkfCsnycK2S2HiAAS6FZAuAqMoR3U1V1rp3QN BgjGgffCE26SrdonxjcBMqzryRtGy393BQf9SVc0SlyW/m8= X-Google-Smtp-Source: AK7set8EqeKjODeZxYSFoNuOQNRomzjZI0eXWH0l8P+aWs8vNWEn7kSRbZqFFz4w7fzpO/miv8K0++Fx3wa5+PLBAtg= X-Received: by 2002:a05:6870:4588:b0:163:3c39:d0c7 with SMTP id y8-20020a056870458800b001633c39d0c7mr1249465oao.54.1675094735057; Mon, 30 Jan 2023 08:05:35 -0800 (PST) MIME-Version: 1.0 References: <20230127103959.5nqk57sb7qchtaw6@wslaptop> In-Reply-To: From: Nicolas Chauvet Date: Mon, 30 Jan 2023 17:05:23 +0100 Message-ID: Subject: Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79 To: Ben Skeggs Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: regressions@lists.linux.dev, kherbst@redhat.com, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Diogo Ivo , airlied@redhat.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le dim. 29 janv. 2023 =C3=A0 23:36, Ben Skeggs a =C3=A9= crit : > > On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wr= ote: > > > > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > > > > > As a quick check can you try changing > > > > > > > > > > > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_me= m_target > > > > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ? > > > > > > > > > In addition to Dave's change, can you try changing the > > > > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to: > > > > > > > > > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM, addr_args, > > > > > sizeof(args), 0, false); > > > > > > > > Chiming in just to say that with this change I see the same as Nico= las > > > > except that the init message size is 255 instead of 0: > > > > > > > > [ 2.196934] nouveau 57000000.gpu: pmu: unexpected init message s= ize 255 vs 42 > > > I've attached an entirely untested patch (to go on top of the other > > > hacks/fixes so far), that will hopefully get us a little further. > > > > Hello, > > > > Thank you for the patch! I can confirm that it fixes the problem > > on the Pixel C, and everything works as before the regression. > > With this, for the combination of patches > > > > Tested-by: Diogo Ivo > > > > which I can resend after testing the final patch version. > Thank you (both!) for testing! > > I've attached a "final" version of a patch that I'll send (assuming it > still works ;)) after re-testing. There's only a minor change to > avoid breaking the non-Tegra path, so I expect it should be fine. Fine with me. Tested-By: Nicolas Chauvet Thanks.