From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Chauvet Subject: Re: [PATCH v2] nouveau: arm: Add MODULE_FIRMWARE for gk20a Date: Wed, 11 Nov 2015 10:29:13 +0100 Message-ID: References: <1443452893-18246-1-git-send-email-kwizart@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1514111369==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Alexandre Courbot Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org --===============1514111369== Content-Type: multipart/alternative; boundary=001a1143b40c9aef54052440751a --001a1143b40c9aef54052440751a Content-Type: text/plain; charset=UTF-8 2015-09-30 6:57 GMT+02:00 Alexandre Courbot : > On Tue, Sep 29, 2015 at 12:08 AM, Nicolas Chauvet > wrote: > > This patch is needed by initramfs tools to detect > > the required firmware files for the module. > > > > This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC > > for the firmwares related to the Tegra K1 generation. > > > > v2: move the MODULE_FIRMWARE to the nvidia_platform.c file. > > This will avoid to test for NOUVEAU_PLATFORM_DRIVER > > Nice, thanks for doing this change! > > Reviewed-by: Alexandre Courbot > Thx for the review. FYI I've tested the patch on top of 4.3+ kernels, and the initramfs generated with dracut works as expected. Is there any other concern with this patch ? It's certainly late for 4.4,I would expect it to hit kernel 4.3 at some point, but I don't think everything is wired from userspace(Xorg/Wayland) wrt dGPU support. So It could also wait for 4.5. What do you think ? Thx -- - Nicolas (kwizart) --001a1143b40c9aef54052440751a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2015= -09-30 6:57 GMT+02:00 Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
On Tue, Sep 29, 2015 at 12:08 AM, Ni= colas Chauvet <kw= izart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch is needed by initramfs tools to detect
> the required firmware files for the module.
>
> This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC
> for the firmwares related to the Tegra K1 generation.
>
> v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
>=C2=A0 This will avoid to test for NOUVEAU_PLATFORM_DRIVER

Nice, thanks for doing this change!

Reviewed-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Thx for the review.=
FYI I've tested the patch on top of 4.3+ kernels, and the initramfs= generated with dracut works as expected.

Is there any other concern with this patch ?

It's certainly late for 4.4,I would expect it to hit k= ernel 4.3 at some point, but I don't think everything is wired from use= rspace(Xorg/Wayland) wrt dGPU support.
= So It could also wait for 4.5.
What do = you think ?

Thx

--
-

Nicolas (kwizart)
--001a1143b40c9aef54052440751a-- --===============1514111369== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============1514111369==--