From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Varoqui Subject: Re: [PATCH] multipath-tools: arrange compilation options for shared libs/objects Date: Thu, 23 Mar 2017 09:35:19 +0100 Message-ID: References: <20170318174500.15268-1-xose.vazquez@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1688544930907205889==" Return-path: In-Reply-To: <20170318174500.15268-1-xose.vazquez@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Xose Vazquez Perez Cc: device-mapper development List-Id: dm-devel.ids --===============1688544930907205889== Content-Type: multipart/alternative; boundary=94eb2c12f968d9abf3054b61c1b9 --94eb2c12f968d9abf3054b61c1b9 Content-Type: text/plain; charset=UTF-8 Merged, Thanks. On Sat, Mar 18, 2017 at 6:45 PM, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- > libdmmp/Makefile | 2 +- > libmpathcmd/Makefile | 2 +- > libmpathpersist/Makefile | 2 +- > libmultipath/Makefile | 2 +- > libmultipath/checkers/Makefile | 6 +++--- > libmultipath/prioritizers/Makefile | 4 ++-- > 6 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libdmmp/Makefile b/libdmmp/Makefile > index 082078a..8640bf6 100644 > --- a/libdmmp/Makefile > +++ b/libdmmp/Makefile > @@ -23,7 +23,7 @@ LIBDEPS += $(shell pkg-config --libs json-c) > -L$(mpathcmddir) -lmpathcmd -lpthre > all: $(LIBS) doc > > $(LIBS): $(OBJS) > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) > $(LIBDEPS) > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl,-soname=$@ $(OBJS) > -o $@ > $(LN) $@ $(DEVLIB) > > install: > diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile > index b8e29cb..b6c349a 100644 > --- a/libmpathcmd/Makefile > +++ b/libmpathcmd/Makefile > @@ -9,7 +9,7 @@ OBJS = mpath_cmd.o > all: $(LIBS) > > $(LIBS): $(OBJS) > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) > $(LIBDEPS) > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl,-soname=$@ $(OBJS) > -o $@ > $(LN) $@ $(DEVLIB) > > install: $(LIBS) > diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile > index 96da639..ee4a421 100644 > --- a/libmpathpersist/Makefile > +++ b/libmpathpersist/Makefile > @@ -14,7 +14,7 @@ OBJS = mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.o > all: $(LIBS) > > $(LIBS): $(OBJS) > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ -o $@ > $(OBJS) > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl,-soname=$@ $(OBJS) > -o $@ > $(LN) $(LIBS) $(DEVLIB) > $(GZIP) mpath_persistent_reserve_in.3 > > mpath_persistent_reserve_in.3.gz > $(GZIP) mpath_persistent_reserve_out.3 > > mpath_persistent_reserve_out.3.gz > diff --git a/libmultipath/Makefile b/libmultipath/Makefile > index 1f5ec25..c5f4052 100644 > --- a/libmultipath/Makefile > +++ b/libmultipath/Makefile > @@ -47,7 +47,7 @@ OBJS = memory.o parser.o vector.o devmapper.o callout.o \ > all: $(LIBS) > > $(LIBS): $(OBJS) > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) > $(LIBDEPS) > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl,-soname=$@ $(OBJS) > -o $@ > $(LN) $@ $(DEVLIB) > > install: > diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/ > Makefile > index 11ab76f..3b8e27c 100644 > --- a/libmultipath/checkers/Makefile > +++ b/libmultipath/checkers/Makefile > @@ -19,13 +19,13 @@ LIBS= \ > all: $(LIBS) > > libcheckrbd.so: rbd.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrados -ludev > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ -lrados -ludev > > libcheckdirectio.so: libsg.o directio.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ -laio > > libcheck%.so: libsg.o %.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ > > install: > $(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(libdir) > diff --git a/libmultipath/prioritizers/Makefile > b/libmultipath/prioritizers/Makefile > index 36b42e4..8a5561a 100644 > --- a/libmultipath/prioritizers/Makefile > +++ b/libmultipath/prioritizers/Makefile > @@ -23,10 +23,10 @@ LIBS = \ > all: $(LIBS) > > libprioalua.so: alua.o alua_rtpg.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ > > libprio%.so: %.o > - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ > + $(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ > > install: $(LIBS) > $(INSTALL_PROGRAM) -m 755 libprio*.so $(DESTDIR)$(libdir) > -- > 2.12.0 > > --94eb2c12f968d9abf3054b61c1b9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Merged,
Thanks.
=
On Sat, Mar 18, 2017 at 6:45 PM, Xose Vazque= z Perez <xose.vazquez@gmail.com> wrote:
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm= -devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
=C2=A0libdmmp/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 2 +-
=C2=A0libmpathcmd/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0| 2 +-
=C2=A0libmpathpersist/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 = +-
=C2=A0libmultipath/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= | 2 +-
=C2=A0libmultipath/checkers/Makefile=C2=A0 =C2=A0 =C2=A0| 6 +++---
=C2=A0libmultipath/prioritizers/Makefile | 4 ++--
=C2=A06 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/libdmmp/Makefile b/libdmmp/Makefile
index 082078a..8640bf6 100644
--- a/libdmmp/Makefile
+++ b/libdmmp/Makefile
@@ -23,7 +23,7 @@ LIBDEPS +=3D $(shell pkg-config --libs json-c) -L$(mpathc= mddir) -lmpathcmd -lpthre
=C2=A0all: $(LIBS) doc

=C2=A0$(LIBS): $(OBJS)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=3D= $@ -o $@ $(OBJS) $(LIBDEPS)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl= ,-soname=3D$@ $(OBJS) -o $@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(LN) $@ $(DEVLIB)

=C2=A0install:
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index b8e29cb..b6c349a 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -9,7 +9,7 @@ OBJS =3D mpath_cmd.o
=C2=A0all: $(LIBS)

=C2=A0$(LIBS): $(OBJS)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=3D= $@ -o $@ $(OBJS) $(LIBDEPS)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl= ,-soname=3D$@ $(OBJS) -o $@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(LN) $@ $(DEVLIB)

=C2=A0install: $(LIBS)
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index 96da639..ee4a421 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -14,7 +14,7 @@ OBJS =3D mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.= o
=C2=A0all: $(LIBS)

=C2=A0$(LIBS): $(OBJS)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl= ,-soname=3D$@ -o $@ $(OBJS)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl= ,-soname=3D$@ $(OBJS) -o $@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(LN) $(LIBS) $(DEVLIB)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(GZIP) mpath_persistent_reserve_in.3 > mpat= h_persistent_reserve_in.3.gz
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(GZIP) mpath_persistent_reserve_out.3 > mpa= th_persistent_reserve_out.3.gz
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index 1f5ec25..c5f4052 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -47,7 +47,7 @@ OBJS =3D memory.o parser.o vector.o devmapper.o callout.o= \
=C2=A0all: $(LIBS)

=C2=A0$(LIBS): $(OBJS)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=3D= $@ -o $@ $(OBJS) $(LIBDEPS)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) $(LIBDEPS) -Wl= ,-soname=3D$@ $(OBJS) -o $@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(LN) $@ $(DEVLIB)

=C2=A0install:
diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile
index 11ab76f..3b8e27c 100644
--- a/libmultipath/checkers/Makefile
+++ b/libmultipath/checkers/Makefile
@@ -19,13 +19,13 @@ LIBS=3D \
=C2=A0all: $(LIBS)

=C2=A0libcheckrbd.so: rbd.o
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrad= os -ludev
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ -lrad= os -ludev

=C2=A0libcheckdirectio.so: libsg.o directio.o
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^ -laio=

=C2=A0libcheck%.so: libsg.o %.o
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^

=C2=A0install:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(l= ibdir)
diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/priorit= izers/Makefile
index 36b42e4..8a5561a 100644
--- a/libmultipath/prioritizers/Makefile
+++ b/libmultipath/prioritizers/Makefile
@@ -23,10 +23,10 @@ LIBS =3D \
=C2=A0all: $(LIBS)

=C2=A0libprioalua.so: alua.o alua_rtpg.o
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^

=C2=A0libprio%.so: %.o
-=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
+=C2=A0 =C2=A0 =C2=A0 =C2=A0$(CC) $(SHARED_FLAGS) $(LDFLAGS) -o $@ $^

=C2=A0install: $(LIBS)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(INSTALL_PROGRAM) -m 755 libprio*.so $(DESTDIR= )$(libdir)
--
2.12.0


--94eb2c12f968d9abf3054b61c1b9-- --===============1688544930907205889== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1688544930907205889==--