From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Varoqui Subject: Re: [PATCH] multipath-tools: use internal drd.h file Date: Sun, 16 Oct 2016 19:34:46 +0200 Message-ID: References: <20161008202212.11963-1-xose.vazquez@gmail.com> <9e801117-cb59-b3a7-de85-b724326d2b34@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4246499624600082918==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Hannes Reinecke Cc: device-mapper development List-Id: dm-devel.ids --===============4246499624600082918== Content-Type: multipart/alternative; boundary=001a114017022d0ce0053efee0be --001a114017022d0ce0053efee0be Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable That's why we included a copy of the required valgrind header. Does this solution eleviate your complain ? On Sun, Oct 16, 2016 at 6:59 PM, Hannes Reinecke wrote: > On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote: > >> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote: >> >> Cc: Bart Van Assche >>> Cc: Christophe Varoqui >>> Cc: device-mapper development >>> Signed-off-by: Xose Vazquez Perez >>> --- >>> libmultipath/debug.c | 2 +- >>> multipathd/main.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >> >> This patch is missing. >> Thank you. >> >> >> diff --git a/libmultipath/debug.c b/libmultipath/debug.c >>> index 295136c..fbe171a 100644 >>> --- a/libmultipath/debug.c >>> +++ b/libmultipath/debug.c >>> @@ -8,7 +8,7 @@ >>> #include "log_pthread.h" >>> #include >>> #include >>> -#include <../third-party/valgrind/drd.h> >>> +#include "../third-party/valgrind/drd.h" >>> #include "vector.h" >>> #include "config.h" >>> >>> diff --git a/multipathd/main.c b/multipathd/main.c >>> index cdfafe8..0998085 100644 >>> --- a/multipathd/main.c >>> +++ b/multipathd/main.c >>> @@ -23,7 +23,6 @@ >>> #endif >>> #include >>> #include >>> -#include >>> >>> /* >>> * libmultipath >>> @@ -85,6 +84,7 @@ int uxsock_timeout; >>> #include "lock.h" >>> #include "waiter.h" >>> #include "wwids.h" >>> +#include "../third-party/valgrind/drd.h" >>> >>> #define FILE_NAME_SIZE 256 >>> #define CMDSIZE 160 >>> >>> >> Please don't. > We're trying to keep dependencies to each package as small as possible. > And requiring valgrind by default is not going to help here. > Please make this a compile-time option. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > hare@suse.de +49 911 74053 688 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg > GF: J. Hawn, J. Guild, F. Imend=C3=B6rffer, HRB 16746 (AG N=C3=BCrnberg) > > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > --001a114017022d0ce0053efee0be Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
That's why we included a copy of the required valgrind= header.
Does this solution eleviate your complain ?

On Sun, Oct 16, 2016 at = 6:59 PM, Hannes Reinecke <hare@suse.de> wrote:
On 10/16/2016 12:26= PM, Xose Vazquez Perez wrote:
On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:

Cc: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
=C2=A0libmultipath/debug.c | 2 +-
=C2=A0multipathd/main.c=C2=A0 =C2=A0 | 2 +-
=C2=A02 files changed, 2 insertions(+), 2 deletions(-)

This patch is missing.
Thank you.


diff --git a/libmultipath/debug.c b/libmultipath/debug.c
index 295136c..fbe171a 100644
--- a/libmultipath/debug.c
+++ b/libmultipath/debug.c
@@ -8,7 +8,7 @@
=C2=A0#include "log_pthread.h"
=C2=A0#include <sys/types.h>
=C2=A0#include <time.h>
-#include <../third-party/valgrind/drd.h>
+#include "../third-party/valgrind/drd.h"
=C2=A0#include "vector.h"
=C2=A0#include "config.h"

diff --git a/multipathd/main.c b/multipathd/main.c
index cdfafe8..0998085 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -23,7 +23,6 @@
=C2=A0#endif
=C2=A0#include <semaphore.h>
=C2=A0#include <time.h>
-#include <valgrind/drd.h>

=C2=A0/*
=C2=A0 * libmultipath
@@ -85,6 +84,7 @@ int uxsock_timeout;
=C2=A0#include "lock.h"
=C2=A0#include "waiter.h"
=C2=A0#include "wwids.h"
+#include "../third-party/valgrind/drd.h"

=C2=A0#define FILE_NAME_SIZE 256
=C2=A0#define CMDSIZE 160


Please don't.
We're trying to keep dependencies to each package as small as possible.=
And requiring valgrind by default is not going to help here.
Please make this a compile-time option.

Cheers,

Hannes
--
Dr. Hannes Reinecke=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0zSeries & Storage
hare@suse.de=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg
GF: J. Hawn, J. Guild, F. Imend=C3=B6rffer, HRB 16746 (AG N=C3=BCrnberg)


--
dm-devel mailing list
dm-devel@redhat.co= m
https://www.redhat.com/mailman/listinfo/dm-deve= l

--001a114017022d0ce0053efee0be-- --===============4246499624600082918== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4246499624600082918==--