All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@opensvc.com>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath-tools: build objects for libdmmp and libmpathpersist independently
Date: Thu, 23 Mar 2017 09:33:59 +0100	[thread overview]
Message-ID: <CABr-Gnea5rm6_goSE97PZiJEcdZ6-ZTgUzYdNXbX2nzou-8Xsw@mail.gmail.com> (raw)
In-Reply-To: <20170317152146.10884-1-xose.vazquez@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 5542 bytes --]

Merged,
Thanks.

On Fri, Mar 17, 2017 at 4:21 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> libdmmp:
> cc -c -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
> -I../libmpathpersist -I../libmpathcmd *.c
> new:
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
> -I../libmpathpersist -I../libmpathcmd -c -o mpath_persist.o mpath_persist.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
> -I../libmpathpersist -I../libmpathcmd -c -o mpath_updatepr.o
> mpath_updatepr.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath
> -I../libmpathpersist -I../libmpathcmd -c -o mpath_pr_ioctl.o
> mpath_pr_ioctl.c
>
> libmpathpersist:
> cc -c -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c *.c
> new:
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c -o libdmmp.o
> libdmmp.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c -o libdmmp_mp.o
> libdmmp_mp.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c -o libdmmp_pg.o
> libdmmp_pg.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c -o libdmmp_path.o
> libdmmp_path.c
> cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int
> -Werror=implicit-function-declaration -Werror=format-security
> -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered
> -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4
> -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -fvisibility=hidden
> -I../libdmmp -I../libmpathcmd -I/usr/include/json-c -c -o libdmmp_misc.o
> libdmmp_misc.c
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libdmmp/Makefile         | 3 +--
>  libmpathpersist/Makefile | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libdmmp/Makefile b/libdmmp/Makefile
> index c7db054..082078a 100644
> --- a/libdmmp/Makefile
> +++ b/libdmmp/Makefile
> @@ -22,8 +22,7 @@ LIBDEPS += $(shell pkg-config --libs json-c)
> -L$(mpathcmddir) -lmpathcmd -lpthre
>
>  all: $(LIBS) doc
>
> -$(LIBS):
> -       $(CC) -c $(CFLAGS) *.c
> +$(LIBS): $(OBJS)
>         $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS)
> $(LIBDEPS)
>         $(LN) $@ $(DEVLIB)
>
> diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
> index 6ef5bab..96da639 100644
> --- a/libmpathpersist/Makefile
> +++ b/libmpathpersist/Makefile
> @@ -13,8 +13,7 @@ OBJS = mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.o
>
>  all: $(LIBS)
>
> -$(LIBS):
> -       $(CC) -c $(CFLAGS) *.c
> +$(LIBS): $(OBJS)
>         $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ -o $@
> $(OBJS)
>         $(LN) $(LIBS) $(DEVLIB)
>         $(GZIP) mpath_persistent_reserve_in.3 >
> mpath_persistent_reserve_in.3.gz
> --
> 2.12.0
>
>

[-- Attachment #1.2: Type: text/html, Size: 6412 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2017-03-23  8:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 15:21 [PATCH] multipath-tools: build objects for libdmmp and libmpathpersist independently Xose Vazquez Perez
2017-03-23  8:33 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABr-Gnea5rm6_goSE97PZiJEcdZ6-ZTgUzYdNXbX2nzou-8Xsw@mail.gmail.com \
    --to=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.