From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Varoqui Subject: Re: [PATCH v3 00/19] Misc Multipath patches Date: Sun, 7 Oct 2018 10:36:41 +0200 Message-ID: References: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6990001963978117870==" Return-path: In-Reply-To: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski Cc: device-mapper development , Martin Wilck List-Id: dm-devel.ids --===============6990001963978117870== Content-Type: multipart/alternative; boundary="0000000000000651cd05779f6835" --0000000000000651cd05779f6835 Content-Type: text/plain; charset="UTF-8" Hi Ben, this v3 patchset is ready for merge or do you plan a v4 ? Thanks, Christophe On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski wrote: > This batch of patches is a resend of the non-merged pathes from my last > set, along with 2 new ones. It would be really great if we could get > a version bug after the outstanding commits go it. > > Patches 0001-0005 are a number of fixes to the tur checker.These are > the ones that should get the most attention. > Patches 0006-0017 are minor issues found by coverity. > Not all of them are bugs that could actually occur in practice, > but they are simple and hopefully non-controversial changes. > Patches 0018-0019 are new and related to changing path wwids > > Changes in v3 > added patches 0018-0019 > > Changes in v2 > 0002-libmultipath-fix-tur-checker-double-locking.patch now sets > ct->devt when initially creating the tur_checker_context, while > that structure is still only referenced by a local variable. > After that, ct->devt is only ever read. This should remove any > issues with it needing locking. > > Benjamin Marzinski (19): > libmultipath: fix tur checker timeout > libmultipath: fix tur checker double locking > libmultipath: fix tur memory misuse > libmultipath: cleanup tur locking > libmultipath: fix tur checker timeout issue > libmultipath: fix set_int error path > libmultipath: fix length issues in get_vpd_sgio > libmultipath: _install_keyword cleanup > libmultipath: remove unused code > libmultipath: fix memory issue in path_latency prio > libmultipath: fix null dereference int alloc_path_group > libmutipath: don't use malformed uevents > multipath: fix max array size in print_cmd_valid > multipathd: function return value tweaks > multipathd: minor fixes > multipathd: remove useless check and fix format > multipathd: fix memory leak on error in configure > libmultipath: Don't blank intialized paths > libmultipath: Fixup updating paths > > libmultipath/checkers/tur.c | 168 > +++++++++++-------------------- > libmultipath/dict.c | 5 +- > libmultipath/discovery.c | 18 ++-- > libmultipath/parser.c | 12 ++- > libmultipath/print.c | 8 -- > libmultipath/prioritizers/path_latency.c | 3 +- > libmultipath/structs.c | 2 +- > libmultipath/uevent.c | 6 ++ > multipath/main.c | 2 +- > multipathd/cli_handlers.c | 11 +- > multipathd/main.c | 50 +++++---- > 11 files changed, 131 insertions(+), 154 deletions(-) > > -- > 2.7.4 > > --0000000000000651cd05779f6835 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ben,

this v3 patchset is ready for m= erge or do you plan a v4 ?

Thanks,
Chris= tophe

On Sat, Se= p 22, 2018 at 1:05 AM Benjamin Marzinski <bmarzins@redhat.com> wrote:
This batch of patches is a resend of the non-merged pathes from my= last
set, along with 2 new ones. It would be really great if we could get
a version bug after the outstanding commits go it.

Patches 0001-0005 are a number of fixes to the tur checker.These are
=C2=A0 =C2=A0 =C2=A0 =C2=A0 the ones that should get the most attention. Patches 0006-0017 are minor issues found by coverity.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Not all of them are bugs that could actually oc= cur in practice,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 but they are simple and hopefully non-controver= sial changes.
Patches 0018-0019 are new and related to changing path wwids

Changes in v3
=C2=A0 =C2=A0 =C2=A0 =C2=A0 added patches 0018-0019

Changes in v2
=C2=A0 =C2=A0 =C2=A0 =C2=A0 0002-libmultipath-fix-tur-checker-double-lockin= g.patch now sets
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ct->devt when initially creating the tur_che= cker_context, while
=C2=A0 =C2=A0 =C2=A0 =C2=A0 that structure is still only referenced by a lo= cal variable.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 After that, ct->devt is only ever read. This= should remove any
=C2=A0 =C2=A0 =C2=A0 =C2=A0 issues with it needing locking.

Benjamin Marzinski (19):
=C2=A0 libmultipath: fix tur checker timeout
=C2=A0 libmultipath: fix tur checker double locking
=C2=A0 libmultipath: fix tur memory misuse
=C2=A0 libmultipath: cleanup tur locking
=C2=A0 libmultipath: fix tur checker timeout issue
=C2=A0 libmultipath: fix set_int error path
=C2=A0 libmultipath: fix length issues in get_vpd_sgio
=C2=A0 libmultipath: _install_keyword cleanup
=C2=A0 libmultipath: remove unused code
=C2=A0 libmultipath: fix memory issue in path_latency prio
=C2=A0 libmultipath: fix null dereference int alloc_path_group
=C2=A0 libmutipath: don't use malformed uevents
=C2=A0 multipath: fix max array size in print_cmd_valid
=C2=A0 multipathd: function return value tweaks
=C2=A0 multipathd: minor fixes
=C2=A0 multipathd: remove useless check and fix format
=C2=A0 multipathd: fix memory leak on error in configure
=C2=A0 libmultipath: Don't blank intialized paths
=C2=A0 libmultipath: Fixup updating paths

=C2=A0libmultipath/checkers/tur.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 168 +++++++++++--------------------
=C2=A0libmultipath/dict.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A05 +-
=C2=A0libmultipath/discovery.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 18 ++--
=C2=A0libmultipath/parser.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 |=C2=A0 12 ++-
=C2=A0libmultipath/print.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A08 --
=C2=A0libmultipath/prioritizers/path_latency.c |=C2=A0 =C2=A03 +-
=C2=A0libmultipath/structs.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0libmultipath/uevent.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 ++
=C2=A0multipath/main.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0multipathd/cli_handlers.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 11 +-
=C2=A0multipathd/main.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 50 +++++----
=C2=A011 files changed, 131 insertions(+), 154 deletions(-)

--
2.7.4

--0000000000000651cd05779f6835-- --===============6990001963978117870== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6990001963978117870==--