Oops no ! Thanks for noting. An incremental fix is now merged. You are right about the spelling fix that accidentaly was wrapped into this patch, but the patch has already been pushed online as-is so I don't see how I can improve that now. Regards, Christophe On Mon, Aug 1, 2016 at 6:02 PM, Bart Van Assche wrote: > On 07/31/2016 12:26 PM, Christophe Varoqui wrote: > >> Can you review this patch, adding a new 'serial' keyword to the >> weightedpath prioritizer. >> > > Is the following part of the patch intended? > > } else if (!strcmp(regex, WWN)) { > - if (build_wwn_path(pp, path, FILE_NAME_SIZE) != 0) { > + if (build_serial_path(pp, path, FILE_NAME_SIZE) != 0) { > > Additionally, have you considered to apply the mulitpathd -> multipathd > spelling fix in this patch as a separate patch? > > Thanks, > > Bart. >