From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CD8FC43334 for ; Mon, 25 Jul 2022 08:30:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B391D8B7CF; Mon, 25 Jul 2022 08:30:21 +0000 (UTC) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBE3B8B7CF for ; Mon, 25 Jul 2022 08:30:20 +0000 (UTC) Received: by mail-qk1-x72c.google.com with SMTP id o21so8074967qkm.10 for ; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=SchD1OSJhqZUbaDH3npCvBVhvgdsTgcai4JGkAeNGwKszMwOXVv1jP2YUfdpVF00gi M7W+LOBWkm3fvR7QR5Oi7Rr243ZKrwIRGyjvM4fEdp3ybWcWAtUz3ifU5jDZ2eCRBBLb hVRD5fVGR5o7NHR3kRn8qM+u20mgIRdugneUsK0DRfgczIFrKpOhBB+f9+/lUqaYKRv+ zCqM+TkCzfpywtt7PK8+F+XO4TuRbG4FDiDPWiwIK0+yYxleqIJNXSwBHMHq6a6DI1r4 IHORJbjxNq0t+3W70uo7ZSMhJhotvD3N/NslNtJkOTvO+ulZgz6/dODRy4NI0YAEC0V6 1QjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=gsIIiWkPPZznYXrt1POL8pgXORVlp6z38lLX2+c2px8dlh60R3qMOIIhB+KmzdZIV+ u3zicHPNTKEjuufGrMAi8T3PkQtqzUOmiPujd7aS9J3dA45uohK8WGfFaSDAABUkwEfG fPVj0BHfwoZDycBA6XOXlcM0NQrCYQ7DkCS5yKupTQ46j4n9sdgtJwRCrTa7gm0RH6XH shvTKuetzIPYvXGsX+Ee1ldAIZKz97Kic0YdwZh/xJe4D4xDxuoDU2tpSzI4WPzKhjG1 b2JOh5RM9yJcJ7fM44BTqHgERBQhwOBDgw8cFLV95wvdmhmrIfz2+5R3LjRwFtIOJC0H HyiQ== X-Gm-Message-State: AJIora/x/f3OPo2PaGNrkdPy1esfjJm0xyv+XSIfZb7/ctYZWZQfh2Xk 8Yk78EYN0gY5nRGtiHGLNZOUuTPGHO8vNRNS9ePpf6A8Pbg= X-Google-Smtp-Source: AGRyM1tT9zd1NbQQxCDwlfF4CX1SIOVXegpCvtscSaJImwYFwZu4GtSNklBiffb6QTC6/u0h5ukzMhHUITILaRb40TA= X-Received: by 2002:a05:620a:2942:b0:6b5:e33a:1771 with SMTP id n2-20020a05620a294200b006b5e33a1771mr8042028qkp.665.1658737820011; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-8-peterwu.pub@gmail.com> In-Reply-To: From: ChiaEn Wu Date: Mon, 25 Jul 2022 16:29:43 +0800 Message-ID: Subject: Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support To: Andy Shevchenko Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Pavel Machek , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jul 25, 2022 at 4:00 PM Andy Shevchenko wrote: > ... > > > +#define MT6370_REG_DEV_INFO 0x100 > > +#define MT6370_REG_CHG_IRQ1 0x1C0 > > +#define MT6370_REG_CHG_MASK1 0x1E0 > > + > > +#define MT6370_VENID_MASK GENMASK(7, 4) > > + > > +#define MT6370_NUM_IRQREGS 16 > > +#define MT6370_USBC_I2CADDR 0x4E > > > +#define MT6370_REG_ADDRLEN 2 > > +#define MT6370_REG_MAXADDR 0x1FF > > These two more logically to have near to other _REG_* definitions above. Hi Andy, Thanks for your review. Do you mean that we should move '#define MT6370_USBC_I2CADDR' and '#define MT6370_REG_MAXADDR' after the line '#define MT6370_REG_CHG_MASK1'? ------------------------------------------------------------------- #define MT6370_REG_DEV_INFO 0x100 #define MT6370_REG_CHG_IRQ1 0x1C0 #define MT6370_REG_CHG_MASK1 0x1E0 #define MT6370_USBC_I2CADDR 0x4E #define MT6370_REG_MAXADDR 0x1FF #define MT6370_VENID_MASK GENMASK(7, 4) #define MT6370_NUM_IRQREGS 16 #define MT6370_REG_ADDRLEN 2 ------------------------------------------------------------------- Like this? > > -- > With Best Regards, > Andy Shevchenko -- Best Regards, ChiaEn Wu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BBCC433EF for ; Mon, 25 Jul 2022 08:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233904AbiGYIbB (ORCPT ); Mon, 25 Jul 2022 04:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234141AbiGYIau (ORCPT ); Mon, 25 Jul 2022 04:30:50 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A6A6556; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id n2so8081171qkk.8; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=SchD1OSJhqZUbaDH3npCvBVhvgdsTgcai4JGkAeNGwKszMwOXVv1jP2YUfdpVF00gi M7W+LOBWkm3fvR7QR5Oi7Rr243ZKrwIRGyjvM4fEdp3ybWcWAtUz3ifU5jDZ2eCRBBLb hVRD5fVGR5o7NHR3kRn8qM+u20mgIRdugneUsK0DRfgczIFrKpOhBB+f9+/lUqaYKRv+ zCqM+TkCzfpywtt7PK8+F+XO4TuRbG4FDiDPWiwIK0+yYxleqIJNXSwBHMHq6a6DI1r4 IHORJbjxNq0t+3W70uo7ZSMhJhotvD3N/NslNtJkOTvO+ulZgz6/dODRy4NI0YAEC0V6 1QjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=DOwl29MfcAr7pGLDLeY/CXUd9wHq14dJzb6ZC3QEzBvAMZYanQyJ40IkjdbZxbgo3u TfjapNLDmOhbyRk9hQB1V/Bzg0RMyiJJAvqfkVRKHlEXFMnywTtNZx6IkkAN2hx9kTkA 7jinPHvENmkw2uMaZG6tLZtHGmgyDHi3PCqOtHm2cg4wPZfY+V/1skHtMJNkRTBi77Nq h+m2mN0PhsQ4/7AnPkB4dJ7XIs9E0WC+z87kRppObiWNG3mUEE+9uSjGQyeW82ncWaNb Ijq3QCWFf13/96DwvTKRavkeH9zWnNpuSf1CQ/jG1azEfvpBJGpAyOEjpINangIWFazH NXkg== X-Gm-Message-State: AJIora9aI99Ljjb9e5EkFol/ChC8WbCXGp2VPVf/Z5pHpunSby3hOO8A pRFQvgkmu/wjFMamGUPLfl4H7EEqtU4Lcl2Sanc= X-Google-Smtp-Source: AGRyM1tT9zd1NbQQxCDwlfF4CX1SIOVXegpCvtscSaJImwYFwZu4GtSNklBiffb6QTC6/u0h5ukzMhHUITILaRb40TA= X-Received: by 2002:a05:620a:2942:b0:6b5:e33a:1771 with SMTP id n2-20020a05620a294200b006b5e33a1771mr8042028qkp.665.1658737820011; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-8-peterwu.pub@gmail.com> In-Reply-To: From: ChiaEn Wu Date: Mon, 25 Jul 2022 16:29:43 +0800 Message-ID: Subject: Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support To: Andy Shevchenko Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, Jul 25, 2022 at 4:00 PM Andy Shevchenko wrote: > ... > > > +#define MT6370_REG_DEV_INFO 0x100 > > +#define MT6370_REG_CHG_IRQ1 0x1C0 > > +#define MT6370_REG_CHG_MASK1 0x1E0 > > + > > +#define MT6370_VENID_MASK GENMASK(7, 4) > > + > > +#define MT6370_NUM_IRQREGS 16 > > +#define MT6370_USBC_I2CADDR 0x4E > > > +#define MT6370_REG_ADDRLEN 2 > > +#define MT6370_REG_MAXADDR 0x1FF > > These two more logically to have near to other _REG_* definitions above. Hi Andy, Thanks for your review. Do you mean that we should move '#define MT6370_USBC_I2CADDR' and '#define MT6370_REG_MAXADDR' after the line '#define MT6370_REG_CHG_MASK1'? ------------------------------------------------------------------- #define MT6370_REG_DEV_INFO 0x100 #define MT6370_REG_CHG_IRQ1 0x1C0 #define MT6370_REG_CHG_MASK1 0x1E0 #define MT6370_USBC_I2CADDR 0x4E #define MT6370_REG_MAXADDR 0x1FF #define MT6370_VENID_MASK GENMASK(7, 4) #define MT6370_NUM_IRQREGS 16 #define MT6370_REG_ADDRLEN 2 ------------------------------------------------------------------- Like this? > > -- > With Best Regards, > Andy Shevchenko -- Best Regards, ChiaEn Wu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44F71C43334 for ; Mon, 25 Jul 2022 08:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9XleSlT63hl2dLmKudcOnBDgq4FavOX6vdw61dpott8=; b=d60Eufx5YjJ0bW v9h9Xw4RGFD6Glwe2QS5jBVsS/QQvY4a+U14r5Wn3i4sjZes0bb8qdPf+gZ4RSlKm3XqCLHshZ+7C trkreKEKldh7tgiLiXYWVNAKPkzwfXYWUXVgojsoCt+xZpv1N8CE4xzeCdoaQv94asADd87Udo8Mu MGbGJiBLaEOQ/OpltUY4itajt8KSUvP/++rEP4dIrnFO3gcQjCi4dE6fpegrPITXWZ6fwC1v4Dtbn ERaYOHLj+31dDjuc/EFeeIWxwepXAxswwGBY+CqWVDlzYG1dcB6DsXfGa65Utuf9C+E9l13Ihccbc +1SRwn+eimbPZ8ZDG3Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFtTw-006uhA-1i; Mon, 25 Jul 2022 08:30:28 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oFtTt-006uQg-1C; Mon, 25 Jul 2022 08:30:26 +0000 Received: by mail-qk1-x736.google.com with SMTP id c24so8087419qkm.4; Mon, 25 Jul 2022 01:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=SchD1OSJhqZUbaDH3npCvBVhvgdsTgcai4JGkAeNGwKszMwOXVv1jP2YUfdpVF00gi M7W+LOBWkm3fvR7QR5Oi7Rr243ZKrwIRGyjvM4fEdp3ybWcWAtUz3ifU5jDZ2eCRBBLb hVRD5fVGR5o7NHR3kRn8qM+u20mgIRdugneUsK0DRfgczIFrKpOhBB+f9+/lUqaYKRv+ zCqM+TkCzfpywtt7PK8+F+XO4TuRbG4FDiDPWiwIK0+yYxleqIJNXSwBHMHq6a6DI1r4 IHORJbjxNq0t+3W70uo7ZSMhJhotvD3N/NslNtJkOTvO+ulZgz6/dODRy4NI0YAEC0V6 1QjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eGTl5W3lU5EPUSxceW+3YfZM8YTmZNPLhO3+yi0Lxxo=; b=lHMgzlOJJzRx/PC4acEjWiry+BlUMIVhkKN8nkYAsCuO9BTGttMqBZDjmrxfqUtzTL GynIVb7VGNonAWSkf7Hgx8lTaUz4DJnKfwVdsO5ewh+AJkztG6OThPLptMfofgnL0IK9 LZn+wnJhelCGOsg+NaSGN0lq5R1uzkQ3V9jxBqGP7v2QE2u6prcmmxbcoWiiY067rjo0 VNOhoDFqMLI8qPnLGnvy9A1/E86KTBCsnQZEnkchLpUJqGcFGkBHeJdecENAL1Dzc2M3 8mNNRkGUNqn1sqSoGSS/xlEv37QXFkUbuauw3gUqnCMbWRJlV0l95ryCBM3UGRE8ZH2R mevA== X-Gm-Message-State: AJIora+rqkkTPiHz7kYaQRw+JrEsOH1e4XO292h/c8Pewh0zxNKKL2k7 fYM/9nAIeJnZHHIDt5cfz/d6SyJjyZ3ce+m+cKw= X-Google-Smtp-Source: AGRyM1tT9zd1NbQQxCDwlfF4CX1SIOVXegpCvtscSaJImwYFwZu4GtSNklBiffb6QTC6/u0h5ukzMhHUITILaRb40TA= X-Received: by 2002:a05:620a:2942:b0:6b5:e33a:1771 with SMTP id n2-20020a05620a294200b006b5e33a1771mr8042028qkp.665.1658737820011; Mon, 25 Jul 2022 01:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20220722102407.2205-1-peterwu.pub@gmail.com> <20220722102407.2205-8-peterwu.pub@gmail.com> In-Reply-To: From: ChiaEn Wu Date: Mon, 25 Jul 2022 16:29:43 +0800 Message-ID: Subject: Re: [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support To: Andy Shevchenko Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220725_013025_085836_6D5CF37C X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 25, 2022 at 4:00 PM Andy Shevchenko wrote: > ... > > > +#define MT6370_REG_DEV_INFO 0x100 > > +#define MT6370_REG_CHG_IRQ1 0x1C0 > > +#define MT6370_REG_CHG_MASK1 0x1E0 > > + > > +#define MT6370_VENID_MASK GENMASK(7, 4) > > + > > +#define MT6370_NUM_IRQREGS 16 > > +#define MT6370_USBC_I2CADDR 0x4E > > > +#define MT6370_REG_ADDRLEN 2 > > +#define MT6370_REG_MAXADDR 0x1FF > > These two more logically to have near to other _REG_* definitions above. Hi Andy, Thanks for your review. Do you mean that we should move '#define MT6370_USBC_I2CADDR' and '#define MT6370_REG_MAXADDR' after the line '#define MT6370_REG_CHG_MASK1'? ------------------------------------------------------------------- #define MT6370_REG_DEV_INFO 0x100 #define MT6370_REG_CHG_IRQ1 0x1C0 #define MT6370_REG_CHG_MASK1 0x1E0 #define MT6370_USBC_I2CADDR 0x4E #define MT6370_REG_MAXADDR 0x1FF #define MT6370_VENID_MASK GENMASK(7, 4) #define MT6370_NUM_IRQREGS 16 #define MT6370_REG_ADDRLEN 2 ------------------------------------------------------------------- Like this? > > -- > With Best Regards, > Andy Shevchenko -- Best Regards, ChiaEn Wu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel