From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB687C433EF for ; Fri, 24 Jun 2022 09:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbiFXJ47 (ORCPT ); Fri, 24 Jun 2022 05:56:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiFXJ4z (ORCPT ); Fri, 24 Jun 2022 05:56:55 -0400 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2C67A19C; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) Received: by mail-il1-x132.google.com with SMTP id k7so1144678ils.8; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=HsRYekV2sU4Xv613pAvXWZuwPyAd8ueafTN7t5ELrygCaBWqwnSFn/yimTyvXphliU rk/k1nDNQ3ECBrZQCQibcC5/SXphAPug9oObZB9Femn+4ZMKO367Z07kbw302ugSier+ 3u6Ie+cqpVmNjf+nVQ2o9wUhernyrputNPwEkW+iFxQ7yrQw609omGwbvjVllqqdkQlb DFP5VJKZgPzIyttK1WQpTnymekzhmxmCFLdIDv+zhBnfs0Quw4/dsjyIWcL8P0Yv01Hh HffrHojwf2vBBMXK+Xv5kciDDgUaOI7o+FqSBYVUB7RtJd64wGJ3mx0TRrsc6+x3jNA+ Uofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=4QDiFNuyHmWZ9g7JG7KiFjNCuKE0VSg4BJHi+DiYOHzJt/uoBbIVM9hFGCnvbvdVCh mcCfzOV5cdTiu/nyBKtUk2rn94PXsuBaKcLIQvxlhOwa8Hjh2WfQnvioOUQUPd8jME1Q lSBQZ7qEKfFqlrwpl/i2htzpPw7KvnSXQ+UzkUr9hBCZbcxra8iyK5dEL7tk4Oafxrdh 5AcBU2Z+Z+Pku+8dfcenyWlaZihS5FCZ6PiiR7fwrRe9TXgEstWY9EWd3rhQSiMeej47 b52MeYyucdragJiPypszqtb9qtORrIjpPKodKaSYK5ID4iHSLRLXFded5trEyyOBqRkB /TFA== X-Gm-Message-State: AJIora/6KcZfLeHvLltf6HoUjQX3vWt/X+htkbzI/g9LMK4U4CcukgVa QvgBC7wz3ztve1xxi0BbZs38WJPNpDB6FwM9wiQ= X-Google-Smtp-Source: AGRyM1u4tHhqAdEi5ogAeS0dS5voh35vGz3kiJUl5ktCSsYPoM0YYC7H2ztWgE2w6YlrhoWKAwKgDMijTEOWiU+6IC8= X-Received: by 2002:a05:6e02:10cf:b0:2d9:2310:e6b3 with SMTP id s15-20020a056e0210cf00b002d92310e6b3mr7601053ilj.212.1656064612053; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-15-peterwu.pub@gmail.com> <20220623134316.rg3adyobz3hkgflt@maple.lan> In-Reply-To: <20220623134316.rg3adyobz3hkgflt@maple.lan> From: ChiaEn Wu Date: Fri, 24 Jun 2022 17:56:41 +0800 Message-ID: Subject: Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support To: Daniel Thompson Cc: Lee Jones , jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, Jonathan Cameron , lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de, ChiaEn Wu , Alice Chen , ChiYuan Huang , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Daniel, Thanks for your comments! Daniel Thompson =E6=96=BC 2022=E5=B9=B46=E6=9C= =8823=E6=97=A5 =E9=80=B1=E5=9B=9B =E6=99=9A=E4=B8=8A9:43=E5=AF=AB=E9=81=93= =EF=BC=9A > > On Thu, Jun 23, 2022 at 07:56:31PM +0800, ChiaEn Wu wrote: > > From: ChiaEn Wu > > > > Add Mediatek MT6370 Backlight support. > > > > Signed-off-by: ChiaEn Wu > > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/= Kconfig > > index a003e02..7cd823d 100644 > > > > +static int mt6370_init_backlight_properties(struct mt6370_priv *priv, > > + struct backlight_properties *= props) > > +{ > > + struct device *dev =3D priv->dev; > > + u8 prop_val; > > + u32 brightness, ovp_uV, ocp_uA; > > + unsigned int mask, val; > > + int ret; > > + > > + /* Vendor optional properties */ > > + val =3D 0; > > + if (device_property_read_bool(dev, "mediatek,bled-pwm-enable")) > > + val |=3D MT6370_BL_PWM_EN_MASK; > > + > > + if (device_property_read_bool(dev, "mediatek,bled-pwm-hys-enable"= )) > > + val |=3D MT6370_BL_PWM_HYS_EN_MASK; > > + > > + ret =3D device_property_read_u8(dev, > > + "mediatek,bled-pwm-hys-input-th-ste= ps", > > + &prop_val); > > + if (!ret) { > > + prop_val =3D clamp_val(prop_val, > > + MT6370_BL_PWM_HYS_TH_MIN_STEP, > > + MT6370_BL_PWM_HYS_TH_MAX_STEP); > > + /* > > + * prop_val =3D 1 --> 1 steps --> 0x00 > > + * prop_val =3D 2 ~ 4 --> 4 steps --> 0x01 > > + * prop_val =3D 5 ~ 16 --> 16 steps --> 0x10 > > + * prop_val =3D 17 ~ 64 --> 64 steps --> 0x11 > > ^^^^^ > These numbers are binary, not hex, right? If so, the comments > should be 0b00 to 0b03 . Ohh! Yes! These numbers are binary! I so apologize for making this mistake... I will revise the comments in the next patch! Thank you so much! > > > > + */ > > + prop_val =3D (ilog2(roundup_pow_of_two(prop_val)) + 1) >>= 1; > > + val |=3D prop_val << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1= ); > > + } > > + > > + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, > > + val, val); > > + if (ret) > > + return ret; > > Overall, I like this approach! Easy to read and understand. > > > > > > +static int mt6370_bl_probe(struct platform_device *pdev) > > +{ > > + struct mt6370_priv *priv; > > + struct backlight_properties props =3D { > > + .type =3D BACKLIGHT_RAW, > > + .scale =3D BACKLIGHT_SCALE_LINEAR, > > Sorry, I missed this before but the KConfig comment says that the > backlight can support both linear and exponential curves. > > Is there a good reason to default to linear? Well... The customers who used this PMIC have very few or even no use exponential c= urve, so I set the default to linear. If you think this is inappropriate, I will add a DT property to control this feature in the next patch! By the way, I found some mistakes in my probe() function... I didn't use "return" when I use dev_err_probe()... I will refine it in the next patch! > > > Daniel. > > Best regards, ChiaEn Wu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 627F1C433EF for ; Fri, 24 Jun 2022 09:56:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B082910E4C2; Fri, 24 Jun 2022 09:56:53 +0000 (UTC) Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id A886310E538 for ; Fri, 24 Jun 2022 09:56:52 +0000 (UTC) Received: by mail-il1-x12d.google.com with SMTP id 9so1155284ill.5 for ; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=HsRYekV2sU4Xv613pAvXWZuwPyAd8ueafTN7t5ELrygCaBWqwnSFn/yimTyvXphliU rk/k1nDNQ3ECBrZQCQibcC5/SXphAPug9oObZB9Femn+4ZMKO367Z07kbw302ugSier+ 3u6Ie+cqpVmNjf+nVQ2o9wUhernyrputNPwEkW+iFxQ7yrQw609omGwbvjVllqqdkQlb DFP5VJKZgPzIyttK1WQpTnymekzhmxmCFLdIDv+zhBnfs0Quw4/dsjyIWcL8P0Yv01Hh HffrHojwf2vBBMXK+Xv5kciDDgUaOI7o+FqSBYVUB7RtJd64wGJ3mx0TRrsc6+x3jNA+ Uofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=nGxpXY4fG+OSvkEkSQ8ppOp3T1I3504oD441EP9ExfxG9cR1tALZ9k29ysd/JOjGLS ya82gfHF4SUD0Xe4Et3Hm2JtPQaYYLsepZz0LjHn08nB5RxVq2sFpBH50kpsGf6U81g/ 36FhMdu6eP3Gg6HORvkRmDZ4misKs/dU9Afz9Zwq6X7mZbi6rb0V4GdGV/nVjvUSedbz 0Xa+WBBgA5+H7s99Yc/e2uQu6As1SRuBypK4fUZwxceZnIV0MX0EBrCNB2bWiXLrHbsX rGAVz1nkMaGvc+WYLXswZR0qX6EuJHA5VeupQkZHI//q9AH74zsZZSApeOSJI1uBaia1 7Ctw== X-Gm-Message-State: AJIora/4JdQtP3hznaZDmlaYgA0tBQONLUUWjzWSR5PiFBDMuz6SJqqR lMrQjxpMWx6NP4XFbtwTRB0+mMxkyz/LY/QTFVI= X-Google-Smtp-Source: AGRyM1u4tHhqAdEi5ogAeS0dS5voh35vGz3kiJUl5ktCSsYPoM0YYC7H2ztWgE2w6YlrhoWKAwKgDMijTEOWiU+6IC8= X-Received: by 2002:a05:6e02:10cf:b0:2d9:2310:e6b3 with SMTP id s15-20020a056e0210cf00b002d92310e6b3mr7601053ilj.212.1656064612053; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-15-peterwu.pub@gmail.com> <20220623134316.rg3adyobz3hkgflt@maple.lan> In-Reply-To: <20220623134316.rg3adyobz3hkgflt@maple.lan> From: ChiaEn Wu Date: Fri, 24 Jun 2022 17:56:41 +0800 Message-ID: Subject: Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support To: Daniel Thompson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, heikki.krogerus@linux.intel.com, krzysztof.kozlowski+dt@linaro.org, Alice Chen , linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org, lgirdwood@gmail.com, ChiYuan Huang , pavel@ucw.cz, Lee Jones , linux-leds@vger.kernel.org, deller@gmx.de, robh+dt@kernel.org, chunfeng.yun@mediatek.com, linux@roeck-us.net, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, szunichen@gmail.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, jingoohan1@gmail.com, linux-usb@vger.kernel.org, sre@kernel.org, linux-kernel@vger.kernel.org, ChiaEn Wu , gregkh@linuxfoundation.org, Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, Thanks for your comments! Daniel Thompson =E6=96=BC 2022=E5=B9=B46=E6=9C= =8823=E6=97=A5 =E9=80=B1=E5=9B=9B =E6=99=9A=E4=B8=8A9:43=E5=AF=AB=E9=81=93= =EF=BC=9A > > On Thu, Jun 23, 2022 at 07:56:31PM +0800, ChiaEn Wu wrote: > > From: ChiaEn Wu > > > > Add Mediatek MT6370 Backlight support. > > > > Signed-off-by: ChiaEn Wu > > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/= Kconfig > > index a003e02..7cd823d 100644 > > > > +static int mt6370_init_backlight_properties(struct mt6370_priv *priv, > > + struct backlight_properties *= props) > > +{ > > + struct device *dev =3D priv->dev; > > + u8 prop_val; > > + u32 brightness, ovp_uV, ocp_uA; > > + unsigned int mask, val; > > + int ret; > > + > > + /* Vendor optional properties */ > > + val =3D 0; > > + if (device_property_read_bool(dev, "mediatek,bled-pwm-enable")) > > + val |=3D MT6370_BL_PWM_EN_MASK; > > + > > + if (device_property_read_bool(dev, "mediatek,bled-pwm-hys-enable"= )) > > + val |=3D MT6370_BL_PWM_HYS_EN_MASK; > > + > > + ret =3D device_property_read_u8(dev, > > + "mediatek,bled-pwm-hys-input-th-ste= ps", > > + &prop_val); > > + if (!ret) { > > + prop_val =3D clamp_val(prop_val, > > + MT6370_BL_PWM_HYS_TH_MIN_STEP, > > + MT6370_BL_PWM_HYS_TH_MAX_STEP); > > + /* > > + * prop_val =3D 1 --> 1 steps --> 0x00 > > + * prop_val =3D 2 ~ 4 --> 4 steps --> 0x01 > > + * prop_val =3D 5 ~ 16 --> 16 steps --> 0x10 > > + * prop_val =3D 17 ~ 64 --> 64 steps --> 0x11 > > ^^^^^ > These numbers are binary, not hex, right? If so, the comments > should be 0b00 to 0b03 . Ohh! Yes! These numbers are binary! I so apologize for making this mistake... I will revise the comments in the next patch! Thank you so much! > > > > + */ > > + prop_val =3D (ilog2(roundup_pow_of_two(prop_val)) + 1) >>= 1; > > + val |=3D prop_val << (ffs(MT6370_BL_PWM_HYS_SEL_MASK) - 1= ); > > + } > > + > > + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_BL_PWM, > > + val, val); > > + if (ret) > > + return ret; > > Overall, I like this approach! Easy to read and understand. > > > > > > +static int mt6370_bl_probe(struct platform_device *pdev) > > +{ > > + struct mt6370_priv *priv; > > + struct backlight_properties props =3D { > > + .type =3D BACKLIGHT_RAW, > > + .scale =3D BACKLIGHT_SCALE_LINEAR, > > Sorry, I missed this before but the KConfig comment says that the > backlight can support both linear and exponential curves. > > Is there a good reason to default to linear? Well... The customers who used this PMIC have very few or even no use exponential c= urve, so I set the default to linear. If you think this is inappropriate, I will add a DT property to control this feature in the next patch! By the way, I found some mistakes in my probe() function... I didn't use "return" when I use dev_err_probe()... I will refine it in the next patch! > > > Daniel. > > Best regards, ChiaEn Wu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45209C43334 for ; Fri, 24 Jun 2022 09:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DrfJWCjjxXVJNaPW2qZTo0nWZwzQBNpXEj9yxCWjKYw=; b=EEBmIx4gBmHs4e 9HHJdxyiaqfVUk/2pz/l/k94ISc0IfvHbtTx1vZXNXpohed8Y60RkUPrbKswg8XI7NOysuliYReS6 9LKIDYvFFZwmXgazCYoZvzGOAh0VMReD6pLNIgUJh1/J8QQrIhCsfZDPk4f7kn7LjYZVxnbcWNiNW jhVLvxAEjgyrlu3SYlj9EvL2YzeYnAzHpV8lNVEXafCd5q60dk7kYblzkj/Lv+fDVS5VOEB9Ta7rB 7v/NuZdWeq6SGuz5cEf3i/bw6440JglGAqvxZreTYp6KuHXOGv0L7egIot5ODOI5k/3WqgQyfOoq1 URgf3gUSxKb+EgnjMg/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4g3d-001ZpF-1g; Fri, 24 Jun 2022 09:56:57 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4g3Z-001ZoM-Ux; Fri, 24 Jun 2022 09:56:55 +0000 Received: by mail-il1-x12f.google.com with SMTP id i17so1130666ils.12; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=HsRYekV2sU4Xv613pAvXWZuwPyAd8ueafTN7t5ELrygCaBWqwnSFn/yimTyvXphliU rk/k1nDNQ3ECBrZQCQibcC5/SXphAPug9oObZB9Femn+4ZMKO367Z07kbw302ugSier+ 3u6Ie+cqpVmNjf+nVQ2o9wUhernyrputNPwEkW+iFxQ7yrQw609omGwbvjVllqqdkQlb DFP5VJKZgPzIyttK1WQpTnymekzhmxmCFLdIDv+zhBnfs0Quw4/dsjyIWcL8P0Yv01Hh HffrHojwf2vBBMXK+Xv5kciDDgUaOI7o+FqSBYVUB7RtJd64wGJ3mx0TRrsc6+x3jNA+ Uofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=M4nnsvgHgIi0r2ItWc5dFuhTU+zH2GcT6p/faSXA7jc=; b=Lm06BYUVmSD3icW23rczh6xgDUMOPoGm/5NfnJLqGGq2JOnb0clHmiHC+yu99T3+AC TI1avTBaukkgXWjo5Q/UrkvtIOmlNYtfmK51vhCB3uemS/PZzvPRJmuINronGGIQjEFr mpSZfnseN6PXWoK9sS2RyQI3tuvo3e4oa5V5OOCAQFBj/cELpM27DSsu+7yqx7bhVVv9 mDpOGxMlKtQ0KiFqRehoTFLOyZoJ/34fwgsNa+5DOLCqi5mjIbk1/cQvNEayo4M3cJKM ZB9GRzOBNOQYdQWgAQckvLGKJ6qcIB1i0un68fjbwxHY/QwVT9iC/8EHv0C4k0Xq7ZCe p5cQ== X-Gm-Message-State: AJIora+X2FE6Tr1EJ/rEkpyJj39DWmy+yS26rMW13D95FVmloPZW1BhB pSDAl3WQ+2iuM34lxlsKNPRcs84hkoToP2gBfqA= X-Google-Smtp-Source: AGRyM1u4tHhqAdEi5ogAeS0dS5voh35vGz3kiJUl5ktCSsYPoM0YYC7H2ztWgE2w6YlrhoWKAwKgDMijTEOWiU+6IC8= X-Received: by 2002:a05:6e02:10cf:b0:2d9:2310:e6b3 with SMTP id s15-20020a056e0210cf00b002d92310e6b3mr7601053ilj.212.1656064612053; Fri, 24 Jun 2022 02:56:52 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-15-peterwu.pub@gmail.com> <20220623134316.rg3adyobz3hkgflt@maple.lan> In-Reply-To: <20220623134316.rg3adyobz3hkgflt@maple.lan> From: ChiaEn Wu Date: Fri, 24 Jun 2022 17:56:41 +0800 Message-ID: Subject: Re: [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support To: Daniel Thompson Cc: Lee Jones , jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, sre@kernel.org, chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org, Jonathan Cameron , lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net, heikki.krogerus@linux.intel.com, deller@gmx.de, ChiaEn Wu , Alice Chen , ChiYuan Huang , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, szunichen@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_025654_059246_68457CA9 X-CRM114-Status: GOOD ( 25.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzIQoKRGFuaWVsIFRob21wc29uIDxk YW5pZWwudGhvbXBzb25AbGluYXJvLm9yZz4g5pa8IDIwMjLlubQ25pyIMjPml6Ug6YCx5ZubIOaZ muS4ijk6NDPlr6vpgZPvvJoKPgo+IE9uIFRodSwgSnVuIDIzLCAyMDIyIGF0IDA3OjU2OjMxUE0g KzA4MDAsIENoaWFFbiBXdSB3cm90ZToKPiA+IEZyb206IENoaWFFbiBXdSA8Y2hpYWVuX3d1QHJp Y2h0ZWsuY29tPgo+ID4KPiA+IEFkZCBNZWRpYXRlayBNVDYzNzAgQmFja2xpZ2h0IHN1cHBvcnQu Cj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQ2hpYUVuIFd1IDxjaGlhZW5fd3VAcmljaHRlay5jb20+ Cj4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9LY29uZmlnIGIvZHJp dmVycy92aWRlby9iYWNrbGlnaHQvS2NvbmZpZwo+ID4gaW5kZXggYTAwM2UwMi4uN2NkODIzZCAx MDA2NDQKPiA+IDxzbmlwPgo+ID4gK3N0YXRpYyBpbnQgbXQ2MzcwX2luaXRfYmFja2xpZ2h0X3By b3BlcnRpZXMoc3RydWN0IG10NjM3MF9wcml2ICpwcml2LAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGJhY2tsaWdodF9wcm9wZXJ0aWVzICpwcm9w cykKPiA+ICt7Cj4gPiArICAgICBzdHJ1Y3QgZGV2aWNlICpkZXYgPSBwcml2LT5kZXY7Cj4gPiAr ICAgICB1OCBwcm9wX3ZhbDsKPiA+ICsgICAgIHUzMiBicmlnaHRuZXNzLCBvdnBfdVYsIG9jcF91 QTsKPiA+ICsgICAgIHVuc2lnbmVkIGludCBtYXNrLCB2YWw7Cj4gPiArICAgICBpbnQgcmV0Owo+ ID4gKwo+ID4gKyAgICAgLyogVmVuZG9yIG9wdGlvbmFsIHByb3BlcnRpZXMgKi8KPiA+ICsgICAg IHZhbCA9IDA7Cj4gPiArICAgICBpZiAoZGV2aWNlX3Byb3BlcnR5X3JlYWRfYm9vbChkZXYsICJt ZWRpYXRlayxibGVkLXB3bS1lbmFibGUiKSkKPiA+ICsgICAgICAgICAgICAgdmFsIHw9IE1UNjM3 MF9CTF9QV01fRU5fTUFTSzsKPiA+ICsKPiA+ICsgICAgIGlmIChkZXZpY2VfcHJvcGVydHlfcmVh ZF9ib29sKGRldiwgIm1lZGlhdGVrLGJsZWQtcHdtLWh5cy1lbmFibGUiKSkKPiA+ICsgICAgICAg ICAgICAgdmFsIHw9IE1UNjM3MF9CTF9QV01fSFlTX0VOX01BU0s7Cj4gPiArCj4gPiArICAgICBy ZXQgPSBkZXZpY2VfcHJvcGVydHlfcmVhZF91OChkZXYsCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAibWVkaWF0ZWssYmxlZC1wd20taHlzLWlucHV0LXRoLXN0ZXBzIiwK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwcm9wX3ZhbCk7Cj4gPiAr ICAgICBpZiAoIXJldCkgewo+ID4gKyAgICAgICAgICAgICBwcm9wX3ZhbCA9IGNsYW1wX3ZhbChw cm9wX3ZhbCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTVQ2MzcwX0JM X1BXTV9IWVNfVEhfTUlOX1NURVAsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIE1UNjM3MF9CTF9QV01fSFlTX1RIX01BWF9TVEVQKTsKPiA+ICsgICAgICAgICAgICAgLyoK PiA+ICsgICAgICAgICAgICAgICogcHJvcF92YWwgPSAgMSAgICAgIC0tPiAgMSBzdGVwcyAtLT4g MHgwMAo+ID4gKyAgICAgICAgICAgICAgKiBwcm9wX3ZhbCA9ICAyIH4gIDQgLS0+ICA0IHN0ZXBz IC0tPiAweDAxCj4gPiArICAgICAgICAgICAgICAqIHByb3BfdmFsID0gIDUgfiAxNiAtLT4gMTYg c3RlcHMgLS0+IDB4MTAKPiA+ICsgICAgICAgICAgICAgICogcHJvcF92YWwgPSAxNyB+IDY0IC0t PiA2NCBzdGVwcyAtLT4gMHgxMQo+Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXl5eXl4KPiBUaGVzZSBudW1iZXJzIGFyZSBiaW5hcnksIG5v dCBoZXgsIHJpZ2h0PyBJZiBzbywgdGhlIGNvbW1lbnRzCj4gc2hvdWxkIGJlIDBiMDAgdG8gMGIw MyAuCgpPaGghIFllcyEgVGhlc2UgbnVtYmVycyBhcmUgYmluYXJ5IQpJIHNvIGFwb2xvZ2l6ZSBm b3IgbWFraW5nIHRoaXMgbWlzdGFrZS4uLgpJIHdpbGwgcmV2aXNlIHRoZSBjb21tZW50cyBpbiB0 aGUgbmV4dCBwYXRjaCEKVGhhbmsgeW91IHNvIG11Y2ghCgo+Cj4KPiA+ICsgICAgICAgICAgICAg ICovCj4gPiArICAgICAgICAgICAgIHByb3BfdmFsID0gKGlsb2cyKHJvdW5kdXBfcG93X29mX3R3 byhwcm9wX3ZhbCkpICsgMSkgPj4gMTsKPiA+ICsgICAgICAgICAgICAgdmFsIHw9IHByb3BfdmFs IDw8IChmZnMoTVQ2MzcwX0JMX1BXTV9IWVNfU0VMX01BU0spIC0gMSk7Cj4gPiArICAgICB9Cj4g PiArCj4gPiArICAgICByZXQgPSByZWdtYXBfdXBkYXRlX2JpdHMocHJpdi0+cmVnbWFwLCBNVDYz NzBfUkVHX0JMX1BXTSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWwsIHZh bCk7Cj4gPiArICAgICBpZiAocmV0KQo+ID4gKyAgICAgICAgICAgICByZXR1cm4gcmV0Owo+Cj4g T3ZlcmFsbCwgSSBsaWtlIHRoaXMgYXBwcm9hY2ghIEVhc3kgdG8gcmVhZCBhbmQgdW5kZXJzdGFu ZC4KPgo+Cj4gPiA8c25pcD4KPiA+ICtzdGF0aWMgaW50IG10NjM3MF9ibF9wcm9iZShzdHJ1Y3Qg cGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gK3sKPiA+ICsgICAgIHN0cnVjdCBtdDYzNzBfcHJp diAqcHJpdjsKPiA+ICsgICAgIHN0cnVjdCBiYWNrbGlnaHRfcHJvcGVydGllcyBwcm9wcyA9IHsK PiA+ICsgICAgICAgICAgICAgLnR5cGUgPSBCQUNLTElHSFRfUkFXLAo+ID4gKyAgICAgICAgICAg ICAuc2NhbGUgPSBCQUNLTElHSFRfU0NBTEVfTElORUFSLAo+Cj4gU29ycnksIEkgbWlzc2VkIHRo aXMgYmVmb3JlIGJ1dCB0aGUgS0NvbmZpZyBjb21tZW50IHNheXMgdGhhdCB0aGUKPiBiYWNrbGln aHQgY2FuIHN1cHBvcnQgYm90aCBsaW5lYXIgYW5kIGV4cG9uZW50aWFsIGN1cnZlcy4KPgo+IElz IHRoZXJlIGEgZ29vZCByZWFzb24gdG8gZGVmYXVsdCB0byBsaW5lYXI/CgpXZWxsLi4uClRoZSBj dXN0b21lcnMgd2hvIHVzZWQgdGhpcyBQTUlDIGhhdmUgdmVyeSBmZXcgb3IgZXZlbiBubyB1c2Ug ZXhwb25lbnRpYWwgY3VydmUsCnNvIEkgc2V0IHRoZSBkZWZhdWx0IHRvIGxpbmVhci4KCklmIHlv dSB0aGluayB0aGlzIGlzIGluYXBwcm9wcmlhdGUsIEkgd2lsbCBhZGQgYSBEVCBwcm9wZXJ0eSB0 bwpjb250cm9sIHRoaXMgZmVhdHVyZSBpbiB0aGUgbmV4dCBwYXRjaCEKCkJ5IHRoZSB3YXksCkkg Zm91bmQgc29tZSBtaXN0YWtlcyBpbiBteSBwcm9iZSgpIGZ1bmN0aW9uLi4uIEkgZGlkbid0IHVz ZSAicmV0dXJuIgp3aGVuIEkgdXNlIGRldl9lcnJfcHJvYmUoKS4uLgpJIHdpbGwgcmVmaW5lIGl0 IGluIHRoZSBuZXh0IHBhdGNoIQoKPgo+Cj4gRGFuaWVsLgo+ID4KCkJlc3QgcmVnYXJkcywKQ2hp YUVuIFd1CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==