All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	YH Chen <yh.chen@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Henry Chen <henryc.chen@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	"=Sascha Hauer" <kernel@pengutronix.de>,
	Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173
Date: Wed, 15 Apr 2015 17:11:27 +0200	[thread overview]
Message-ID: <CABuKBe+MnmL47FB2FhN=RRKEZV4tR3OyVTTpWfkTYQ4zSZP22Q@mail.gmail.com> (raw)
In-Reply-To: <20150414115702.GX9742@pengutronix.de>

2015-04-14 13:57 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Tue, Apr 14, 2015 at 01:01:30PM +0200, Matthias Brugger wrote:
>> Hi Sascha,
>>
>> 2015-04-14 12:08 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
>> > Hi Matthias,
>> >
>> > On Tue, Apr 07, 2015 at 01:47:58PM +0200, Matthias Brugger wrote:
>> >> Hi Sascha,
>> >>
>> >>
>> >> 2015-03-31 20:16 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
>> >> >
>> >> > The following changes since commit 9eccca0843205f87c00404b663188b88eb248051:
>> >> >
>> >> >   Linux 4.0-rc3 (2015-03-08 16:09:09 -0700)
>> >> >
>> >> > are available in the git repository at:
>> >> >
>> >> >   git://git.pengutronix.de/git/imx/linux-2.6.git tags/v4.0-clk-mediatek-v11
>> >> >
>> >> > for you to fetch changes up to ae9129219143cfdefe8b3a463deb8c5cb8955525:
>> >> >
>> >> >   dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers (2015-03-31 20:08:46 +0200)
>> >> >
>> >> > ----------------------------------------------------------------
>> >> > This patchset contains the initial common clock support for Mediatek SoCs.
>> >> > Mediatek SoC's clock architecture comprises of various PLLs, dividers, muxes
>> >> > and clock gates.
>> >>
>> >> I tried the patch set on my mt8135 eval board. I used the dts bindings
>> >> from a former version of this set [1], but it does not boot the board
>> >> (based on v4.0-rc7).
>> >> Do you have any hint, what is happening, or are the bindings wrong?
>> >
>> > I just tried on a v4.0 with
>> > - this series applied
>> > - the dts patch applied (which is still up-to-date)
>> > - multi_v7_defconfig
>> >
>> > And it still works. What do you mean with "does not boot the board"? No
>> > console output? Could you try with earlyprintk?
>>
>> The probelms I see is, that with the clock patches, I'm not able to
>> boot into a initramfs [1].
>> Whereas if I just comment topckgen and preicfg in the dts, I'm able to
>> get the a serial console of my initramfs [2].
>>
>> I wonder if you are able to get serial console from the initramfs with
>> the clock patches + dts patch?
>
> So you get kernel messages but no output from initramfs? In this case
> the kernel disables the unused clocks in a late_initcall. The UART
> driver still uses the dummy clock provided in the dtsi, so the real
> UART clk gets disabled in the initcall. Try passing clk_ignore_unused to
> the kernel

OK, I can boot to the initramfs with this kernel parameter, but it
fails to boot, when I change the uart clock. I suppose that PERI_UART3
for debug port uart3 should be fine, but it looks like it doesn't
work.
I can see on the mt6589 datasheet that you have a register
PERI_UART_CK_SOURCE_SEL where you can decide if you want a 26 MHz or a
52 MHz clock for the UART block.
Does this register exists on mt8135? If so, why is it not implemented?

-- 
motzblog.wordpress.com

WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173
Date: Wed, 15 Apr 2015 17:11:27 +0200	[thread overview]
Message-ID: <CABuKBe+MnmL47FB2FhN=RRKEZV4tR3OyVTTpWfkTYQ4zSZP22Q@mail.gmail.com> (raw)
In-Reply-To: <20150414115702.GX9742@pengutronix.de>

2015-04-14 13:57 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Tue, Apr 14, 2015 at 01:01:30PM +0200, Matthias Brugger wrote:
>> Hi Sascha,
>>
>> 2015-04-14 12:08 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
>> > Hi Matthias,
>> >
>> > On Tue, Apr 07, 2015 at 01:47:58PM +0200, Matthias Brugger wrote:
>> >> Hi Sascha,
>> >>
>> >>
>> >> 2015-03-31 20:16 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
>> >> >
>> >> > The following changes since commit 9eccca0843205f87c00404b663188b88eb248051:
>> >> >
>> >> >   Linux 4.0-rc3 (2015-03-08 16:09:09 -0700)
>> >> >
>> >> > are available in the git repository at:
>> >> >
>> >> >   git://git.pengutronix.de/git/imx/linux-2.6.git tags/v4.0-clk-mediatek-v11
>> >> >
>> >> > for you to fetch changes up to ae9129219143cfdefe8b3a463deb8c5cb8955525:
>> >> >
>> >> >   dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers (2015-03-31 20:08:46 +0200)
>> >> >
>> >> > ----------------------------------------------------------------
>> >> > This patchset contains the initial common clock support for Mediatek SoCs.
>> >> > Mediatek SoC's clock architecture comprises of various PLLs, dividers, muxes
>> >> > and clock gates.
>> >>
>> >> I tried the patch set on my mt8135 eval board. I used the dts bindings
>> >> from a former version of this set [1], but it does not boot the board
>> >> (based on v4.0-rc7).
>> >> Do you have any hint, what is happening, or are the bindings wrong?
>> >
>> > I just tried on a v4.0 with
>> > - this series applied
>> > - the dts patch applied (which is still up-to-date)
>> > - multi_v7_defconfig
>> >
>> > And it still works. What do you mean with "does not boot the board"? No
>> > console output? Could you try with earlyprintk?
>>
>> The probelms I see is, that with the clock patches, I'm not able to
>> boot into a initramfs [1].
>> Whereas if I just comment topckgen and preicfg in the dts, I'm able to
>> get the a serial console of my initramfs [2].
>>
>> I wonder if you are able to get serial console from the initramfs with
>> the clock patches + dts patch?
>
> So you get kernel messages but no output from initramfs? In this case
> the kernel disables the unused clocks in a late_initcall. The UART
> driver still uses the dummy clock provided in the dtsi, so the real
> UART clk gets disabled in the initcall. Try passing clk_ignore_unused to
> the kernel

OK, I can boot to the initramfs with this kernel parameter, but it
fails to boot, when I change the uart clock. I suppose that PERI_UART3
for debug port uart3 should be fine, but it looks like it doesn't
work.
I can see on the mt6589 datasheet that you have a register
PERI_UART_CK_SOURCE_SEL where you can decide if you want a 26 MHz or a
52 MHz clock for the UART block.
Does this register exists on mt8135? If so, why is it not implemented?

-- 
motzblog.wordpress.com

  reply	other threads:[~2015-04-15 15:11 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31 18:16 [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-31 18:16 ` Sascha Hauer
2015-03-31 18:16 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-04-09  7:27   ` Krzysztof Kozlowski
2015-04-09  7:27     ` Krzysztof Kozlowski
2015-03-31 18:16 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-04-09 17:03   ` Matthias Brugger
2015-04-09 17:03     ` Matthias Brugger
2015-04-09 17:03     ` Matthias Brugger
2015-03-31 18:16 ` [PATCH 3/6] clk: mediatek: Add reset controller support Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-03-31 18:16 ` [PATCH 4/6] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-04-09 17:05   ` Matthias Brugger
2015-04-09 17:05     ` Matthias Brugger
2015-04-09 17:05     ` Matthias Brugger
2015-04-13  9:53     ` Sascha Hauer
2015-04-13  9:53       ` Sascha Hauer
2015-04-13  9:53       ` Sascha Hauer
2015-03-31 18:16 ` [PATCH 5/6] clk: mediatek: Add basic clocks for Mediatek MT8173 Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-03-31 18:16 ` [PATCH 6/6] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers Sascha Hauer
2015-03-31 18:16   ` Sascha Hauer
2015-04-07 11:47 ` [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173 Matthias Brugger
2015-04-07 11:47   ` Matthias Brugger
2015-04-07 11:47   ` Matthias Brugger
2015-04-13  9:58   ` Sascha Hauer
2015-04-13  9:58     ` Sascha Hauer
2015-04-13  9:58     ` Sascha Hauer
2015-04-14 10:08   ` Sascha Hauer
2015-04-14 10:08     ` Sascha Hauer
2015-04-14 10:08     ` Sascha Hauer
2015-04-14 11:01     ` Matthias Brugger
2015-04-14 11:01       ` Matthias Brugger
2015-04-14 11:01       ` Matthias Brugger
2015-04-14 11:57       ` Sascha Hauer
2015-04-14 11:57         ` Sascha Hauer
2015-04-14 11:57         ` Sascha Hauer
2015-04-15 15:11         ` Matthias Brugger [this message]
2015-04-15 15:11           ` Matthias Brugger
2015-04-15 15:11           ` Matthias Brugger
2015-04-15 15:48           ` Matthias Brugger
2015-04-15 15:48             ` Matthias Brugger
2015-04-15 15:48             ` Matthias Brugger
2015-04-16 13:36             ` Sascha Hauer
2015-04-16 13:36               ` Sascha Hauer
2015-04-16 13:36               ` Sascha Hauer
2015-04-23  9:25             ` Sascha Hauer
2015-04-23  9:25               ` Sascha Hauer
2015-04-23  9:25               ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABuKBe+MnmL47FB2FhN=RRKEZV4tR3OyVTTpWfkTYQ4zSZP22Q@mail.gmail.com' \
    --to=matthias.bgg@gmail.com \
    --cc=Yingjoe.Chen@mediatek.com \
    --cc=eddie.huang@mediatek.com \
    --cc=henryc.chen@mediatek.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mturquette@linaro.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@codeaurora.org \
    --cc=yh.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.