All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hengelein <stefan.hengelein@fau.de>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
	Michal Marek <mmarek@suse.cz>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	Andreas Ruprecht <rupran@einserver.de>,
	Martin Walch <walch.martin@web.de>,
	linux-kbuild@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols
Date: Sun, 12 Apr 2015 17:02:10 +0200	[thread overview]
Message-ID: <CABv5NL-Qtn6_etdJziUkDZZc=e8DYZfMgsMRxZjmozdG2sj7yA@mail.gmail.com> (raw)
In-Reply-To: <1428791102.17822.175.camel@x220>

> Let's focus, for example, on m32r and FRAME_POINTER. The m32r entry for
> that symbol reads:
>         config FRAME_POINTER
>                 bool "Compile the kernel with frame pointers"
>                 help
>                   If you say Y here [...]
>
> 0) If one is building for m32r is that all there's to it? If so, "make
> menuconfig"'s search facility is serving the people building for m32r a
> load of crap.
>
> 1) If it's actually more complicated than that I think that anyone
> reading arch/m32r/Kconfig.debug is being duped. Things look simple but
> actually they are quite complicated. I think that's just wrong.
>
> What am I missing here?

If you have a look at the definitions, lib/Kconfig.debug is included
before FRAME_POINTER is defined in m32r and the output in the search
facility looks indeed broken
as one "Defined at" is missing but there are somehow Location entries
(-> Kernel hacking    and  -> Kernel hacking -> compile time checks
and [...]) for both definitions in a weird order (i think (1) and (2)
might indicate both definitions)

both declarations are valid in kconfig, you have two ways of enabling
the same symbol, one easy without conditions and one with conditions
and both with the same prompt.

The search facility shows the first one that is found, you see the
complicated depends on but i think the text shown might not be
explicit enough to clarify you don't need to satisfy these complicated
conditions to actually choose a value.

Stefan

  reply	other threads:[~2015-04-12 15:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 23:56 [PATCH 1/2] kconfig: Print full defined and depends for multiply-defined symbols Gregory Fong
2015-04-08 23:56 ` Gregory Fong
2015-04-08 23:59 ` Gregory Fong
2015-04-10 21:25 ` Paul Bolle
2015-04-11 16:36   ` Stefan Hengelein
2015-04-11 18:56     ` Paul Bolle
2015-04-11 19:58       ` Stefan Hengelein
2015-04-11 20:23         ` Paul Bolle
2015-04-11 21:46           ` Stefan Hengelein
2015-04-11 22:25             ` Paul Bolle
2015-04-12 15:02               ` Stefan Hengelein [this message]
2015-04-13  1:06                 ` Gregory Fong
2015-04-13  7:51                   ` Paul Bolle
2015-04-13 14:57                     ` Stefan Hengelein
2015-04-13 16:04                   ` Stefan Hengelein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABv5NL-Qtn6_etdJziUkDZZc=e8DYZfMgsMRxZjmozdG2sj7yA@mail.gmail.com' \
    --to=stefan.hengelein@fau.de \
    --cc=gregory.0xf0@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=pebolle@tiscali.nl \
    --cc=rupran@einserver.de \
    --cc=valentinrothberg@gmail.com \
    --cc=walch.martin@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.