From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:36592 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730204AbeG0NzV (ORCPT ); Fri, 27 Jul 2018 09:55:21 -0400 Received: by mail-qt0-f195.google.com with SMTP id t5-v6so4816865qtn.3 for ; Fri, 27 Jul 2018 05:33:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> From: =?UTF-8?Q?Micha=C5=82_Kazior?= Date: Fri, 27 Jul 2018 14:33:35 +0200 Message-ID: (sfid-20180727_143340_362759_4A12ECAF) Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips To: Wen Gong Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , ath10k@lists.infradead.org, Johannes Berg , linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On 27 July 2018 at 11:39, Wen Gong wrote: > On 2018-07-26 21:02, Micha=C5=82 Kazior wrote: >> >> On 26 July 2018 at 13:45, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>> >>> Wen Gong writes: >>> >>>> Upstream kernel has an interface to help adjust sk_pacing_shift to hel= p >>>> improve TCP UL throughput. >>>> The sk_pacing_shift is 8 in mac80211, this is based on test with 11N >>>> WiFi chips with ath9k. For QCA6174/QCA9377 PCI 11AC chips, the 11AC >>>> VHT80 TCP UL throughput testing result shows 6 is the optimal. >>>> Overwrite the sk_pacing_shift to 6 in ath10k driver. >>> >>> >>> When I tested this, a pacing shift of 8 was quite close to optimal as >>> well for ath10k. Why are you getting different results? >>> >>>> Tested with QCA6174 PCI with firmware >>>> WLAN.RM.4.4.1-00109-QCARMSWPZ-1, but this will also affect QCA9377 PCI= . >>>> It's not a regression with new firmware releases. >>>> >>>> There have 2 test result of different settings: >>>> >>>> ARM CPU based device with QCA6174A PCI with different >>>> sk_pacing_shift: >> >> >> Different firmware releases have different tx buffering >> characteristics. In some 10.2 firmware running on QCA9888 you can have >> up to 5ms of delayed aggregation. Ideally sk_pacing_shift should be >> adjusted per firmware release. Maybe this should become part of the >> ath10k firmware wrapping "fw features" stuff? >> > recently we do not want to do like this since no test data for each > firmware. All the more reason to *not* change the pacing shift from 8 to 6 for entire ath10k because you have no idea what impact that is going to have on other chips/firmwares, e.g. QCA4019, QCA9888X, QCA9984. Micha=C5=82 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fj1wK-0004oR-9g for ath10k@lists.infradead.org; Fri, 27 Jul 2018 12:33:49 +0000 Received: by mail-qt0-x243.google.com with SMTP id b15-v6so4811809qtp.11 for ; Fri, 27 Jul 2018 05:33:37 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> <6715f59dc8e834cddd701c6f9ee9f344@codeaurora.org> From: =?UTF-8?Q?Micha=C5=82_Kazior?= Date: Fri, 27 Jul 2018 14:33:35 +0200 Message-ID: Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: Johannes Berg , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , linux-wireless , ath10k@lists.infradead.org T24gMjcgSnVseSAyMDE4IGF0IDExOjM5LCBXZW4gR29uZyA8d2dvbmdAY29kZWF1cm9yYS5vcmc+ IHdyb3RlOgo+IE9uIDIwMTgtMDctMjYgMjE6MDIsIE1pY2hhxYIgS2F6aW9yIHdyb3RlOgo+Pgo+ PiBPbiAyNiBKdWx5IDIwMTggYXQgMTM6NDUsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9r ZUB0b2tlLmRrPiB3cm90ZToKPj4+Cj4+PiBXZW4gR29uZyA8d2dvbmdAY29kZWF1cm9yYS5vcmc+ IHdyaXRlczoKPj4+Cj4+Pj4gVXBzdHJlYW0ga2VybmVsIGhhcyBhbiBpbnRlcmZhY2UgdG8gaGVs cCBhZGp1c3Qgc2tfcGFjaW5nX3NoaWZ0IHRvIGhlbHAKPj4+PiBpbXByb3ZlIFRDUCBVTCB0aHJv dWdocHV0Lgo+Pj4+IFRoZSBza19wYWNpbmdfc2hpZnQgaXMgOCBpbiBtYWM4MDIxMSwgdGhpcyBp cyBiYXNlZCBvbiB0ZXN0IHdpdGggMTFOCj4+Pj4gV2lGaSBjaGlwcyB3aXRoIGF0aDlrLiBGb3Ig UUNBNjE3NC9RQ0E5Mzc3IFBDSSAxMUFDIGNoaXBzLCB0aGUgMTFBQwo+Pj4+IFZIVDgwIFRDUCBV TCB0aHJvdWdocHV0IHRlc3RpbmcgcmVzdWx0IHNob3dzIDYgaXMgdGhlIG9wdGltYWwuCj4+Pj4g T3ZlcndyaXRlIHRoZSBza19wYWNpbmdfc2hpZnQgdG8gNiBpbiBhdGgxMGsgZHJpdmVyLgo+Pj4K Pj4+Cj4+PiBXaGVuIEkgdGVzdGVkIHRoaXMsIGEgcGFjaW5nIHNoaWZ0IG9mIDggd2FzIHF1aXRl IGNsb3NlIHRvIG9wdGltYWwgYXMKPj4+IHdlbGwgZm9yIGF0aDEway4gV2h5IGFyZSB5b3UgZ2V0 dGluZyBkaWZmZXJlbnQgcmVzdWx0cz8KPj4+Cj4+Pj4gVGVzdGVkIHdpdGggUUNBNjE3NCBQQ0kg d2l0aCBmaXJtd2FyZQo+Pj4+IFdMQU4uUk0uNC40LjEtMDAxMDktUUNBUk1TV1BaLTEsIGJ1dCB0 aGlzIHdpbGwgYWxzbyBhZmZlY3QgUUNBOTM3NyBQQ0kuCj4+Pj4gSXQncyBub3QgYSByZWdyZXNz aW9uIHdpdGggbmV3IGZpcm13YXJlIHJlbGVhc2VzLgo+Pj4+Cj4+Pj4gVGhlcmUgaGF2ZSAyIHRl c3QgcmVzdWx0IG9mIGRpZmZlcmVudCBzZXR0aW5nczoKPj4+Pgo+Pj4+IEFSTSBDUFUgYmFzZWQg ZGV2aWNlIHdpdGggUUNBNjE3NEEgUENJIHdpdGggZGlmZmVyZW50Cj4+Pj4gc2tfcGFjaW5nX3No aWZ0Ogo+Pgo+Pgo+PiBEaWZmZXJlbnQgZmlybXdhcmUgcmVsZWFzZXMgaGF2ZSBkaWZmZXJlbnQg dHggYnVmZmVyaW5nCj4+IGNoYXJhY3RlcmlzdGljcy4gSW4gc29tZSAxMC4yIGZpcm13YXJlIHJ1 bm5pbmcgb24gUUNBOTg4OCB5b3UgY2FuIGhhdmUKPj4gdXAgdG8gNW1zIG9mIGRlbGF5ZWQgYWdn cmVnYXRpb24uIElkZWFsbHkgc2tfcGFjaW5nX3NoaWZ0IHNob3VsZCBiZQo+PiBhZGp1c3RlZCBw ZXIgZmlybXdhcmUgcmVsZWFzZS4gTWF5YmUgdGhpcyBzaG91bGQgYmVjb21lIHBhcnQgb2YgdGhl Cj4+IGF0aDEwayBmaXJtd2FyZSB3cmFwcGluZyAiZncgZmVhdHVyZXMiIHN0dWZmPwo+Pgo+IHJl Y2VudGx5IHdlIGRvIG5vdCB3YW50IHRvIGRvIGxpa2UgdGhpcyBzaW5jZSBubyB0ZXN0IGRhdGEg Zm9yIGVhY2gKPiBmaXJtd2FyZS4KCkFsbCB0aGUgbW9yZSByZWFzb24gdG8gKm5vdCogY2hhbmdl IHRoZSBwYWNpbmcgc2hpZnQgZnJvbSA4IHRvIDYgZm9yCmVudGlyZSBhdGgxMGsgYmVjYXVzZSB5 b3UgaGF2ZSBubyBpZGVhIHdoYXQgaW1wYWN0IHRoYXQgaXMgZ29pbmcgdG8KaGF2ZSBvbiBvdGhl ciBjaGlwcy9maXJtd2FyZXMsIGUuZy4gUUNBNDAxOSwgUUNBOTg4OFgsIFFDQTk5ODQuCgoKTWlj aGHFggoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRo MTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo=