From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E061C3A59B for ; Fri, 30 Aug 2019 22:28:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18E6C23431 for ; Fri, 30 Aug 2019 22:28:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="RAfZLisj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728342AbfH3W2j (ORCPT ); Fri, 30 Aug 2019 18:28:39 -0400 Received: from mx4.ucr.edu ([138.23.248.66]:7952 "EHLO mx4.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728271AbfH3W2i (ORCPT ); Fri, 30 Aug 2019 18:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1567204118; x=1598740118; h=mime-version:references:in-reply-to:from:date:message-id: subject:to:cc; bh=wgVygESRDZ4+rg/c5sOJBi+QyyM3UkHfyRMFo8KoCxI=; b=RAfZLisjzOUh7Cl2P/SoSGgX729miO4NgJDkxPlcrmKnLEB4pyzRIEpq TSS8UBMdPt5f0tdcgMIZL43olTbxqhVforFl8AP0PRPPXEUXOPrg9qHsr LOpL6rNwONiYay1Zcj0Xq5bqXGtRpgDlYuSzmSZV0xKbgTWMgr1jIIZmc Wx1DLhRRO95ohg1Sw107MTb5oa54StQnCEmt19R5rDKkj0/rUCWeB/alG Xx+MWfZHF1FIYWIvZ/0S1SxTsQUJZkIKxBjz5NC29fhuti/EDu+xXwpsA G23aLjQZkmBmFffB1eHpyQyemk4ggSBEk0EWYKSa/oVKVEkPV8RoYHD9H A==; IronPort-SDR: kr0Q9TL0/kFdncT9926ysFvpQAaMqrp2mUz2jFwkWhZ64JBHoNi9WdmR0AIRfFseROYXFwTv8G CXW8JpfyleoIQmG0eRz6Pl9dr6+L1vBgAW8MsW0biZepJVxB3XZm+cPYi+3ivks2sW5yAdZ/v0 1ZdXwA60Ru5FSRfLBFN37IfJOZ8IFRiMpAc/3lqmGVG2ZR8bmypbv/zBUU3pfI3eoaVduxPhhh ECLcgrQsFnterhoGvfL+rvqTrdKE1kZH5CddHclWbNHbOwfpZZsgdllVtrW6gVdyngKcH7Auxo e5Y= IronPort-PHdr: =?us-ascii?q?9a23=3AXoLW3B9YxSDOgv9uRHKM819IXTAuvvDOBiVQ1K?= =?us-ascii?q?B41OwcTK2v8tzYMVDF4r011RmVBN+dsqwZwLOP+4nbGkU4qa6bt34DdJEeHz?= =?us-ascii?q?Qksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPER?= =?us-ascii?q?vjKwV1Ov71GonPhMiryuy+4ZLebxhWiDanfL9/LRW7oQrMusULnIBvNrs/xh?= =?us-ascii?q?zVr3VSZu9Y33loJVWdnxb94se/4ptu+DlOtvwi6sBNT7z0c7w3QrJEAjsmNX?= =?us-ascii?q?s15NDwuhnYUQSP/HocXX4InRdOHgPI8Qv1Xpb1siv9q+p9xCyXNtD4QLwoRT?= =?us-ascii?q?iv6bpgRQT2gykbKTE27GDXitRxjK1FphKhuwd/yJPQbI2MKfZyYr/RcdYcSG?= =?us-ascii?q?FcXMheSjZBD5uzYIsBDeUPPehWoYrgqVUQsRSzHhWsCP/1xzNUmnP6wa833u?= =?us-ascii?q?I8Gg/GxgwgGNcOvWzWo9X0NaYSUf21zK7VxjrAb/NZwzb945XPfxEhoPCMXa?= =?us-ascii?q?h/ccvNxUUzGQ7IlUiQppD/Pz+PyOsCrnWb4vNmWOmyiGAnsxl8riazysookI?= =?us-ascii?q?XEhYIYxkrZ+Sh4wos5P9+1RFJ9bNW5CpVfrTuaOJFzQs46RmFovzs1xaMetJ?= =?us-ascii?q?6geSgK1IwnxxnCa/yba4SI4gzsVOKWITpggXJqYrO/hxKr/UikxO3wS9C40F?= =?us-ascii?q?hIoyZZiNXMuXcN1xvc6siDVPRx5Fuu2TGK1wzL6+FEJ147lbbDJpI/3rI9ko?= =?us-ascii?q?AfvEfDEyPshUn7ja2bel8m9+S08+jnZ6/ppp6YN496kAH+NaEul9S/AOU5Mg?= =?us-ascii?q?gBRWmb9fig2LDt5kD5XalFjucsnqbHrZ/aONwXprSlDA9NzoYj9xG/Ai+i0N?= =?us-ascii?q?QZm3kHMV1EdAuEj4f3IVHOJu73DfOkjlSynzdk2erGMqfiAprTNHjDlqnufb?= =?us-ascii?q?Jn505b0gozwoMX25UBJrgfIf67f071sNHCRks1OhK5xs7rActw04cZV37JBK?= =?us-ascii?q?KFZvD8q1iNs9MuMemRY8cnuD/8Y6w09f7njCdhwncAdrPv0JcKPiPrVs96Kl?= =?us-ascii?q?mUNCK/yuwKFn0H609nFLTn?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EPAACxomldf0anVdFmHAEBAQQBAQc?= =?us-ascii?q?EAQGBUwcBAQsBg1YzKoQhiByGb4IPk3aFJIF7AQgBAQEOLwEBhD8CgmEjNAk?= =?us-ascii?q?OAgMIAQEFAQEBAQEGBAEBAhABAQkLCwgnhUOCOikBgmcBAQEBAxIRVhALCwM?= =?us-ascii?q?GAQMCAh8HAgIiEgEFARwGEyKFCwWhY4EDPIskgTKIbgEIDIFJEnooAYt3ghe?= =?us-ascii?q?DbjU+h0+CWASBLgEBAY1AhxSWCQEGAoINFIwriCwbmGItpiIPIYEvghEzGiV?= =?us-ascii?q?/BmeBToJ6ji0iMI84AQE?= X-IPAS-Result: =?us-ascii?q?A2EPAACxomldf0anVdFmHAEBAQQBAQcEAQGBUwcBAQsBg?= =?us-ascii?q?1YzKoQhiByGb4IPk3aFJIF7AQgBAQEOLwEBhD8CgmEjNAkOAgMIAQEFAQEBA?= =?us-ascii?q?QEGBAEBAhABAQkLCwgnhUOCOikBgmcBAQEBAxIRVhALCwMGAQMCAh8HAgIiE?= =?us-ascii?q?gEFARwGEyKFCwWhY4EDPIskgTKIbgEIDIFJEnooAYt3gheDbjU+h0+CWASBL?= =?us-ascii?q?gEBAY1AhxSWCQEGAoINFIwriCwbmGItpiIPIYEvghEzGiV/BmeBToJ6ji0iM?= =?us-ascii?q?I84AQE?= X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="73993447" Received: from mail-lf1-f70.google.com ([209.85.167.70]) by smtpmx4.ucr.edu with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 15:28:37 -0700 Received: by mail-lf1-f70.google.com with SMTP id b30so1860355lfq.6 for ; Fri, 30 Aug 2019 15:28:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/OqUmnBUo2TwngZckoAVX/16b3P4Ti0vmh5QbNPt/qI=; b=Ha+/QoMDWGIzxLFFkhLjdMT/DcINnuktvBQdUPNVVQbcXHvmCYvTHvbYxuOsWhgUr3 S3yEBO3+xEH/RR0SQ/fD2ea3/w4cJEhywr8i+xbx4WCGY6kZg3Lx/Hkj04Gc8gbRfLbF kW6uUWfucaTbfC9J42VZ2StV2ild/B44EadHZfMsMoAMge+AtMbuou/7XzhwTrC+/qU9 ffQd5wLeozn9tZfbTOpglGTNXiPhVv3BtHq7+BNIc/7uAOBswW18NvkT5aRxZ7Zi7cO2 OfClZ0Vskv1HxkMqSN738Kb6vWhRUHT4Y4EBr35+v6+ZL6r2eZiI6PdfOa5KCuMtVwss FfKg== X-Gm-Message-State: APjAAAVNX38ooxkpM35AojGBX8b+aFO4cl6P1sTaoeuAF3DYgVXe5SDe kgg7XCpD0+g7RLr1ytvklIzzwcwRqBggoWI0NlsRfc9TtP0CSgex6Xbazpd7xFF+56cZ6Je8xUF zkrT56cpBr1SovecCV5XAne+0CjmVwxKi4UL7IHqwNw== X-Received: by 2002:a05:6512:304:: with SMTP id t4mr11134405lfp.15.1567204115690; Fri, 30 Aug 2019 15:28:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwa33Y9Bu9hA8LxhW9Vg/wJim85Pk0no7AsHr9XFg9pLsGspx5AJcu+yjlmeSKNUIJl9tL56jCgdsQd0GJsEII= X-Received: by 2002:a05:6512:304:: with SMTP id t4mr11134392lfp.15.1567204115524; Fri, 30 Aug 2019 15:28:35 -0700 (PDT) MIME-Version: 1.0 References: <20190207174623.16712-1-yzhai003@ucr.edu> <20190208.230117.1867217574108955553.davem@davemloft.net> In-Reply-To: <20190208.230117.1867217574108955553.davem@davemloft.net> From: Yizhuo Zhai Date: Fri, 30 Aug 2019 15:29:07 -0700 Message-ID: Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized To: David Miller Cc: Chengyu Song , Zhiyun Qian , Giuseppe Cavallaro , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David: Thanks for your feedback, this patch should work for v4.14. On Fri, Feb 8, 2019 at 11:01 PM David Miller wrote: > > From: Yizhuo > Date: Thu, 7 Feb 2019 09:46:23 -0800 > > > In function sun8i_dwmac_set_syscon(), local variable "val" could > > be uninitialized if function regmap_read() returns -EINVAL. > > However, it will be used directly in the if statement, which > > is potentially unsafe. > > > > Signed-off-by: Yizhuo > > This doesn't apply to any of my trees. -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A93C3A59B for ; Fri, 30 Aug 2019 22:28:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0703023431 for ; Fri, 30 Aug 2019 22:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uZkVZYt8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="LsQjKAj/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0703023431 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ucr.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hqekidmj/a4kjPTygVFqirOdEe3BE8gTAIo3aIyt6J0=; b=uZkVZYt89s8Mlh uySUH3IAnJ1srGj2tykIopppmYmbpR6w7L8ypVqxIt8RzAAfCoCI/qCpoRqFJ7j3r8VE4RcL6Y//Y OIj81xzuWBVfyukPSDqOZHFgiTlv/iT6Kwa4mP8M06b24pY0vgqkxZAC94MsU9UjpuUrBR8coXhfA ngWdUf7wP7jFfI3Ukm4w8CBYf1tN6Ox6B+5f+GL5mZWwCLRSUDIush+To/fu6oF3B18OiZS74iW69 Qhe1gyfvJT3hXFICR1xoD6ePH2XNIJRWrLtOJ4oFoQt7hpgb5zm8SbNeYRKLGHptzoBQPJbt/wSiG 2qUAaamUFwcRHFMhI3aA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3pO4-0000qE-IZ; Fri, 30 Aug 2019 22:28:56 +0000 Received: from mx2.ucr.edu ([138.23.62.3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3pO1-0000pq-8G for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 22:28:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1567204133; x=1598740133; h=mime-version:references:in-reply-to:from:date:message-id: subject:to:cc; bh=wgVygESRDZ4+rg/c5sOJBi+QyyM3UkHfyRMFo8KoCxI=; b=LsQjKAj/PCAjki1t1x1XkjyBXHpD7XeuzBrCT4JNfCWC37wiNErWiakD +WL6pZhVwLb7mMq1lFpbCD8OoOi7QcPrQaj72kAZhSEn/wJqUbBzJ2RlF aVjGDF9+IWtFKl8F14dr7agp9EUsBK/8IatPjUikZq+3U0vB3jsMNd1z2 SD1esGDXnrTzaUfQ9EOhdT/O+kSFO3oaNPUZaXCPG8uEDc49CqVBABCWu fVsBn7Gy4MmnvBPhPx126DYHn0FYq8v8Qcx4baCYbTPGmaF8WuhF5ReLw wEbwPyVRXJshsANUTuZwWELcMEFs1T0qllnwnht1Ro/Bb5rGAtg++cSgo Q==; IronPort-SDR: FHt80YGvEFw9T+5PHRowIVI85fAWvJabApy9nt4DfOk7LRYGg+OJ7YxDPpGfkKXMyt28c346LY ogCgLOj+Ead0c7iPwnYS3fRJttvd4EjiN9Gpycb5OQwt2mn+eN6ZIhyg60E+sTRFtb6TZYWSwp Aq4r3r4qm/b5Y52oGMz04RVQrpmNataBrcIkQAT8mVK8JcPpUnPq7q5508twQBcf9iOBML3qnq OJ/iRxFKMBJShvY/WueLymladsU4FAYTXqnpYULNc0Bti9EDdqdon6FU/M6ILE2SdIrxj4HGbH 3xg= IronPort-PHdr: =?us-ascii?q?9a23=3Am/1KgRxcjbE5LqjXCy+O+j09IxM/srCxBDY+r6?= =?us-ascii?q?Qd1OMUIJqq85mqBkHD//Il1AaPAdyBrasa1qGO4ujJYi8p2d65qncMcZhBBV?= =?us-ascii?q?cuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx?= =?us-ascii?q?7xKRR6JvjvGo7Vks+7y/2+94fcbglVmjaxe65+IRS2oAneqsUbhZZpJ7osxB?= =?us-ascii?q?fOvnZGYfldy3lyJVKUkRb858Ow84Bm/i9Npf8v9NNOXLvjcaggQrNWEDopM2?= =?us-ascii?q?Yu5M32rhbDVheA5mEdUmoNjBVFBRXO4QzgUZfwtiv6sfd92DWfMMbrQ704RS?= =?us-ascii?q?iu4qF2QxLzliwJKyA2/33WisxojaJUvhShpwBkw4XJZI2ZLedycr/Bcd8fQ2?= =?us-ascii?q?dKQ8RfWDFbAo6kYIQPAegOM+ZWoYf+ulUAswexCBKwBO/z0DJEmmP60bE43u?= =?us-ascii?q?knDArI3BYgH9ULsHnMrtr1NaYTUeCozKnP0D7MbPNW1i386IPVdR0gofCNXb?= =?us-ascii?q?JqfsrQ1UUjCw3Ig06NqYP5JTOZzPoCvHWG7+d5U++klm0pqxlprzSx2sshjp?= =?us-ascii?q?PFi4EVx1ze6Cl0wYQ4Kce6RUJnZ9OvDYFeuDuAN4RsR8MvW2RouCEnxbIYoZ?= =?us-ascii?q?O7Zy0KyIg/xx7YdvyHb5CE4hL9W+aVJjd1nHdld6i+hxa26ESgzuP8WtSt3F?= =?us-ascii?q?ZErCdJjsPAtn8K1xzU5ciHTuVy8l291jaI0gDf8uBEIUYqmqrHM5Mt3KI8m5?= =?us-ascii?q?4JvUnAHiL6glj6ga6Ue0k++OWk9/zrYrD8qZ+dM490hBv+MqMrmsGnAeU5Mw?= =?us-ascii?q?gOUHKa+eigyLHu81b0QKhWgf0siKXWro3VJdkDqq6jHwBVypoj6wq4Dzq+1N?= =?us-ascii?q?QYnH8HLE9KeR6elYfpIVTOLOn7DfihmVSslilkx/TdM73lA5XNNWTDkKz7cb?= =?us-ascii?q?Z87U5cxhAzwspC6J1KEL4OPej/WkjrtNzXXVcFNFmYyvjmBJ1Y14caVHjHVq?= =?us-ascii?q?OQLq7XmVOB+O8qJ+6CeMkTtSqreNY/4Pu7vH4rmUIaNZup1JpfPGGqHv1nex?= =?us-ascii?q?3CSWfnmJEMHXpc7Vl2d/DjlFDXCW0bXH21Ra9po2hjUI8=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EPAACKoWldf0anVdFmHAEBAQQBAQc?= =?us-ascii?q?EAQGBUwcBAQsBg1YzKoQhiByGcIIPk3aFJIF7AQgBAQEOLwEBhD8CgmEjNAk?= =?us-ascii?q?OAgMIAQEFAQEBAQEGBAEBAhABAQkLCwgnhUOCOikBgmcBAQEBAxIRVhALCwM?= =?us-ascii?q?GAQMCAh8HAgIiEgEFARwGEyKFC6FogQM8iySBMohvAQgMgUkSeigBi3eCF4N?= =?us-ascii?q?uNT6HT4JYBIEuAQEBjUCHFJYJAQYCgg0UjCuILBuYYi2mIg8hgS+CETMaJX8?= =?us-ascii?q?GZ4FOgnqOLSIwjzgBAQ?= X-IPAS-Result: =?us-ascii?q?A2EPAACKoWldf0anVdFmHAEBAQQBAQcEAQGBUwcBAQsBg?= =?us-ascii?q?1YzKoQhiByGcIIPk3aFJIF7AQgBAQEOLwEBhD8CgmEjNAkOAgMIAQEFAQEBA?= =?us-ascii?q?QEGBAEBAhABAQkLCwgnhUOCOikBgmcBAQEBAxIRVhALCwMGAQMCAh8HAgIiE?= =?us-ascii?q?gEFARwGEyKFC6FogQM8iySBMohvAQgMgUkSeigBi3eCF4NuNT6HT4JYBIEuA?= =?us-ascii?q?QEBjUCHFJYJAQYCgg0UjCuILBuYYi2mIg8hgS+CETMaJX8GZ4FOgnqOLSIwj?= =?us-ascii?q?zgBAQ?= X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="5435366" Received: from mail-lf1-f70.google.com ([209.85.167.70]) by smtp2.ucr.edu with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 15:28:37 -0700 Received: by mail-lf1-f70.google.com with SMTP id q29so1858326lfd.16 for ; Fri, 30 Aug 2019 15:28:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/OqUmnBUo2TwngZckoAVX/16b3P4Ti0vmh5QbNPt/qI=; b=PKIyqoasxyb9Wvpcr0vSCLC1MTTZ6Td9+RqEcFJtOE4gT36rhCALI3WO0H4LHlNKGb 1glalQgbwfgwcLDHP1uFWC3sRDFmn86Hsjxp70TjiAlfWZg3hPRcgoROB1c0IZeDpV40 SDoTHaF9bl3YB2CROO9CowLzH8SGsAWgq5wdN6AAf/djnaqLHx/tdl9XwM/xNiVaxauG 16/IgFXH5w04DOVyZuBnS0NwYv60753qZXmhC6fk9TwTNSgR3ChP1KukJvWAijM1QVTV 0GULF9m0qkjmSY9mRPacV4MWvQE/QhPucK1bWTcmDC020VzwphDU/gVtYiWDbU/wuInh XM3g== X-Gm-Message-State: APjAAAVSIRnH2eiJl29/rPKoMpmUgbcW5GZh9UiX70Z8oMEpvtg4hVMP MrDA5ev0NY6WVTMwIKBk4c7dBpzLqfv9ggARquydrOiOwJeytlO7Om/fU6VnIunn3fzwXykeW3M Hv6XPLHTykuR3oSRsYbcu4EJV8FtEKjHBaLVamlGAUA0+p6MQRVJS X-Received: by 2002:a05:6512:304:: with SMTP id t4mr11134399lfp.15.1567204115688; Fri, 30 Aug 2019 15:28:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwa33Y9Bu9hA8LxhW9Vg/wJim85Pk0no7AsHr9XFg9pLsGspx5AJcu+yjlmeSKNUIJl9tL56jCgdsQd0GJsEII= X-Received: by 2002:a05:6512:304:: with SMTP id t4mr11134392lfp.15.1567204115524; Fri, 30 Aug 2019 15:28:35 -0700 (PDT) MIME-Version: 1.0 References: <20190207174623.16712-1-yzhai003@ucr.edu> <20190208.230117.1867217574108955553.davem@davemloft.net> In-Reply-To: <20190208.230117.1867217574108955553.davem@davemloft.net> From: Yizhuo Zhai Date: Fri, 30 Aug 2019 15:29:07 -0700 Message-ID: Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized To: David Miller X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_152853_328630_54A58298 X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chengyu Song , Alexandre Torgue , netdev@vger.kernel.org, Zhiyun Qian , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Giuseppe Cavallaro , Maxime Ripard , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David: Thanks for your feedback, this patch should work for v4.14. On Fri, Feb 8, 2019 at 11:01 PM David Miller wrote: > > From: Yizhuo > Date: Thu, 7 Feb 2019 09:46:23 -0800 > > > In function sun8i_dwmac_set_syscon(), local variable "val" could > > be uninitialized if function regmap_read() returns -EINVAL. > > However, it will be used directly in the if statement, which > > is potentially unsafe. > > > > Signed-off-by: Yizhuo > > This doesn't apply to any of my trees. -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel