From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE2EC282C2 for ; Thu, 7 Feb 2019 05:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55D212147C for ; Thu, 7 Feb 2019 05:53:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="hopdn+gB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbfBGFxc (ORCPT ); Thu, 7 Feb 2019 00:53:32 -0500 Received: from mx6.ucr.edu ([138.23.62.71]:43392 "EHLO mx6.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbfBGFxb (ORCPT ); Thu, 7 Feb 2019 00:53:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1549518811; x=1581054811; h=mime-version:references:in-reply-to:from:date:message-id: subject:to:cc; bh=VcVhiERyGKHily5ypTgS5H29A4FBtKsk1pDYCwypsi4=; b=hopdn+gB/BnEGqxCSRTeCqHiXfA69E4RLUSliUNWHNpXZ4FzPDErMjXi 9p5hpuQDe2Xbl/EuMH7wqpQr5kxpO+7kZze4xoNQTp4BbY40XSscnX1aT 6O8vGGDfygLUf6qFz9m5B8/QYNOE5YCTQTtaVAiJvH0I76T3Bv08Ww1UJ Tnwgi+F8ddM2c+7NAv+RVCUwsmdWovSEDisjeQ20yUW8LwxfKSGEzk5Cx W9TouVRcn9+9ycIHEkuwuQy9Y1xXn98njocPxUoFGTtR9dPWejGoqAY1E /m5ogqtFLW5vufkcz3WOv5tpkwDRZuhIhp6DJOodB7j1b4cg0sx3UQYes Q==; IronPort-PHdr: =?us-ascii?q?9a23=3AH/aaMRFAA55f38CReIncKJ1GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ78ociwAkXT6L1XgUPTWs2DsrQY07qQ6/iocFdDyK7JiGoFfp1IWk1Nou?= =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?= =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDmwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?= =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?= =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlC?= =?us-ascii?q?YHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6jAf90VWHBBU95eWCxPAIyy?= =?us-ascii?q?b4UBAekcM+hGs4bwvEcOoQekCAWwGO/j1j1Fi3nr1qM6yeQhFgTG0RQiENIPsX?= =?us-ascii?q?XUrMj1NKAPWu+2zKnH1zTDZO5R1Db96YnIcgouofCQUb5sf8fc0lQvGB/fjlmK?= =?us-ascii?q?t4PqIi6V2/0LvmOG7ORgTfqih3A7pwx1uDSixcchhpPUio8UyF3I7yd0zJgzKN?= =?us-ascii?q?alUkB0e8SkH4FVtyyCMot2Rd4tTH9wtSYhz70GpYa7fC8XyJQ73xLfa+KIc4yP?= =?us-ascii?q?4h/7UeaeOzZ4hHZ8dLK7iRa+7FGsyuP+W8WqylpKoS1Fkt7DtnAJyRPf8NSISv?= =?us-ascii?q?x4/ku52DaP0R7c6v1cLEwqiabWL4Qtz70wm5YJrEjOHy37lF/0gaOIbkkk//Kn?= =?us-ascii?q?6+XjYrXovJ+cMIp0hxn+M6UvmsywG+U4PhQSU2WV4um8yaHs/VfjTLpUk/I2j7?= =?us-ascii?q?HVsIrGKsQDuq65HwhV354n6xa+CTemzdsZkWAELF1bYhKHiZbmO1XVLfDmAvew?= =?us-ascii?q?nU6snC1ox//YJL3hBIvCLnzZnLfmZ7Z95B0U9A1m4dlB5p4cL7AFJP/pEhv9vc?= =?us-ascii?q?LVCzc1OhK5xuLgBsk70I4CDzGhGKicZZLTo1+V4aodI+CNLNsEqjb0KqB9vNbz?= =?us-ascii?q?hmV/lFMAK/r6laALYWy1S6w1a36SZmDh15JYST8H?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AfAAC4x1tcgEinVdFkHQEBBQEHBQGBU?= =?us-ascii?q?gcBCwGDOjMnhAOUCIINkwKFD4F7AQyEbAKDGiI1CA0BAwEBAgEBAgETAQEJDQk?= =?us-ascii?q?IJzGCOikBgmYBAQEEIwRSEAsLAwYBAwICHwcCAiISAQUBHAYTCIUeBaB5PIsbf?= =?us-ascii?q?DOIWQEHgUsSeYs4ghaEI4gKglcCgSwBAQGKUIU7kU8BBgIBgWWQYBmBbIkCh2E?= =?us-ascii?q?tm2MPIYEnA4IJMxolfwZngU6CUo4sITCOegEB?= X-IPAS-Result: =?us-ascii?q?A2AfAAC4x1tcgEinVdFkHQEBBQEHBQGBUgcBCwGDOjMnhAO?= =?us-ascii?q?UCIINkwKFD4F7AQyEbAKDGiI1CA0BAwEBAgEBAgETAQEJDQkIJzGCOikBgmYBA?= =?us-ascii?q?QEEIwRSEAsLAwYBAwICHwcCAiISAQUBHAYTCIUeBaB5PIsbfDOIWQEHgUsSeYs?= =?us-ascii?q?4ghaEI4gKglcCgSwBAQGKUIU7kU8BBgIBgWWQYBmBbIkCh2Etm2MPIYEnA4IJM?= =?us-ascii?q?xolfwZngU6CUo4sITCOegEB?= X-IronPort-AV: E=Sophos;i="5.58,342,1544515200"; d="scan'208";a="27151015" Received: from mail-lf1-f72.google.com ([209.85.167.72]) by smtpmx6.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 06 Feb 2019 21:53:29 -0800 Received: by mail-lf1-f72.google.com with SMTP id g16so1330546lfb.22 for ; Wed, 06 Feb 2019 21:53:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OuxZLL8UNbVQzWmaxCNdMvTP4WXTa93NPRnjzawF7/s=; b=rqo7bqK/PviqtaHTXw10qt3enF0V0FTrM55vEUHd6zhiZrrrMTvEOz7Wxdgm9EP8zy Lg0nJ4UGje1NtPlYFf/+Hqn1Xan9Kcgz1ph2x9b6XLM1vEmK1Pl706VvU97MTHoRDKmc 2tN4FBPm61jYKGmC2nIMenVW/0kzToJ4KfpG57wmCAyApujwX3MIIBHOezpU1Yua8E1L WsNnVOjRj2bgV5e6MDbMgfwqjF8X1SzipI5AgGfxXvIclnlaErsVB2PNcRxxAg9n9L7/ oRSQoqqpQPWlh19SVyFBjLLyN13ZYsMvmWKQPfp8brYF95i+/sAZk6QRbEVvgLOz84Ch AUlw== X-Gm-Message-State: AHQUAuYEWeZ/lZ83iMJdb+vp2lY8w6xpoZGQt8ouHOZdsEE7dKyqAXSJ OFETky6csAzHt3u4yfJ8CCbA2MFfYvUidMI4ovrlcUmvvmQN2xY5vlgi7EXJXqYrAOebKCSHmPf KJzm91i66lshKppq48c3+ONhbze7Fiwy/yY8b5F8K2Q== X-Received: by 2002:ac2:5230:: with SMTP id i16mr9363076lfl.54.1549518807246; Wed, 06 Feb 2019 21:53:27 -0800 (PST) X-Google-Smtp-Source: AHgI3IadxvbDND8MVfG27lQv3DRXo1BjCd90b9Zx/Nd0gufYIjmXU1K/Fcm5NdhEj+YyxeekYEbWramdvbOF7CR0gnQ= X-Received: by 2002:ac2:5230:: with SMTP id i16mr9363057lfl.54.1549518806961; Wed, 06 Feb 2019 21:53:26 -0800 (PST) MIME-Version: 1.0 References: <20190205221559.17545-1-yzhai003@ucr.edu> <20190206.201736.1146228626076916564.davem@davemloft.net> In-Reply-To: From: Yizhuo Zhai Date: Wed, 6 Feb 2019 21:53:16 -0800 Message-ID: Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized To: David Miller Cc: Chengyu Song , Zhiyun Qian , Giuseppe Cavallaro , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, but why initialization matters here? Is performance the main concern? On Wed, Feb 6, 2019 at 9:52 PM Yizhuo Zhai wrote: > > Thanks, but why initialization matters here? Is performance the main concern? > > On Wed, Feb 6, 2019 at 8:17 PM David Miller wrote: >> >> From: Yizhuo >> Date: Tue, 5 Feb 2019 14:15:59 -0800 >> >> > @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) >> > struct sunxi_priv_data *gmac = priv->plat->bsp_priv; >> > struct device_node *node = priv->device->of_node; >> > int ret; >> > - u32 reg, val; >> > + u32 reg, val = 0; >> > + >> > + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); >> > + if (ret) { >> > + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); >> > + return ret; >> > + } >> >> I agree with the other reviewer that since you check 'ret' the initialization of >> 'val' is no longer needed. > > > > -- > Kind Regards, > > Yizhuo Zhai > > Computer Science, Graduate Student > University of California, Riverside -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140C0C282C4 for ; Thu, 7 Feb 2019 05:53:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D584A21902 for ; Thu, 7 Feb 2019 05:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F9Rjudy1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="ke9wHLrk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D584A21902 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucr.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jVVE5VmS34fh3qoXnL7og7Nlm4exV738KoLqLk/pgXA=; b=F9Rjudy1QC+2oW 1b3Nj8aw0wLoCqyCoc2rN4DnU7IzMWaKYx4Wd497N19wlIZtekDMytZijZ/t7Ib+rXFskUB1yorG1 qGHCiuDsUhAC6kubUytyOSM9bGbre50qObocy5XpIohJXXvjGMCw5UWoWVBJpL+8UmGLGGyMSaS6x aBFwTZByqMJ4JJWjjhyvEmgQ/csL4eqo5wJf4gLguB+MaIHFyzzHf76+y43Ls2qXsyK2R6+RNsb4I kRj5J+IG+61FLzpPkTIWI9zgZ0Vw4x54MX02MEpJz0FyKAamtlbj9cN50jdZYQDEcSDNr1cqGOZub DV9PzqCLHLU71kzAwfsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grccv-0003NT-Ve; Thu, 07 Feb 2019 05:53:33 +0000 Received: from mx5.ucr.edu ([138.23.62.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grccs-0003N7-H2 for linux-arm-kernel@lists.infradead.org; Thu, 07 Feb 2019 05:53:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1549518810; x=1581054810; h=mime-version:references:in-reply-to:from:date:message-id: subject:to:cc; bh=VcVhiERyGKHily5ypTgS5H29A4FBtKsk1pDYCwypsi4=; b=ke9wHLrkLTtCzbi6WoqGYtfykbuvg2wajTjzJuGR/PiGE1iLh4LN1Dx2 gXqzQZsZOpK4YPOcUynNTWPwfONIwhZXWykUfB3JEuM7CgnkjC/901Fb+ Ed4znq/UHlQCFlVmoywZj0Z5j6fzrkonwhp1o0E7o2hJ/jC3BK5DlLoD2 akSR66luoQgQiIj561kTBf2Y7hzoEahtTVa1CnXYUm1FLOkLQtB8aaj2s ad2lqEi97U8vabvugz+gn6vNVIkOrncOBNzeS1j1Q1avfLpYJqwNpFKMQ MjXRAMGOHy5wMwAmYwYe8SMi6wYJ72M/aWoUc+eqP1BEQKpoMo2fA3j70 g==; IronPort-PHdr: =?us-ascii?q?9a23=3A8VFfYBNLBHQxhGDd4fgl6mtUPXoX/o7sNwtQ0KIM?= =?us-ascii?q?zox0LfT7rarrMEGX3/hxlliBBdydt6oUzbKO+4nbGkU4qa6bt34DdJEeHzQksu?= =?us-ascii?q?4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPERvjKwV1?= =?us-ascii?q?Ov71GonPhMiryuy+4ZLebxlLiTanfb9+MAi9oBnMuMURnYZsMLs6xAHTontPde?= =?us-ascii?q?RWxGdoKkyWkh3h+Mq+/4Nt/jpJtf45+MFOTav1f6IjTbxFFzsmKHw65NfqtRbY?= =?us-ascii?q?UwSC4GYXX3gMnRpJBwjF6wz6Xov0vyDnuOdxxDWWMMvrRr0vRz+s87lkRwPpiC?= =?us-ascii?q?cfNj427mfXitBrjKlGpB6tvgFzz5LIbI2QMvd1Y6HTcs4ARWdZUclRWS5ODIOy?= =?us-ascii?q?YYUMEuQPI/pXopLhp1cStxayGRWgCP/txzJOm3T43bc60+MkEQze3gMgHtMPsH?= =?us-ascii?q?TJrNXyKawdUuC1w7PJzT7eaP5X2Tb86IjSfRAgvf2AQbx9fNHMyUYzDQPJlEuf?= =?us-ascii?q?ppH4Pz6M0OkGrmuV7/J4WO6xl2Iqrxt9rzuvy8s2l4XEh4AYxkrG+Clnxos+OM?= =?us-ascii?q?e2R1RhYdG+FZtdrySaN4xrTcw8W2xooyM6yqEeuZ68YSgK1Iwrxx7BZPyDdIiF?= =?us-ascii?q?+hfjW/yQITd8nX5lfLy/iwur/UiuyODwSNO40FlNripCndnMsm4C2wbP5ciAT/?= =?us-ascii?q?tx5kah2TCR2ADP8uxIP1w4mK7BJ5MiwrM8jIcfvEXBEyPsmkj6kreadkA+9eip?= =?us-ascii?q?7+TnbK/mppiZN4JsigD/M6Qulda+AegkLgQDUXOW+fmg273550H2XqhFjuAunq?= =?us-ascii?q?nDrJ/aPdgbprK+AwJN1oYj6hC/Dyqp0dgBh3YHNldFdAuEj4f3IVHOJu73DfOk?= =?us-ascii?q?jlSokTdr3OzGPqb7DpXMKHjDnq3hcqxg5EFC0gU80MpT55VOCrEOc7rPXRrdvc?= =?us-ascii?q?LZAlccMgiwzvyvXNl0yI4bcW6GHKKcNKTcrRmO6/55cMeWY4pAiTfvK+Uir8zu?= =?us-ascii?q?hH5xzU4PfaCohcNMQG2zBLJrL1jPMimkucsIDWpf5ll2d+ftklDXFGcLP3s=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AfAACMx1tcgEinVdFkHQEBBQEHBQGBU?= =?us-ascii?q?gcBCwGDOjMnhAOUCIINkwKFD4F7AQyEbAKDGiI1CA0BAwEBAgEBAgETAQEJDQk?= =?us-ascii?q?IJzGCOikBgmYBAQEEIwRSEAsLAwYBAwICHwcCAiISAQUBHAYTCIUeBaB5PIsbf?= =?us-ascii?q?DOIWQEHgUsSeYs4ghaEI4gKglcCgSwBAQGKUIU7kU8BBgIBgWWQYBmBbIkCh2E?= =?us-ascii?q?tm2MPIYEnA4IJMxolfwZngU6CUo4sITCOegEB?= X-IPAS-Result: =?us-ascii?q?A2AfAACMx1tcgEinVdFkHQEBBQEHBQGBUgcBCwGDOjMnhAO?= =?us-ascii?q?UCIINkwKFD4F7AQyEbAKDGiI1CA0BAwEBAgEBAgETAQEJDQkIJzGCOikBgmYBA?= =?us-ascii?q?QEEIwRSEAsLAwYBAwICHwcCAiISAQUBHAYTCIUeBaB5PIsbfDOIWQEHgUsSeYs?= =?us-ascii?q?4ghaEI4gKglcCgSwBAQGKUIU7kU8BBgIBgWWQYBmBbIkCh2Etm2MPIYEnA4IJM?= =?us-ascii?q?xolfwZngU6CUo4sITCOegEB?= X-IronPort-AV: E=Sophos;i="5.58,342,1544515200"; d="scan'208";a="27242915" Received: from mail-lf1-f72.google.com ([209.85.167.72]) by smtpmx5.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 06 Feb 2019 21:53:28 -0800 Received: by mail-lf1-f72.google.com with SMTP id m10so1368117lfk.6 for ; Wed, 06 Feb 2019 21:53:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OuxZLL8UNbVQzWmaxCNdMvTP4WXTa93NPRnjzawF7/s=; b=RxwHPoSVLgyphul0ZYptisl7Xd0QWCF+sv/lzo3N9kCSQm2UPR6gRMX2RLZZpbO4Ii Y1HcSfTO6Buf0ViOKR3E0cbKJbQquAj+iKgKDgxtxavCHXfdBQl4Y0BBJwmBJpF0lJYi YDB8C9eCuSbs3TlkuYqJ+4dOs6qVv6oEEqQTFWOyUKl74m+AgPI+RTJzjCLgEFVWGYyA DhjS2fe8NnEFbFGy2q47AHGLz5RcdvGjn7R6nEDleXT7vlWLLxFTzPj02MEMZ1yb5L7+ jOJfea97AbxyZekbEalJDEnr/ss2b8ulYuGdBwf/uPs83wsXAPaDmmX/WgUpnNXAB97t ZIJA== X-Gm-Message-State: AHQUAuY2E4sJxfWbR32V9L3sJW4cXit11GHxRTsR+LihC8r9X0VqwXCp KCtwyPqyBuPy3zEXA6IjOW/WLXSa2SDrVW12pnqfH7vPBiDjbQ6aGuZ6u6aoRF4Nc82Mr9A/p+j KND9evvCP5sQkxEK2gG17MmwOc6hw02dCTyxiM9uk7Lgk4lCRJ3Hv X-Received: by 2002:ac2:5230:: with SMTP id i16mr9363075lfl.54.1549518807246; Wed, 06 Feb 2019 21:53:27 -0800 (PST) X-Google-Smtp-Source: AHgI3IadxvbDND8MVfG27lQv3DRXo1BjCd90b9Zx/Nd0gufYIjmXU1K/Fcm5NdhEj+YyxeekYEbWramdvbOF7CR0gnQ= X-Received: by 2002:ac2:5230:: with SMTP id i16mr9363057lfl.54.1549518806961; Wed, 06 Feb 2019 21:53:26 -0800 (PST) MIME-Version: 1.0 References: <20190205221559.17545-1-yzhai003@ucr.edu> <20190206.201736.1146228626076916564.davem@davemloft.net> In-Reply-To: From: Yizhuo Zhai Date: Wed, 6 Feb 2019 21:53:16 -0800 Message-ID: Subject: Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized To: David Miller X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190206_215330_609060_34C78DCE X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chengyu Song , Alexandre Torgue , netdev@vger.kernel.org, Zhiyun Qian , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Giuseppe Cavallaro , Maxime Ripard , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks, but why initialization matters here? Is performance the main concern? On Wed, Feb 6, 2019 at 9:52 PM Yizhuo Zhai wrote: > > Thanks, but why initialization matters here? Is performance the main concern? > > On Wed, Feb 6, 2019 at 8:17 PM David Miller wrote: >> >> From: Yizhuo >> Date: Tue, 5 Feb 2019 14:15:59 -0800 >> >> > @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) >> > struct sunxi_priv_data *gmac = priv->plat->bsp_priv; >> > struct device_node *node = priv->device->of_node; >> > int ret; >> > - u32 reg, val; >> > + u32 reg, val = 0; >> > + >> > + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); >> > + if (ret) { >> > + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); >> > + return ret; >> > + } >> >> I agree with the other reviewer that since you check 'ret' the initialization of >> 'val' is no longer needed. > > > > -- > Kind Regards, > > Yizhuo Zhai > > Computer Science, Graduate Student > University of California, Riverside -- Kind Regards, Yizhuo Zhai Computer Science, Graduate Student University of California, Riverside _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel