From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Date: Wed, 7 Aug 2013 18:14:22 +0200 Subject: [U-Boot] [PATCH 5/5] ARM: IGEP0033: Remove duplicate / unused #defines. In-Reply-To: <1374737260-4268-6-git-send-email-eballetbo@gmail.com> References: <1374737260-4268-1-git-send-email-eballetbo@gmail.com> <1374737260-4268-6-git-send-email-eballetbo@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Enric, On Thu, Jul 25, 2013 at 9:27 AM, Enric Balletbo i Serra wrote: > From: Enric Balletbo i Serra > > As config was originally based on am335x_evm.h we have also some > duplicate / unnused #defines. > > Commit 15191c91 removed these #defines on various AM335x boards but not > for IGEP COM AQUILA. This patch simply removes them for this board. > Hi Enric, This is why I think we should rename igep0033.h => am335x_igep0033.h or something and do the same for igep00x0.h. Otherwise we miss fixes/cleanups when people search for a pattern (i.e: include/configs/omap3_*). This is totally unrelated to this patch though, I just wanted to point this out to take into account once we do the refactor to make both igep0033.h and igep00x0.h share common code. > Signed-off-by: Enric Balletbo i Serra > --- > include/configs/igep0033.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/include/configs/igep0033.h b/include/configs/igep0033.h > index 3d08cfa..de60f75 100644 > --- a/include/configs/igep0033.h > +++ b/include/configs/igep0033.h > @@ -136,7 +136,6 @@ > /* Boot Argument Buffer Size */ > #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE > #define CONFIG_SYS_LOAD_ADDR 0x81000000 /* Default load address */ > -#define CONFIG_SYS_HZ 1000 /* 1ms clock */ > > /* Physical Memory Map */ > #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */ > @@ -149,7 +148,7 @@ > /* Platform/Board specific defs */ > #define CONFIG_SYS_TIMERBASE 0x48040000 /* Use Timer2 */ > #define CONFIG_SYS_PTV 2 /* Divisor: 2^(PTV+1) => 8 */ > -#define CONFIG_SYS_HZ 1000 > +#define CONFIG_SYS_HZ 1000 /* 1ms clock */ > > /* NS16550 Configuration */ > #define CONFIG_SYS_NS16550 > @@ -158,7 +157,6 @@ > #define CONFIG_SYS_NS16550_CLK (48000000) > #define CONFIG_SYS_NS16550_COM1 0x44e09000 /* UART0 */ > > -#define CONFIG_SERIAL_MULTI > #define CONFIG_CONS_INDEX 1 > #define CONFIG_BAUDRATE 115200 > > @@ -272,10 +270,6 @@ > #define CONFIG_SYS_NAND_ECCSIZE 512 > #define CONFIG_SYS_NAND_ECCBYTES 14 > > -#define CONFIG_SYS_NAND_ECCSTEPS 4 > -#define CONFIG_SYS_NAND_ECCTOTAL (CONFIG_SYS_NAND_ECCBYTES * \ > - CONFIG_SYS_NAND_ECCSTEPS) > - > #define CONFIG_SYS_NAND_U_BOOT_START CONFIG_SYS_TEXT_BASE > > #define CONFIG_SYS_NAND_U_BOOT_OFFS 0x80000 > -- > 1.8.1.2 > Reviewed-by: Javier Martinez Canillas