From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 00/26] OMAPDSS: DT support (Christmas edition) Date: Mon, 9 Dec 2013 13:23:31 +0100 Message-ID: References: <52A29A82.106@collabora.co.uk> <52A2A3EF.1030306@collabora.co.uk> <52A5B111.3010307@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <52A5B111.3010307@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Tomi Valkeinen Cc: Javier Martinez Canillas , "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren , Laurent Pinchart , Stefan Roese , Sebastian Reichel , Robert Nelson , "Dr . H . Nikolaus Schaller" , Marek Belisko List-Id: devicetree@vger.kernel.org On Mon, Dec 9, 2013 at 1:01 PM, Tomi Valkeinen wrote: > On 2013-12-07 06:28, Javier Martinez Canillas wrote: > >> Actually, I looked at drivers/video/omap2/connector-dvi.c and it does the right >> thing for legacy platform data probing but no for DT probing: >> >> static int dvic_probe_pdata(struct platform_device *pdev) >> { >> .. >> adapter = i2c_get_adapter(i2c_bus_num); >> if (!adapter) { >> dev_err(&pdev->dev, >> "Failed to get I2C adapter, bus %d\n", >> i2c_bus_num); >> return -EPROBE_DEFER; >> } >> .. >> } >> >> static int dvic_probe_of(struct platform_device *pdev) >> { >> .. >> adapter = of_find_i2c_adapter_by_node(adapter_node); >> if (adapter == NULL) { >> dev_err(&pdev->dev, "failed to parse i2c-bus\n"); >> omap_dss_put_device(ddata->in); >> return -EINVAL; >> } >> .. >> } >> >> The following patch solves the issue if you want to include in your patch-set: > > Thanks, I'll add this and the omap3-igep0020 support to my DT branch. > Great, thanks a lot for working on this! I'm very happy that we will have proper display support for IGEPv2 on v3.14 without any DT hacks or pdata-quirks :-) > Tomi Best regards, Javier > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Date: Mon, 09 Dec 2013 12:23:31 +0000 Subject: Re: [PATCH 00/26] OMAPDSS: DT support (Christmas edition) Message-Id: List-Id: References: <52A29A82.106@collabora.co.uk> <52A2A3EF.1030306@collabora.co.uk> <52A5B111.3010307@ti.com> In-Reply-To: <52A5B111.3010307@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: Javier Martinez Canillas , "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren , Laurent Pinchart , Stefan Roese , Sebastian Reichel , Robert Nelson , "Dr . H . Nikolaus Schaller" , Marek Belisko On Mon, Dec 9, 2013 at 1:01 PM, Tomi Valkeinen wrote: > On 2013-12-07 06:28, Javier Martinez Canillas wrote: > >> Actually, I looked at drivers/video/omap2/connector-dvi.c and it does the right >> thing for legacy platform data probing but no for DT probing: >> >> static int dvic_probe_pdata(struct platform_device *pdev) >> { >> .. >> adapter = i2c_get_adapter(i2c_bus_num); >> if (!adapter) { >> dev_err(&pdev->dev, >> "Failed to get I2C adapter, bus %d\n", >> i2c_bus_num); >> return -EPROBE_DEFER; >> } >> .. >> } >> >> static int dvic_probe_of(struct platform_device *pdev) >> { >> .. >> adapter = of_find_i2c_adapter_by_node(adapter_node); >> if (adapter = NULL) { >> dev_err(&pdev->dev, "failed to parse i2c-bus\n"); >> omap_dss_put_device(ddata->in); >> return -EINVAL; >> } >> .. >> } >> >> The following patch solves the issue if you want to include in your patch-set: > > Thanks, I'll add this and the omap3-igep0020 support to my DT branch. > Great, thanks a lot for working on this! I'm very happy that we will have proper display support for IGEPv2 on v3.14 without any DT hacks or pdata-quirks :-) > Tomi Best regards, Javier > >