From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 18/26] ARM: omap3-beagle.dts: add display information Date: Fri, 6 Dec 2013 09:41:17 +0100 Message-ID: References: <1386160133-24026-1-git-send-email-tomi.valkeinen@ti.com> <1386160133-24026-19-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1386160133-24026-19-git-send-email-tomi.valkeinen@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Tomi Valkeinen Cc: "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren List-Id: devicetree@vger.kernel.org Hi Tomi, On Wed, Dec 4, 2013 at 1:28 PM, Tomi Valkeinen wrote: > Signed-off-by: Tomi Valkeinen > --- > arch/arm/boot/dts/omap3-beagle.dts | 67 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts > index fa532aaacc68..1ca1932d02aa 100644 > --- a/arch/arm/boot/dts/omap3-beagle.dts > +++ b/arch/arm/boot/dts/omap3-beagle.dts > @@ -178,3 +178,70 @@ > mode = <3>; > power = <50>; > }; > + > +&dpi { > + vdds_dsi-supply = <&vpll2>; > + > + dpi_out: endpoint { > + remote-endpoint = <&tfp410_in>; > + data-lines = <24>; > + }; > +}; > + > +&venc { > + vdda_dac-supply = <&vdac>; > + > + venc_out: endpoint { > + remote-endpoint = <&tv_connector_in>; > + }; > +}; > + > +/ { > + aliases { > + display0 = &dvi0; > + display1 = &tv0; > + }; > + > + tfp410: encoder@0 { > + compatible = "ti,tfp410"; > + gpios = <&gpio5 10 0>; /* 170, power-down */ > + Shouldn't this be gpio6 instead since OMAP GPIO banks start counting from 1 so gpio5 + 10 is GPIO 138. > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tfp410_in: endpoint@0 { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + tfp410_out: endpoint@1 { > + remote-endpoint = <&dvi_connector_in>; > + }; > + }; > + }; > + }; > + > + dvi0: connector@0 { > + compatible = "ti,dvi_connector"; > + i2c-bus = <&i2c3>; > + > + dvi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + > + tv0: connector@1 { > + compatible = "ti,svideo_connector"; > + > + tv_connector_in: endpoint { > + remote-endpoint = <&venc_out>; > + }; > + }; > +}; > -- > 1.8.3.2 > Also I don't see the DSS pinmux set for this board. I guess you need something like the following on top: 0x0a4 (PIN_OUTPUT | MUX_MODE0) /* dss_pclk.dss_pclk */ 0x0a6 (PIN_OUTPUT | MUX_MODE0) /* dss_hsync.dss_hsync */ 0x0a8 (PIN_OUTPUT | MUX_MODE0) /* dss_vsync.dss_vsync */ 0x0aa (PIN_OUTPUT | MUX_MODE0) /* dss_acbias.dss_acbias */ 0x0ac (PIN_OUTPUT | MUX_MODE0) /* dss_data0.dss_data0 */ 0x0ae (PIN_OUTPUT | MUX_MODE0) /* dss_data1.dss_data1 */ 0x0b0 (PIN_OUTPUT | MUX_MODE0) /* dss_data2.dss_data2 */ 0x0b2 (PIN_OUTPUT | MUX_MODE0) /* dss_data3.dss_data3 */ 0x0b4 (PIN_OUTPUT | MUX_MODE0) /* dss_data4.dss_data4 */ 0x0b6 (PIN_OUTPUT | MUX_MODE0) /* dss_data5.dss_data5 */ 0x0b8 (PIN_OUTPUT | MUX_MODE0) /* dss_data6.dss_data6 */ 0x0ba (PIN_OUTPUT | MUX_MODE0) /* dss_data7.dss_data7 */ 0x0bc (PIN_OUTPUT | MUX_MODE0) /* dss_data8.dss_data8 */ 0x0be (PIN_OUTPUT | MUX_MODE0) /* dss_data9.dss_data9 */ 0x0c0 (PIN_OUTPUT | MUX_MODE0) /* dss_data10.dss_data10 */ 0x0c2 (PIN_OUTPUT | MUX_MODE0) /* dss_data11.dss_data11 */ 0x0c4 (PIN_OUTPUT | MUX_MODE0) /* dss_data12.dss_data12 */ 0x0c6 (PIN_OUTPUT | MUX_MODE0) /* dss_data13.dss_data13 */ 0x0c8 (PIN_OUTPUT | MUX_MODE0) /* dss_data14.dss_data14 */ 0x0ca (PIN_OUTPUT | MUX_MODE0) /* dss_data15.dss_data15 */ 0x0cc (PIN_OUTPUT | MUX_MODE0) /* dss_data16.dss_data16 */ 0x0ce (PIN_OUTPUT | MUX_MODE0) /* dss_data17.dss_data17 */ 0x0d0 (PIN_OUTPUT | MUX_MODE0) /* dss_data18.dss_data18 */ 0x0d2 (PIN_OUTPUT | MUX_MODE0) /* dss_data19.dss_data19 */ 0x0d4 (PIN_OUTPUT | MUX_MODE0) /* dss_data20.dss_data20 */ 0x0d6 (PIN_OUTPUT | MUX_MODE0) /* dss_data21.dss_data21 */ 0x0d8 (PIN_OUTPUT | MUX_MODE0) /* dss_data22.dss_data22 */ 0x0da (PIN_OUTPUT | MUX_MODE0) /* dss_data23.dss_data23 */ Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Date: Fri, 06 Dec 2013 08:41:17 +0000 Subject: Re: [PATCH 18/26] ARM: omap3-beagle.dts: add display information Message-Id: List-Id: References: <1386160133-24026-1-git-send-email-tomi.valkeinen@ti.com> <1386160133-24026-19-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: <1386160133-24026-19-git-send-email-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: "linux-omap@vger.kernel.org" , linux-fbdev@vger.kernel.org, "devicetree@vger.kernel.org" , Archit Taneja , Darren Etheridge , Tony Lindgren Hi Tomi, On Wed, Dec 4, 2013 at 1:28 PM, Tomi Valkeinen wrote: > Signed-off-by: Tomi Valkeinen > --- > arch/arm/boot/dts/omap3-beagle.dts | 67 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts > index fa532aaacc68..1ca1932d02aa 100644 > --- a/arch/arm/boot/dts/omap3-beagle.dts > +++ b/arch/arm/boot/dts/omap3-beagle.dts > @@ -178,3 +178,70 @@ > mode = <3>; > power = <50>; > }; > + > +&dpi { > + vdds_dsi-supply = <&vpll2>; > + > + dpi_out: endpoint { > + remote-endpoint = <&tfp410_in>; > + data-lines = <24>; > + }; > +}; > + > +&venc { > + vdda_dac-supply = <&vdac>; > + > + venc_out: endpoint { > + remote-endpoint = <&tv_connector_in>; > + }; > +}; > + > +/ { > + aliases { > + display0 = &dvi0; > + display1 = &tv0; > + }; > + > + tfp410: encoder@0 { > + compatible = "ti,tfp410"; > + gpios = <&gpio5 10 0>; /* 170, power-down */ > + Shouldn't this be gpio6 instead since OMAP GPIO banks start counting from 1 so gpio5 + 10 is GPIO 138. > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tfp410_in: endpoint@0 { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + tfp410_out: endpoint@1 { > + remote-endpoint = <&dvi_connector_in>; > + }; > + }; > + }; > + }; > + > + dvi0: connector@0 { > + compatible = "ti,dvi_connector"; > + i2c-bus = <&i2c3>; > + > + dvi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + > + tv0: connector@1 { > + compatible = "ti,svideo_connector"; > + > + tv_connector_in: endpoint { > + remote-endpoint = <&venc_out>; > + }; > + }; > +}; > -- > 1.8.3.2 > Also I don't see the DSS pinmux set for this board. I guess you need something like the following on top: 0x0a4 (PIN_OUTPUT | MUX_MODE0) /* dss_pclk.dss_pclk */ 0x0a6 (PIN_OUTPUT | MUX_MODE0) /* dss_hsync.dss_hsync */ 0x0a8 (PIN_OUTPUT | MUX_MODE0) /* dss_vsync.dss_vsync */ 0x0aa (PIN_OUTPUT | MUX_MODE0) /* dss_acbias.dss_acbias */ 0x0ac (PIN_OUTPUT | MUX_MODE0) /* dss_data0.dss_data0 */ 0x0ae (PIN_OUTPUT | MUX_MODE0) /* dss_data1.dss_data1 */ 0x0b0 (PIN_OUTPUT | MUX_MODE0) /* dss_data2.dss_data2 */ 0x0b2 (PIN_OUTPUT | MUX_MODE0) /* dss_data3.dss_data3 */ 0x0b4 (PIN_OUTPUT | MUX_MODE0) /* dss_data4.dss_data4 */ 0x0b6 (PIN_OUTPUT | MUX_MODE0) /* dss_data5.dss_data5 */ 0x0b8 (PIN_OUTPUT | MUX_MODE0) /* dss_data6.dss_data6 */ 0x0ba (PIN_OUTPUT | MUX_MODE0) /* dss_data7.dss_data7 */ 0x0bc (PIN_OUTPUT | MUX_MODE0) /* dss_data8.dss_data8 */ 0x0be (PIN_OUTPUT | MUX_MODE0) /* dss_data9.dss_data9 */ 0x0c0 (PIN_OUTPUT | MUX_MODE0) /* dss_data10.dss_data10 */ 0x0c2 (PIN_OUTPUT | MUX_MODE0) /* dss_data11.dss_data11 */ 0x0c4 (PIN_OUTPUT | MUX_MODE0) /* dss_data12.dss_data12 */ 0x0c6 (PIN_OUTPUT | MUX_MODE0) /* dss_data13.dss_data13 */ 0x0c8 (PIN_OUTPUT | MUX_MODE0) /* dss_data14.dss_data14 */ 0x0ca (PIN_OUTPUT | MUX_MODE0) /* dss_data15.dss_data15 */ 0x0cc (PIN_OUTPUT | MUX_MODE0) /* dss_data16.dss_data16 */ 0x0ce (PIN_OUTPUT | MUX_MODE0) /* dss_data17.dss_data17 */ 0x0d0 (PIN_OUTPUT | MUX_MODE0) /* dss_data18.dss_data18 */ 0x0d2 (PIN_OUTPUT | MUX_MODE0) /* dss_data19.dss_data19 */ 0x0d4 (PIN_OUTPUT | MUX_MODE0) /* dss_data20.dss_data20 */ 0x0d6 (PIN_OUTPUT | MUX_MODE0) /* dss_data21.dss_data21 */ 0x0d8 (PIN_OUTPUT | MUX_MODE0) /* dss_data22.dss_data22 */ 0x0da (PIN_OUTPUT | MUX_MODE0) /* dss_data23.dss_data23 */ Best regards, Javier