From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750843AbdAXMoQ (ORCPT ); Tue, 24 Jan 2017 07:44:16 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:35422 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdAXMoO (ORCPT ); Tue, 24 Jan 2017 07:44:14 -0500 MIME-Version: 1.0 X-Originating-IP: [181.121.136.80] In-Reply-To: <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> From: Javier Martinez Canillas Date: Tue, 24 Jan 2017 09:44:12 -0300 Message-ID: Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver To: Steve Longerbeam Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick@shmanahar.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, Jean-Christophe Trotin , horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , Steve Longerbeam , Sascha Hauer , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can be build as a module... > + > +static const struct of_device_id vidsw_dt_ids[] = { > + { .compatible = "video-multiplexer", }, > + { /* sentinel */ } > +}; > + ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or otherwise module autoloading won't work. Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver Date: Tue, 24 Jan 2017 09:44:12 -0300 Message-ID: References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Sender: linux-media-owner@vger.kernel.org To: Steve Longerbeam Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick@shmanahar.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, Jean-Christophe Trotin , horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatec List-Id: devicetree@vger.kernel.org Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can be build as a module... > + > +static const struct of_device_id vidsw_dt_ids[] = { > + { .compatible = "video-multiplexer", }, > + { /* sentinel */ } > +}; > + ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or otherwise module autoloading won't work. Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-it0-f67.google.com ([209.85.214.67]:33219 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdAXMoO (ORCPT ); Tue, 24 Jan 2017 07:44:14 -0500 Received: by mail-it0-f67.google.com with SMTP id e137so13704322itc.0 for ; Tue, 24 Jan 2017 04:44:13 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> From: Javier Martinez Canillas Date: Tue, 24 Jan 2017 09:44:12 -0300 Message-ID: Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver To: Steve Longerbeam Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick@shmanahar.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, Jean-Christophe Trotin , horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , Steve Longerbeam , Sascha Hauer , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-media-owner@vger.kernel.org List-ID: Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can be build as a module... > + > +static const struct of_device_id vidsw_dt_ids[] = { > + { .compatible = "video-multiplexer", }, > + { /* sentinel */ } > +}; > + ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or otherwise module autoloading won't work. Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@dowhile0.org (Javier Martinez Canillas) Date: Tue, 24 Jan 2017 09:44:12 -0300 Subject: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver In-Reply-To: <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: > From: Philipp Zabel [snip] > > +config VIDEO_MULTIPLEXER > + tristate "Video Multiplexer" > + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver can be build as a module... > + > +static const struct of_device_id vidsw_dt_ids[] = { > + { .compatible = "video-multiplexer", }, > + { /* sentinel */ } > +}; > + ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or otherwise module autoloading won't work. Best regards, Javier