All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@dowhile0.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	arm@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>,
	Kevin Hilman <khilman@linaro.org>,
	Doug Anderson <dianders@chromium.org>,
	Kukjin Kim <kgene@kernel.org>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks
Date: Fri, 15 May 2015 02:33:55 +0200	[thread overview]
Message-ID: <CABxcv=nDb2_vYfR4N0PeK269h=1NbGbL-R-tdAqrtOhujive8g@mail.gmail.com> (raw)
In-Reply-To: <CAJKOXPeDV=0agQdJ2G7x3ok4wnX66nZ_SF=cGQOW8N96=GnDJA@mail.gmail.com>

Hello Krzysztof,

On Fri, May 15, 2015 at 2:18 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> 2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas
> <javier.martinez@collabora.co.uk>:
>> Hello arm-soc maintainers,
>>
>> This series is an attempt to reduce the delta between exynos_defconfig
>> and multi_v7_defconfig. Primarily to enable the needed Kconfig symbols
>> to make all Exynos Chromebooks peripherals to be working when building
>> an image using the ARMv7 multi-platform default config.
>>
>> Since the policy is now to now enable as much as possible, I did build
>> as a module all the Kconfig symbols that were tristate and only enable
>> as built-in those that can't be a module because are boolean options.
>>
>> A nice side effect of this series is that I found that many drivers
>> were not working properly when built as a module because the modalias
>> information was not filled properly or at all. I've posted patches to
>> fix the issues I found when testing this series.
>>
>> The patches have been tested on an Exynos5250 Snow, Exynos5420 Peach
>> Pit and Exynos5800 Peach Pi Chromebooks but most config options will
>> be useful for others Exynos5 or other Samsung SoCs.
>
> I think enabling these config options would help using the multi_v7 on
> Exynos boards. I have doubts only for patch 7 (DRM), so for rest of
> them:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>

Thanks a lot for your review. Do you think that there is something
wrong with patch 7 (DRM) or your doubt is given that the Exynos DRM
driver has been so unstable in the past, enabling could cause more
harm than good?

IMHO enabling the Exynos DRM options in exynos_defconfig was worth the
trouble since a lot of bugs were exposed (and fixed!) while before we
had unnoticed broken code laying around.

> Best regards,
> Krzysztof
> --

Best regards,
Javier

  reply	other threads:[~2015-05-15  0:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 15:40 [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 1/9] ARM: multi_v7_defconfig: Enable support for Samsung S3C64XX SPI Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers Javier Martinez Canillas
2015-07-15 15:38   ` Javier Martinez Canillas
2015-07-15 15:38     ` Javier Martinez Canillas
2015-07-16  0:42     ` Krzysztof Kozlowski
2015-07-16  0:42       ` Krzysztof Kozlowski
2015-07-16  5:30       ` Javier Martinez Canillas
2015-07-16  5:30         ` Javier Martinez Canillas
2015-07-17 16:49       ` Olof Johansson
2015-07-17 16:49         ` Olof Johansson
2015-07-17 18:47         ` Javier Martinez Canillas
2015-07-17 18:47           ` Javier Martinez Canillas
2015-07-17 18:49           ` Olof Johansson
2015-07-17 18:49             ` Olof Johansson
2015-07-25  2:01             ` Kukjin Kim
2015-05-14 15:40 ` [PATCH 3/9] ARM: multi_v7_defconfig: Enable Exynos USB PHY drivers support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 4/9] ARM: multi_v7_defconfig: Enable support for missing ChromeOS EC drivers Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 5/9] ARM: multi_v7_defconfig: Enable Samsung PWM support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 6/9] ARM: multi_v7_defconfig: Enable Samsung S3C SoC RTC Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support Javier Martinez Canillas
2015-05-15  0:36   ` Krzysztof Kozlowski
2015-05-15  0:58     ` Javier Martinez Canillas
2015-05-15  0:58       ` Javier Martinez Canillas
2015-05-15  1:08       ` Krzysztof Kozlowski
2015-05-15  1:08         ` Krzysztof Kozlowski
2015-05-14 15:40 ` [PATCH 8/9] ARM: multi_v7_defconfig: Enable GPIO-based I2C arbitration support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 9/9] ARM: multi_v7_defconfig: Enable Cypress APA I2C Trackpad support Javier Martinez Canillas
2015-05-15  0:18 ` [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Krzysztof Kozlowski
2015-05-15  0:33   ` Javier Martinez Canillas [this message]
2015-05-15  0:33     ` Javier Martinez Canillas
2015-05-15 11:37 ` Arnd Bergmann
2015-05-15 12:00   ` Krzysztof Kozlowski
2015-05-16  3:25     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABxcv=nDb2_vYfR4N0PeK269h=1NbGbL-R-tdAqrtOhujive8g@mail.gmail.com' \
    --to=javier@dowhile0.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.