From mboxrd@z Thu Jan 1 00:00:00 1970 From: Parth Dixit Subject: Re: [PATCH v2 20/41] arm : create generic uart initialization function Date: Sun, 5 Jul 2015 18:44:31 +0530 Message-ID: References: <1431893048-5214-1-git-send-email-parth.dixit@linaro.org> <1431893048-5214-21-git-send-email-parth.dixit@linaro.org> <555DC154.5020300@citrix.com> <55618246.4050006@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55618246.4050006@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: keir@xen.org, Ian Campbell , andrew.cooper3@citrix.com, tim@xen.org, xen-devel , Stefano Stabellini , shannon.zhao@linaro.org, Jan Beulich , Christoffer Dall List-Id: xen-devel@lists.xenproject.org +shannon On 24 May 2015 at 13:18, Julien Grall wrote: > > On 24/05/2015 08:07, Parth Dixit wrote: >> >> >> >> On 21 May 2015 at 16:58, Julien Grall > > wrote: >> >> Hi Parth, >> >> On 17/05/15 21:03, Parth Dixit wrote: >> > Rename dt-uart.c to arm-uart.c and create new generic uart init >> function. >> > move dt_uart_init to uart_init.Refactor pl011 driver to dt and >> common >> > initialization parts. This will be useful later when acpi specific >> > uart initialization function is introduced. >> >> There is 2 distinct changes in this patch: >> - Introduction of the generic UART >> - Refactoring of PL011 >> >> Each changes should be in a separate patch for helping the review. >> >> ok, will move into seperate patches. > > > Thank you. It would make sense to gather all the re-factoring patches in the > beginning of the series. So we could push them without waiting the rest of > the series. > > BTW, it seems that your mail client is using tabulation for quoting which is > difficult to read after a couple of back and forth. Can you try to configure > it correctly to use ">"? Maybe it's because of HTML mail? > > Regards, > > -- > Julien Grall