From mboxrd@z Thu Jan  1 00:00:00 1970
From: Parth Dixit <parth.dixit@linaro.org>
Subject: Re: [PATCH v2 17/41] arm : refactor gic into generic
 and dt specific parts
Date: Sun, 5 Jul 2015 18:42:08 +0530
Message-ID: <CABy3MNmDvTYJpozkPm3cd2WgL7pLi=M2g3udqNiQJfHFoLr1Vg@mail.gmail.com>
References: <1431893048-5214-1-git-send-email-parth.dixit@linaro.org>
	<1431893048-5214-18-git-send-email-parth.dixit@linaro.org>
	<555DCDF8.7020104@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555DCDF8.7020104@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, andrew.cooper3@citrix.com, tim@xen.org, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, shannon.zhao@linaro.org, Jan Beulich <jbeulich@suse.com>, Christoffer Dall <christoffer.dall@linaro.org>
List-Id: xen-devel@lists.xenproject.org

+shannon

On 21 May 2015 at 17:52, Julien Grall <julien.grall@citrix.com> wrote:
> On 17/05/15 21:03, Parth Dixit wrote:
>> refactor gic related functions into dt and generic parts
>> this will be helpful when adding acpi support for gic
>>
>> Signed-off-by: Parth Dixit <parth.dixit@linaro.org>
>> ---
>>  xen/arch/arm/gic-v2.c | 13 ++++++++++---
>>  xen/arch/arm/gic.c    |  7 ++++++-
>>  2 files changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
>> index 80acc62..7276951 100644
>> --- a/xen/arch/arm/gic-v2.c
>> +++ b/xen/arch/arm/gic-v2.c
>> @@ -663,7 +663,7 @@ static hw_irq_controller gicv2_guest_irq_type = {
>>      .set_affinity = gicv2_irq_set_affinity,
>>  };
>>
>> -static int __init gicv2_init(void)
>> +static int __init dt_gicv2_init(void)
>>  {
>>      int res;
>>      const struct dt_device_node *node = gicv2_info.node;
>> @@ -689,6 +689,13 @@ static int __init gicv2_init(void)
>>          panic("GICv2: Cannot find the maintenance IRQ");
>>      gicv2_info.maintenance_irq = res;
>>
>> +    return 0;
>> +}
>> +
>> +static int gicv2_init(void)
>> +{
>> +     dt_gicv2_init();
>> +
>
> I forgot it on the first review. dt_gicv2_init is returning an error
> code. You should not ignore it.
>
> If it's not useful (because everything paniced), then the function
> should return void.
>
> Regards,
>
> --
> Julien Grall