From mboxrd@z Thu Jan  1 00:00:00 1970
From: Parth Dixit <parth.dixit@linaro.org>
Subject: Re: [PATCH v2 02/41] arm/acpi: Build pmstat for x86 only
Date: Sun, 24 May 2015 11:40:47 +0530
Message-ID: <CABy3MNnOFYXNeV_-mMA0s1uAF4GszAC2oD4ObHqTRtVncUxTgw@mail.gmail.com>
References: <1431893048-5214-1-git-send-email-parth.dixit@linaro.org>
	<1431893048-5214-3-git-send-email-parth.dixit@linaro.org>
	<555CC06F020000780007C4DD@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3876116058653391637=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555CC06F020000780007C4DD@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, andrew.cooper3@citrix.com, tim@xen.org, xen-devel <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Christoffer Dall <christoffer.dall@linaro.org>
List-Id: xen-devel@lists.xenproject.org

--===============3876116058653391637==
Content-Type: multipart/alternative; boundary=001a11c12f002421ee0516cdc120

--001a11c12f002421ee0516cdc120
Content-Type: text/plain; charset=UTF-8

On 20 May 2015 at 20:42, Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 17.05.15 at 22:03, <parth.dixit@linaro.org> wrote:
> > Pmstat is currently not supported for arm in xen.
> > Configure and build pmstat for x86 architecture only.
>
> Same here as for patch 1. If the architecture can be expected to
> eventually support a feature, I'd generally prefer the architecture
> to get necessary stubs added over fiddling with common code.
>
> ok, will add stubs in next patchset.

> > --- a/xen/common/sysctl.c
> > +++ b/xen/common/sysctl.c
> > @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t)
> u_sysctl)
> >          op->u.availheap.avail_bytes <<= PAGE_SHIFT;
> >          break;
> >
> > +#ifdef CONFIG_X86
> >  #ifdef HAS_ACPI
> >      case XEN_SYSCTL_get_pmstat:
> >          ret = do_get_pm_info(&op->u.get_pmstat);
>
> Please fold the two #if-s into one, or even replace the HAS_ACPI
> one if this really needs to be done.
>
> Jan
>
>

--001a11c12f002421ee0516cdc120
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On 20 May 2015 at 20:42, Jan Beulich <span dir=3D"ltr">&lt;<a href=3D"m=
ailto:JBeulich@suse.com" target=3D"_blank">JBeulich@suse.com</a>&gt;</span>=
 wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex"><span class=3D"">&gt;&gt;&gt; On =
17.05.15 at 22:03, &lt;<a href=3D"mailto:parth.dixit@linaro.org">parth.dixi=
t@linaro.org</a>&gt; wrote:<br>
&gt; Pmstat is currently not supported for arm in xen.<br>
&gt; Configure and build pmstat for x86 architecture only.<br>
<br>
</span>Same here as for patch 1. If the architecture can be expected to<br>
eventually support a feature, I&#39;d generally prefer the architecture<br>
to get necessary stubs added over fiddling with common code.<br>
<span class=3D""><br></span></blockquote><div>ok, will add stubs in next pa=
tchset. <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">
&gt; --- a/xen/common/sysctl.c<br>
&gt; +++ b/xen/common/sysctl.c<br>
&gt; @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t=
) u_sysctl)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 op-&gt;u.availheap.avail_bytes &lt;&=
lt;=3D PAGE_SHIFT;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;<br>
&gt;<br>
&gt; +#ifdef CONFIG_X86<br>
&gt;=C2=A0 #ifdef HAS_ACPI<br>
&gt;=C2=A0 =C2=A0 =C2=A0 case XEN_SYSCTL_get_pmstat:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ret =3D do_get_pm_info(&amp;op-&gt;u=
.get_pmstat);<br>
<br>
</span>Please fold the two #if-s into one, or even replace the HAS_ACPI<br>
one if this really needs to be done.<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
Jan<br>
<br>
</font></span></blockquote></div><br></div></div>

--001a11c12f002421ee0516cdc120--


--===============3876116058653391637==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3876116058653391637==--