From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Opaniuk <igor.opaniuk@toradex.com>
Date: Thu, 28 Mar 2019 16:58:54 +0000
Subject: [U-Boot] [PATCH v2 09/22] configs: colibri_vf: disable obscure
 options
In-Reply-To: <20190325162512.8702-10-marcel@ziswiler.com>
References: <20190325162512.8702-1-marcel@ziswiler.com>
 <20190325162512.8702-10-marcel@ziswiler.com>
Message-ID: <CAByghJYXteT=yXDmRvs35VJnoVGwpPrQa7cptV2ER4ftcL+x-g@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marcel,

The actual line which does have impact is `CONFIG_DFU_MMC=y`.

Not sure I understand the reason of adding "# ... is not set" lines in
this defconfig. Could you please explain?

Regards,
Igor

On Mon, Mar 25, 2019 at 6:30 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Disable more obscure options to save another 26 KB in preparation of
> the upcoming driver model migration.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Changes in v2: None
>
>  configs/colibri_vf_defconfig | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig
> index 8188582ed9..706d7ca634 100644
> --- a/configs/colibri_vf_defconfig
> +++ b/configs/colibri_vf_defconfig
> @@ -17,11 +17,17 @@ CONFIG_BOARD_EARLY_INIT_F=y
>  CONFIG_HUSH_PARSER=y
>  # CONFIG_CMDLINE_EDITING is not set
>  # CONFIG_AUTO_COMPLETE is not set
> +# CONFIG_SYS_LONGHELP is not set
>  CONFIG_SYS_PROMPT="Colibri VFxx # "
> +# CONFIG_CMD_BOOTD is not set
> +# CONFIG_CMD_BOOTM is not set
>  CONFIG_CMD_BOOTZ=y
> +# CONFIG_CMD_ELF is not set
> +# CONFIG_CMD_IMI is not set
>  CONFIG_CMD_ASKENV=y
>  CONFIG_CMD_MEMTEST=y
>  CONFIG_CMD_DFU=y
> +# CONFIG_CMD_FLASH is not set
>  CONFIG_CMD_FUSE=y
>  CONFIG_CMD_GPIO=y
>  # CONFIG_CMD_LOADB is not set
> @@ -46,10 +52,10 @@ CONFIG_DEFAULT_DEVICE_TREE="vf610-colibri"
>  CONFIG_ENV_IS_IN_NAND=y
>  CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>  CONFIG_DM=y
> -CONFIG_DFU_MMC=y
>  CONFIG_DFU_NAND=y
>  CONFIG_DM_GPIO=y
>  CONFIG_VYBRID_GPIO=y
> +# CONFIG_MMC_HW_PARTITIONING is not set
>  CONFIG_FSL_ESDHC=y
>  CONFIG_NAND_VF610_NFC=y
>  CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
> @@ -57,6 +63,8 @@ CONFIG_MTD_UBI_FASTMAP=y
>  CONFIG_PHYLIB=y
>  CONFIG_PHY_MICREL=y
>  CONFIG_MII=y
> +# CONFIG_SPL_SERIAL_PRESENT is not set
> +# CONFIG_TPL_SERIAL_PRESENT is not set
>  CONFIG_DM_SERIAL=y
>  CONFIG_FSL_LPUART=y
>  CONFIG_USB=y
> --
> 2.20.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot