From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Opaniuk Date: Thu, 28 Mar 2019 14:38:40 +0000 Subject: [U-Boot] [RESEND RFC PATCH v1] MLK-12883 usb: limit USB_MAX_XFER_BLK to 256 In-Reply-To: <20190325161944.8044-1-marcel@ziswiler.com> References: <20190325161944.8044-1-marcel@ziswiler.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de There is a typo in the comment: USB Massstorage Also regarding refering to a specific commit ("(cherry picked from commit df0052575b2bc9d66ae73584768e1a457ed5d914)" line): > If you want to refer to a specific commit, don=E2=80=99t just refer to th= e SHA-1 ID of the commit. > Please also include the oneline summary of the commit, to make it easier = for reviewers to know what it is about. Example: > Commit e21d2170f36602ae2708 ("video: remove unnecessary platform_set_drvd= ata()") [1]: https://www.kernel.org/doc/html/v5.1-rc2/process/submitting-patches.ht= ml On Mon, Mar 25, 2019 at 6:20 PM Marcel Ziswiler wrote: > > From: Peng Fan > > For Some USB mass storage devices, such as: > " > - Kingston DataTraveler 2.0 001D7D06CF09B04199C7B3EA > - Class: (from Interface) Mass Storage > - PacketSize: 64 Configurations: 1 > - Vendor: 0x0930 Product 0x6545 Version 1.16 > " > When `usb read 0x80000000 0 0x2000`, we met > "EHCI timed out on TD - token=3D0x80008d80". > > The devices does not support scsi VPD page, we are not able > to get the maximum transfer length for READ(10)/WRITE(10). > > So we limit this to 256 blocks as READ(6). > > Signed-off-by: Peng Fan > Acked-by: Marcel Ziswiler > (cherry picked from commit df0052575b2bc9d66ae73584768e1a457ed5d914) > > --- > This comes from NXP's downstream and has proven to tremendously improve > the situation with those odd USB mass storage aka memory sticks. This is > why I post it here asking whether or not this may be something > benefiting more people. Any feedback and suggestions are welcome. > > common/usb_storage.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/common/usb_storage.c b/common/usb_storage.c > index 8c889bb1a6..7420438363 100644 > --- a/common/usb_storage.c > +++ b/common/usb_storage.c > @@ -949,7 +949,11 @@ static void usb_stor_set_max_xfer_blk(struct usb_dev= ice *udev, > * there is enough free heap space left, but the SCSI READ(10) and > * WRITE(10) commands are limited to 65535 blocks. > */ > - blk =3D USHRT_MAX; > + /* > + * Some USB Massstorage devices have issues, limiting this to 256 > + * fixes this. > + */ > + blk =3D 256; > #else > blk =3D 20; > #endif > -- > 2.20.1 > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot