All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun Nie <jun.nie@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: abel.vesa@linaro.org, bjorn.andersson@linaro.org,
	mturquette@baylibre.com, sboyd@kernel.org, agross@kernel.org,
	shawn.guo@linaro.org, bryan.odonoghue@linaro.org,
	linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] Support dynamic voltage frequency scaling inside clock controller
Date: Sat, 6 Aug 2022 12:43:44 +0800	[thread overview]
Message-ID: <CABymUCMJ0CL+aog-8PDvUiAb4ivhZRxidvUUKu6vO1453mN3qA@mail.gmail.com> (raw)
In-Reply-To: <YuzimmCqk2pA5sFZ@gerhold.net>

Stephan Gerhold <stephan@gerhold.net> 于2022年8月5日周五 17:32写道:
>
> On Fri, Aug 05, 2022 at 03:49:31PM +0800, Jun Nie wrote:
> > Support dynamic voltage frequency scaling inside clock controller with
> > changes in clock framework. And added msm8916 as the first SoC to
> > support this feature.
> >
>
> As far as I understand it was decided to handle this on the consumer
> driver side in mainline, together with OPP tables and "required-opps" in
> the device tree. If you look at e.g. sc7180.dtsi you can see that this
> is heavily used there. Also see e.g. [1] for some links to related
> discussions.
>
> For MSM8916 at least the SDHCI and DSI driver should support this
> already. Some other older drivers (e.g. QUP, USB) would need some change
> similar to [2] (just like they still need changes for interconnects).
>
> I'm not entirely sure why it was decided to not do this as part of the
> clock core (maybe someone can explain or link a relevant mailing list
> post?), but we should try to keep it consistent in any case. :)
>
> Thanks,
> Stephan

Hi Stephan,
Thanks for the reminder! My work in clk framework was done 2 years ago actually.
I guess it is just before the decision to use consumer side opps for
this, because
I did not see any solution at the time.

I think the consumer side required-opps is better than my solution.
Because clock
is infrastructure to initialize other devices in most cases. If clock
device depends
on power domains, we have to initialize the power domain first. So adjustment in
initialization sequence of many devices is needed sometimes. The consumer side
operation avoid such inconvenience.

So let's forget this patch set.

Regards,
Jun

>
> [1]: https://lore.kernel.org/linux-arm-msm/20200910162610.GA7008@gerhold.net/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0472f8d3c054a0ff58122fc9d2dbf84f197a284f

      reply	other threads:[~2022-08-06  4:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  7:49 [PATCH 0/4] Support dynamic voltage frequency scaling inside clock controller Jun Nie
2022-08-05  7:49 ` [PATCH 1/4] clk: Aggregate power operation in " Jun Nie
2022-08-05  7:49 ` [PATCH 2/4] soc: qcom: rpmpd: Add corner power-domains states Jun Nie
2022-09-26 16:29   ` Bjorn Andersson
2022-10-24  4:27     ` Jun Nie
2022-08-05  7:49 ` [PATCH 3/4] arm64: dts: qcom: add power domain for clk controller Jun Nie
2022-09-26 16:33   ` Bjorn Andersson
2022-08-05  7:49 ` [PATCH 4/4] clk: qcom: gcc-msm8916: Add power domain data Jun Nie
2022-08-05  9:32 ` [PATCH 0/4] Support dynamic voltage frequency scaling inside clock controller Stephan Gerhold
2022-08-06  4:43   ` Jun Nie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABymUCMJ0CL+aog-8PDvUiAb4ivhZRxidvUUKu6vO1453mN3qA@mail.gmail.com \
    --to=jun.nie@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.