From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092AFC433F5 for ; Wed, 20 Apr 2022 10:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377465AbiDTKDq (ORCPT ); Wed, 20 Apr 2022 06:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359210AbiDTKDe (ORCPT ); Wed, 20 Apr 2022 06:03:34 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A4D83ED30 for ; Wed, 20 Apr 2022 03:00:48 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id l9-20020a056830268900b006054381dd35so768758otu.4 for ; Wed, 20 Apr 2022 03:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8JtaQ1pue+8sFHmxc4Knv9XbBREmqsMrzMrBQgT5CNc=; b=lo9mEJqy0BDD/zBNtWkye9QrbEN3+dCG67elnm/8Uexr21WAe7v6GqsPmD599RziAo pwgie+daElB4CDINXRC5U/GxzxNo81N2t76h1tqbdUNlsHu1zwSMkVMNjtB0mGa47sHN gdy6ZJg3h/R2AjBDqvcjZGYWJPtbGBoNKPkvsH8G000O5lMvVuIsjVvi3abfBAGFMhLA E81fmU8+rrpdhV79X8afiDQ31nsvtsU0glt8KCHPymO13YkpWcM7gaQk2/rXvi1TIXGQ IFIfkpyNh0xvDGaEMx2DesEVrx3ovpg4JIC9d8xaMseFNiVy9/L1ixhzpVzDKbz188gL PX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8JtaQ1pue+8sFHmxc4Knv9XbBREmqsMrzMrBQgT5CNc=; b=6eMywVN+zLqIJFs7XsxsEhte1IyQ9huyG1r1jQasApbvUYXQk2eXC5RhX4PE8NKA7v 0eD9QOKPNpUxgUpWzcab4cMWeqqcHgHpR8RmTPjFqs7DUeupfxFAOGaDpfwse1ZdLqEf TW2hf8hrCHJuMmpX+xRSBRQAJTb3jD+2neqmwDWJ4eoDZUKftSVwNTj+61FaVJJ5n/Hx nlVCZkTslR8DIu0j3SXPqBzpgCZLcfw5vxfYIFSHN63YU29orMbokwqB3G8K7e6V38aT cUFHpFjfhwBPrsDZy0YrM9QVUC1EpgleiyGJdqZZCs3tDpUyur/ZEQ4hv3eigGTQxvSW wYFw== X-Gm-Message-State: AOAM530bIm6harbE7zoni8IE5rlsueUj38shrOPvncSrXlFsvuun4+Ts Q/KlqF/G1BvyXIytJA/u7ZTPvjQSKwI0Fa2A6jdh5Q== X-Google-Smtp-Source: ABdhPJzcJdBcjNTGYlbBgosfnSB5j34lXnm5wXFPbGVIIYHLxzjdaEQRdhuTH94cPAIiACAl9GOomm2ePAotGvtEjv4= X-Received: by 2002:a9d:5913:0:b0:5cd:a050:8f55 with SMTP id t19-20020a9d5913000000b005cda0508f55mr7320316oth.44.1650448847968; Wed, 20 Apr 2022 03:00:47 -0700 (PDT) MIME-Version: 1.0 References: <20220419010903.3109514-1-bryan.odonoghue@linaro.org> <20220419010903.3109514-3-bryan.odonoghue@linaro.org> <737d44a9-56ba-846e-24ad-36b2da52d2d7@linaro.org> <0cb490f4-3df8-7fc8-277f-070e0133f5db@linaro.org> In-Reply-To: From: Jun Nie Date: Wed, 20 Apr 2022 18:00:35 +0800 Message-ID: Subject: Re: [PATCH v1 2/4] arm64: dts: Add msm8939 SoC To: Krzysztof Kozlowski Cc: "Bryan O'Donoghue" , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, shawn.guo@linaro.org, benl@squareup.com, jwillcox@squareup.com, jgates@squareup.com, mchen@squareup.com, zac@squareup.com, Leo Yan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Jun Nie =E4=BA=8E2022=E5=B9=B44=E6=9C=8820=E6=97=A5=E5= =91=A8=E4=B8=89 17:57=E5=86=99=E9=81=93=EF=BC=9A > > > >> > > >> Generic node names, no underscores in node names. This applies every= where. > > >> > > >>> + compatible =3D "qcom,qfprom"; > > >>> + reg =3D <0x00058000 0x1000>; > > >>> + #address-cells =3D <1>; > > >>> + #size-cells =3D <1>; > > >>> + cpr_efuse_init_voltage1: ivoltage1@dc { > > >> > > >> s/ivoltageX/voltage/ > > > > > > How about cpr_efuse_init_voltage_dc? There are 3 > > > cpr_efuse_init_voltage* node here. > > > > The node names should be generic, so this should be maybe even just > > "efuse"? Feel free to add some prefix to it, so "init-voltage-efuse", > > but no underscores and no suffixes in such case (but "init-voltage2-efu= se"). > > The nodes are referenced by other node, such as below case. So I have > to name them, > underscore is the best separator. While I have 3 init_voltage related > nodes to name. > What's the name you suggest for them? > > arch/arm/boot/dts/qcom-apq8084.dtsi: nvmem-cells =3D <&tsens_calib>, > <&tsens_backup>; > Maybe it should like this? cpr_efuse_init_voltage1: efuse { > Regards, > Jun