All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun Nie <jun.nie@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: abel.vesa@linaro.org, bjorn.andersson@linaro.org,
	mturquette@baylibre.com, sboyd@kernel.org, agross@kernel.org,
	shawn.guo@linaro.org, bryan.odonoghue@linaro.org,
	linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] soc: qcom: rpmpd: Add corner power-domains states
Date: Mon, 24 Oct 2022 12:27:03 +0800	[thread overview]
Message-ID: <CABymUCP9XbKvq=_7Q1ToE7cp3zP1JF2KThK-SSTz=B6mS92eXQ@mail.gmail.com> (raw)
In-Reply-To: <20220926162917.yte3kooilqenufrp@builder.lan>

Bjorn Andersson <andersson@kernel.org> 于2022年9月27日周二 00:29写道:
>
> On Fri, Aug 05, 2022 at 03:49:33PM +0800, Jun Nie wrote:
> > Some SoCs use corner instead of level in rpm regulator, such as
> > MSM8916 and MSM8939. Add these power-domains states value so that
> > devices can vote them.
> >
> > Note that there is a shift with 1 when converting the value from
> > regulator usage in Qualcomm Linux 3.18 to power domain usage here.
> > Because corner is not well hacked in regulator framework in 3.18.
> > For example, RPM_REGULATOR_CORNER_RETENTION is 2 in 3.18 while
> > RPM_SMD_CORNER_RETENTION is 1.
> >
>
> How about we just stick with the numbers in the rpmpd node in DT, as
> that would be the only place these constants are used and all the actual
> users can use the label associated there?
>
> Regards,
> Bjorn

The clock driver change in this patch set, the consumer of the
regulator, is dropped. So there
is no more consumers that need the name. So this whole patch set can
be abandoned now.

Regards,
Jun
>
> > Signed-off-by: Jun Nie <jun.nie@linaro.org>
> > ---
> >  include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> > index 6cce5b7aa940..f778dbbf083d 100644
> > --- a/include/dt-bindings/power/qcom-rpmpd.h
> > +++ b/include/dt-bindings/power/qcom-rpmpd.h
> > @@ -297,4 +297,12 @@
> >  #define RPM_SMD_LEVEL_TURBO_HIGH      448
> >  #define RPM_SMD_LEVEL_BINNING         512
> >
> > +/* RPM SMD Power Domain performance levels in regulator corner method */
> > +#define RPM_SMD_CORNER_RETENTION     1
> > +#define RPM_SMD_CORNER_SVS_KRAIT     2
> > +#define RPM_SMD_CORNER_SVS_SOC               3
> > +#define RPM_SMD_CORNER_NORMAL                4
> > +#define RPM_SMD_CORNER_TURBO         5
> > +#define RPM_SMD_CORNER_SUPER_TURBO   6
> > +
> >  #endif
> > --
> > 2.25.1
> >

  reply	other threads:[~2022-10-24  4:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  7:49 [PATCH 0/4] Support dynamic voltage frequency scaling inside clock controller Jun Nie
2022-08-05  7:49 ` [PATCH 1/4] clk: Aggregate power operation in " Jun Nie
2022-08-05  7:49 ` [PATCH 2/4] soc: qcom: rpmpd: Add corner power-domains states Jun Nie
2022-09-26 16:29   ` Bjorn Andersson
2022-10-24  4:27     ` Jun Nie [this message]
2022-08-05  7:49 ` [PATCH 3/4] arm64: dts: qcom: add power domain for clk controller Jun Nie
2022-09-26 16:33   ` Bjorn Andersson
2022-08-05  7:49 ` [PATCH 4/4] clk: qcom: gcc-msm8916: Add power domain data Jun Nie
2022-08-05  9:32 ` [PATCH 0/4] Support dynamic voltage frequency scaling inside clock controller Stephan Gerhold
2022-08-06  4:43   ` Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABymUCP9XbKvq=_7Q1ToE7cp3zP1JF2KThK-SSTz=B6mS92eXQ@mail.gmail.com' \
    --to=jun.nie@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.