From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B9BC4332F for ; Wed, 1 Dec 2021 23:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353896AbhLAX6v (ORCPT ); Wed, 1 Dec 2021 18:58:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344023AbhLAX6s (ORCPT ); Wed, 1 Dec 2021 18:58:48 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1AFEC061574 for ; Wed, 1 Dec 2021 15:55:26 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id b67so32920899qkg.6 for ; Wed, 01 Dec 2021 15:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=jCkXdMKskBUT2OYx7Iaa2BLRafUdDejK8djqWKix9T6swIAuLZxsGqdR4LzM5/sE3G JDmzjvBHFhnRgl47r/VjZFASHCgHpTdLo1VGBGxbbWxVmTPdWgGsuRfuzt8akpS21HLg OTBZNZBgwEoYUu53vs0qkpJYiVPEorqa7Ri40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=5FKQsG8oAZrOMJ/6QE5X95XjqHNYWkoiMMIuBdvp3iIYiv2AmCssKxzDgEwUptIIWv FYaT2956QM7YT5e4FcX/mfb6mdGnG1WTwcbK688nlLbLFgcF6/TYIqeLRj8VzWIUqMYu 7EfKjY59uzQ6Qeqj+uaZRiPWUl9kuQ1FeYygxMaV5whaFbMWoauURXG2fY6dJ4YkHMmD amTnyFZwtmCS7e73VJtfeIimhxpjhaxMcF75T+DwASVHHFoMI7qFkJR80mTnDTWbFMCk bkm6r7hkKWNls17TMf77g5LFQ5tKWyddj8I9DrV+fKKiXY0GpoHbavkI2DmycXrtw9Kr GofQ== X-Gm-Message-State: AOAM531m93i72g8MBU9wtIwJzoROwUzH3aLl/Sz5deEZ16ipEjKFf15Y pv/vLVhhQ41B4Y+oGc6FM3BBh58UIfXmTtngdyikcg== X-Google-Smtp-Source: ABdhPJwDrESPOFAKGV76+3Yd4DHuNO5qwOKr/plQ6gy9TgikmfsgmMo5D/ZY+B7br+XAoX3AcL0s/vToKivqbssMv5Q= X-Received: by 2002:a37:8805:: with SMTP id k5mr9678214qkd.426.1638402926057; Wed, 01 Dec 2021 15:55:26 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: <20211129034201.5767-3-yunfei.dong@mediatek.com> From: Steve Cho Date: Wed, 1 Dec 2021 15:55:15 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > 3 files changed, 9 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 59caf2163349..055d50e52720 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -31,13 +31,6 @@ > module_param(mtk_v4l2_dbg_level, int, 0644); > module_param(mtk_vcodec_dbg, bool, 0644); > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > -{ > - ctx->int_cond = 1; > - wake_up_interruptible(&ctx->queue); > -} > - > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > { > struct mtk_vcodec_dev *dev = priv; > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > - wake_up_ctx(ctx); > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); Assuming setting up reason doesn't change functionality. > > mtk_v4l2_debug(3, > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > index 581522177308..1d2370608d0d 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > } > > +/* Wake up context wait_queue */ > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > +{ > + ctx->int_cond = 1; > + ctx->int_type = reason; > + wake_up_interruptible(&ctx->queue); > +} > + > #endif /* _MTK_VCODEC_DRV_H_ */ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > index eed67394cf46..7c3487fb3498 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > }, > }; > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > -{ > - ctx->int_cond = 1; > - ctx->int_type = reason; > - wake_up_interruptible(&ctx->queue); > -} > - > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > { > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD35C433EF for ; Wed, 1 Dec 2021 23:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0/DrZCq12IDTHgNUeQV0s4QG/jauUOlmSv2dP8XPNS4=; b=yqS9RuP/HBfnDl iTTH8vNJ/zRQv0hVU1zf41sNDLxjLA+oEyC7U8P9U8JnySLZ5Rk7OQtoTYeAQnR7+uDef2OWMiML9 dtcOZNP9eBxD/Vms5y2o60SqhtMWSriJ2ETGmx2K5eHJu2EwWaGZjCH0AnA2SkFVHwrog5CWXgmt2 2+jnTZckZyo0ngue2Q8SCsNKLlLI5A2ScOkoTvP9AdkibT8qCy9PNBvyaS6dFWMFs7CrwQB789HzX X2m8+/9ELks6BlfwjO3tK9awtScsAl+Jrs7Ns1j9B5EGWtU3+fXzGQYtxVoVNd1KFFxzHg5Ho6yvX nBtyHYEPwW/TvcOpjr5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZRh-00ALux-QI; Wed, 01 Dec 2021 23:55:29 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZRf-00ALuI-Qm for linux-mediatek@lists.infradead.org; Wed, 01 Dec 2021 23:55:29 +0000 Received: by mail-qk1-x72e.google.com with SMTP id 193so32951301qkh.10 for ; Wed, 01 Dec 2021 15:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=jCkXdMKskBUT2OYx7Iaa2BLRafUdDejK8djqWKix9T6swIAuLZxsGqdR4LzM5/sE3G JDmzjvBHFhnRgl47r/VjZFASHCgHpTdLo1VGBGxbbWxVmTPdWgGsuRfuzt8akpS21HLg OTBZNZBgwEoYUu53vs0qkpJYiVPEorqa7Ri40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=OXr85ZI6eaGv0pwNenUjsDRiGSsiSgJqPidcbFiFE3reFrLWuBNy/E4+wArf9hcgoY bhXbRMTpNH3fQeiJAL8Pj8bXByKxoZTYJcr0k1YFKkZPCm6DUHoclVn0GAJSiLr2NYYi 09fAhU0scBFJ/lbTmhEo5OZ2C5Bg16/bzMOE7ukorwJKKtcm8hujLDECLsBV1tvqN3pk r7KA+VpvvNsE7+8XhLE6LQHY+OQ1FfgWot5FnMksH5zFv5yOXh/F7fH68mOtwfchbWZ7 bdbQ0HI04FFuWNSJDfQJdrbwcAYFYsVe9UUja+wKQMEQmi4ibbBAeclSMbj0/AdJ9N5A 2WgA== X-Gm-Message-State: AOAM5311HiGC0WJv3qxQUqMYMVuT9mQ6WJzgQ+7lnxGdnC6kanr/abrC tW1HxB0sYlnEJPsPJAKasDdCfBfWOPE/O6rYCRkVWw== X-Google-Smtp-Source: ABdhPJwDrESPOFAKGV76+3Yd4DHuNO5qwOKr/plQ6gy9TgikmfsgmMo5D/ZY+B7br+XAoX3AcL0s/vToKivqbssMv5Q= X-Received: by 2002:a37:8805:: with SMTP id k5mr9678214qkd.426.1638402926057; Wed, 01 Dec 2021 15:55:26 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: <20211129034201.5767-3-yunfei.dong@mediatek.com> From: Steve Cho Date: Wed, 1 Dec 2021 15:55:15 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_155527_932118_191BD282 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > 3 files changed, 9 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 59caf2163349..055d50e52720 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -31,13 +31,6 @@ > module_param(mtk_v4l2_dbg_level, int, 0644); > module_param(mtk_vcodec_dbg, bool, 0644); > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > -{ > - ctx->int_cond = 1; > - wake_up_interruptible(&ctx->queue); > -} > - > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > { > struct mtk_vcodec_dev *dev = priv; > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > - wake_up_ctx(ctx); > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); Assuming setting up reason doesn't change functionality. > > mtk_v4l2_debug(3, > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > index 581522177308..1d2370608d0d 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > } > > +/* Wake up context wait_queue */ > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > +{ > + ctx->int_cond = 1; > + ctx->int_type = reason; > + wake_up_interruptible(&ctx->queue); > +} > + > #endif /* _MTK_VCODEC_DRV_H_ */ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > index eed67394cf46..7c3487fb3498 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > }, > }; > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > -{ > - ctx->int_cond = 1; > - ctx->int_type = reason; > - wake_up_interruptible(&ctx->queue); > -} > - > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > { > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > -- > 2.25.1 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1191CC433F5 for ; Wed, 1 Dec 2021 23:55:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 168A36E964; Wed, 1 Dec 2021 23:55:29 +0000 (UTC) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A9976E964 for ; Wed, 1 Dec 2021 23:55:27 +0000 (UTC) Received: by mail-qk1-x733.google.com with SMTP id t83so32931561qke.8 for ; Wed, 01 Dec 2021 15:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=jCkXdMKskBUT2OYx7Iaa2BLRafUdDejK8djqWKix9T6swIAuLZxsGqdR4LzM5/sE3G JDmzjvBHFhnRgl47r/VjZFASHCgHpTdLo1VGBGxbbWxVmTPdWgGsuRfuzt8akpS21HLg OTBZNZBgwEoYUu53vs0qkpJYiVPEorqa7Ri40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=aaT7n6073tyuZWfpEHqMkU1zNZYQT/0fg6QXhiDV6oyDmMqnJSNuUztL+nijl1MR4X WhI09U3JmoZdB39UD5jrHpIN/LUpN22RJlHIc5BYY74Mi2B9VtomTg6C59sbOH4RgwBd wIYdW7DqN64Y5DcKSFKE6ddwQicERnK3q+FeNO47d97NClLiBlbIQYIZtkFQP48HKqtr WwDAyVzN8UqZFFuPVQ0VXz3mpy59lixOe+Vl5ARaxPQ0WQ/kHpti8C4BD5RdUmr3Ju0W 7Z2DsqsbgRdnvjRTPlSlSrk6Jie2StfKvbkfF6trOjz37e5+ZNsFJ0sLNGh72B3B3uN4 9ogQ== X-Gm-Message-State: AOAM530P6ylcZaT/gr3ucYI6aYEjjKmNfwFyLIa1MX/ofPXqYRc4Txet IideJL2q4E1+1IsX1roN3CCZ05I/unXMCR3lJvfDlQ== X-Google-Smtp-Source: ABdhPJwDrESPOFAKGV76+3Yd4DHuNO5qwOKr/plQ6gy9TgikmfsgmMo5D/ZY+B7br+XAoX3AcL0s/vToKivqbssMv5Q= X-Received: by 2002:a37:8805:: with SMTP id k5mr9678214qkd.426.1638402926057; Wed, 01 Dec 2021 15:55:26 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: <20211129034201.5767-3-yunfei.dong@mediatek.com> From: Steve Cho Date: Wed, 1 Dec 2021 15:55:15 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Dafna Hirschfeld , dri-devel , Irui Wang , Mauro Carvalho Chehab , Benjamin Gaignard , Project_Global_Chrome_Upstream_Group@mediatek.com, Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tzung-Bi Shih , Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , Tiffany Lin , linux-arm-kernel@lists.infradead.org, Alexandre Courbot , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > 3 files changed, 9 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 59caf2163349..055d50e52720 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -31,13 +31,6 @@ > module_param(mtk_v4l2_dbg_level, int, 0644); > module_param(mtk_vcodec_dbg, bool, 0644); > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > -{ > - ctx->int_cond = 1; > - wake_up_interruptible(&ctx->queue); > -} > - > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > { > struct mtk_vcodec_dev *dev = priv; > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > - wake_up_ctx(ctx); > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); Assuming setting up reason doesn't change functionality. > > mtk_v4l2_debug(3, > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > index 581522177308..1d2370608d0d 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > } > > +/* Wake up context wait_queue */ > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > +{ > + ctx->int_cond = 1; > + ctx->int_type = reason; > + wake_up_interruptible(&ctx->queue); > +} > + > #endif /* _MTK_VCODEC_DRV_H_ */ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > index eed67394cf46..7c3487fb3498 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > }, > }; > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > -{ > - ctx->int_cond = 1; > - ctx->int_type = reason; > - wake_up_interruptible(&ctx->queue); > -} > - > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > { > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62F33C433EF for ; Wed, 1 Dec 2021 23:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vxH/kOWQc+QGOAz3+Z1v98F0fGtMCUjjIPI1fINwGQ=; b=uIXsB82FBCPGdC bQOHhuAZNGufHIF8G22IdOpBXsFyRbsu45bCJcNd7HFD1R6bPfT6n8YQefhiHvLZDONRLGrqfYYrS NXRB5BtI5EZl4PcePHjs+/Zs/QnhsJ3JlKQHb15tjVdjxziJy4y39cOBWl0RLv/nOlkr/dW0yWp7m R4K6aTD1omInSTnfrzCaITUErYugB8XFiOUxeFtaDeGDCf4utuo0jjQG4AnBIEk/OXUnIxccP5WVu noDA1S8Eq43E66WS2Qf+J/aIt8zoOzj9RhF+nJH8rfT6i68L6tznO5/OHRu1ad9zKuGLIxv0rAqOH JNvp0rlJYjhDziM8VhBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZRk-00ALv8-Tx; Wed, 01 Dec 2021 23:55:33 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZRf-00ALuJ-Q4 for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 23:55:29 +0000 Received: by mail-qk1-x736.google.com with SMTP id p4so32933882qkm.7 for ; Wed, 01 Dec 2021 15:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=jCkXdMKskBUT2OYx7Iaa2BLRafUdDejK8djqWKix9T6swIAuLZxsGqdR4LzM5/sE3G JDmzjvBHFhnRgl47r/VjZFASHCgHpTdLo1VGBGxbbWxVmTPdWgGsuRfuzt8akpS21HLg OTBZNZBgwEoYUu53vs0qkpJYiVPEorqa7Ri40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GVZ70Dywr625UyFi302s6LjnjHklxJb/tfvnMbwjLaM=; b=f0t6zPs4SBz04r2FvmCM+VquJ53AwWwCCdn86l0boaVjDk9u+lOZbOXTUi05too9ez woecpxkakSsFFXl1j0clCFQQms5N4Hrqlv5Rrb++Fb8n1C0Sv0ZvzUWETSvFaKbdzA+M 10fePogvGmJzETih/fOzQ8RNquhAE0KFJyjSFB7c1SxXmK9wHnskZiNglyq0qcfBvtcW YbYVSiw0hhvxCzDWylXc7H4CX5xkGiB7MgmPg9fU28qFmXsygBtIIvIFzE0gSLWF6Hh/ bvyGlvmibxuwdAdcRhMXsuU0z4EpxmX4UGE9SmS00yFwJZXhWN2AwPMefJYZvo7H0sdw NUHw== X-Gm-Message-State: AOAM530e901rjAN1aqjh49ud5laR6+nVu7RjuyLfeS6xoHr2ZHz8oecO 3K4xoEGv/okMEYyujMYO22IxOPwQyWmRs9Woj6yPlg== X-Google-Smtp-Source: ABdhPJwDrESPOFAKGV76+3Yd4DHuNO5qwOKr/plQ6gy9TgikmfsgmMo5D/ZY+B7br+XAoX3AcL0s/vToKivqbssMv5Q= X-Received: by 2002:a37:8805:: with SMTP id k5mr9678214qkd.426.1638402926057; Wed, 01 Dec 2021 15:55:26 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: <20211129034201.5767-3-yunfei.dong@mediatek.com> From: Steve Cho Date: Wed, 1 Dec 2021 15:55:15 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_155527_932274_04ADD3E1 X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org LGTM. On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > Vdec and venc can use the same function to wake up interrupt event. > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Yunfei Dong > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > 3 files changed, 9 insertions(+), 16 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 59caf2163349..055d50e52720 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -31,13 +31,6 @@ > module_param(mtk_v4l2_dbg_level, int, 0644); > module_param(mtk_vcodec_dbg, bool, 0644); > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > -{ > - ctx->int_cond = 1; > - wake_up_interruptible(&ctx->queue); > -} > - > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > { > struct mtk_vcodec_dev *dev = priv; > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > - wake_up_ctx(ctx); > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); Assuming setting up reason doesn't change functionality. > > mtk_v4l2_debug(3, > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > index 581522177308..1d2370608d0d 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > } > > +/* Wake up context wait_queue */ > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > +{ > + ctx->int_cond = 1; > + ctx->int_type = reason; > + wake_up_interruptible(&ctx->queue); > +} > + > #endif /* _MTK_VCODEC_DRV_H_ */ > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > index eed67394cf46..7c3487fb3498 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > }, > }; > > -/* Wake up context wait_queue */ > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > -{ > - ctx->int_cond = 1; > - ctx->int_type = reason; > - wake_up_interruptible(&ctx->queue); > -} > - > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > { > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel