From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F12EC433FE for ; Wed, 1 Dec 2021 23:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353926AbhLBACG (ORCPT ); Wed, 1 Dec 2021 19:02:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353916AbhLBACD (ORCPT ); Wed, 1 Dec 2021 19:02:03 -0500 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19BC6C061748 for ; Wed, 1 Dec 2021 15:58:42 -0800 (PST) Received: by mail-qt1-x830.google.com with SMTP id l8so25888509qtk.6 for ; Wed, 01 Dec 2021 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=UiQtL7PYDLYrQNpaKD6zuScFDLJgXtjIiVUSuenai/weJwHaNZGd50drPKnS644xJI FsIUoEA38p0/+CgS2GnR18T3SWsehh9cfFdQhsGcYNw83eEXy2yN0V551YDlQed1a5ia suumy0/x42VakjEbn2dWsY6UEt7ktkLXMzUVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=H5lWUmdidmeBnc5rpa5qVQLOV99muwbjdqy+ZaZgd+1YLAJFYUB3mux909P93B9TWf CKNbVXuKNuLMJbHlJHol/UpTlfhfXkTO52cxCAah39bKYVzSEhwZrEE/aiXFGTQXz9T1 LJlg3R/dOhIHJFyeGaftDStZnCSeYX0a0SIpM5oEv90OL2KYkj/VTRttszdg0EDcIVYC /xGbaESnG82Z0hMskStmGSOoBhWt4P7ldkwJ9cuD/SUJaaSh3O3KiCYLcbXm4T1zapiJ XEkC08QsS+xuJll1tVP/vhesU0f71BC6PiG8JlGkAYeF1vY3RcWg+Cv81D/tFnSEW9bJ mVjg== X-Gm-Message-State: AOAM532iQfhSL4qETE2A6n9pmJQCJTCUvXWfdclltkJA/iMSvCZQ3/PC 2Oo4GSxW1viA5rjdrXRK3yimqp7A5LWXZm+o6Hevaw== X-Google-Smtp-Source: ABdhPJxjAowIZNevtYxc/JYBCkiAIs98qYglgiULGYpJOCGmpv/QaOf2gRWJM912xU3UVIlhW8QOcnJt6ZYIil4W+Lg= X-Received: by 2002:a05:622a:130e:: with SMTP id v14mr10542855qtk.458.1638403121278; Wed, 01 Dec 2021 15:58:41 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: From: Steve Cho Date: Wed, 1 Dec 2021 15:58:30 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > > --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > > 3 files changed, 9 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 59caf2163349..055d50e52720 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -31,13 +31,6 @@ > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > -{ > > - ctx->int_cond = 1; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > > > - wake_up_ctx(ctx); > > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); > > Assuming setting up reason doesn't change functionality. > > > > > mtk_v4l2_debug(3, > > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 581522177308..1d2370608d0d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > > } > > > > +/* Wake up context wait_queue */ > > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > +{ > > + ctx->int_cond = 1; > > + ctx->int_type = reason; > > + wake_up_interruptible(&ctx->queue); > > +} > > + > > #endif /* _MTK_VCODEC_DRV_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > index eed67394cf46..7c3487fb3498 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > > }, > > }; > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > -{ > > - ctx->int_cond = 1; > > - ctx->int_type = reason; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > > { > > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > > -- > > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2596FC433EF for ; Wed, 1 Dec 2021 23:58:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 201ED6E9D1; Wed, 1 Dec 2021 23:58:43 +0000 (UTC) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30F606E98A for ; Wed, 1 Dec 2021 23:58:42 +0000 (UTC) Received: by mail-qt1-x82d.google.com with SMTP id v22so25855619qtx.8 for ; Wed, 01 Dec 2021 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=UiQtL7PYDLYrQNpaKD6zuScFDLJgXtjIiVUSuenai/weJwHaNZGd50drPKnS644xJI FsIUoEA38p0/+CgS2GnR18T3SWsehh9cfFdQhsGcYNw83eEXy2yN0V551YDlQed1a5ia suumy0/x42VakjEbn2dWsY6UEt7ktkLXMzUVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=umpefliUfdsrhZ5vDa6DEpO6VPY58q+OUABwKpshwWLJ35tfwBsIVWiTaWjZwVDUT6 Zoe1sEwIjvc93W87knlO6elpd1GrL8pKRjP5GGMtEPtWWWZ5Q8E2B/Wo74w7gHiNJ5HO dO6M3V+o3SDR720NMiHi5j0WdAm9UFK98sxB2QeeHBTg0Rl+iFTPwvb+sw83SH/bojyA ETx55//GdwGUvgvN0B4xd1bcVH4qX0GspQ2iJs0qkI+77Hfzm+NgolIzSGaxB8LYr+0g haC+LQnWujFSs8XaN3iNbZ3tiZrb9lZMjAb7ecdwcw2UzFBCFm0qSsev7VyLRMD9sb2q /tLw== X-Gm-Message-State: AOAM531Y5m6FBWkdsneEnucaQ9Q0J5IPU6I8xyjv+Du2kdradMDtrPHp CrOjCpp6mHDH8xM0+IX0ZYje3SFgJhsM1Pd7wZvbKg== X-Google-Smtp-Source: ABdhPJxjAowIZNevtYxc/JYBCkiAIs98qYglgiULGYpJOCGmpv/QaOf2gRWJM912xU3UVIlhW8QOcnJt6ZYIil4W+Lg= X-Received: by 2002:a05:622a:130e:: with SMTP id v14mr10542855qtk.458.1638403121278; Wed, 01 Dec 2021 15:58:41 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: From: Steve Cho Date: Wed, 1 Dec 2021 15:58:30 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Dafna Hirschfeld , dri-devel , Irui Wang , Mauro Carvalho Chehab , Benjamin Gaignard , Project_Global_Chrome_Upstream_Group@mediatek.com, Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tzung-Bi Shih , Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , Tiffany Lin , linux-arm-kernel@lists.infradead.org, Alexandre Courbot , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > > --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > > 3 files changed, 9 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 59caf2163349..055d50e52720 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -31,13 +31,6 @@ > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > -{ > > - ctx->int_cond = 1; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > > > - wake_up_ctx(ctx); > > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); > > Assuming setting up reason doesn't change functionality. > > > > > mtk_v4l2_debug(3, > > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 581522177308..1d2370608d0d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > > } > > > > +/* Wake up context wait_queue */ > > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > +{ > > + ctx->int_cond = 1; > > + ctx->int_type = reason; > > + wake_up_interruptible(&ctx->queue); > > +} > > + > > #endif /* _MTK_VCODEC_DRV_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > index eed67394cf46..7c3487fb3498 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > > }, > > }; > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > -{ > > - ctx->int_cond = 1; > > - ctx->int_type = reason; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > > { > > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > > -- > > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53CEC433EF for ; Wed, 1 Dec 2021 23:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qv/lirXFuKCnIUz4EWJC+d7+tdYKcBBG9pWeqsFjPHU=; b=WrabZiACIyWP/e DE2G7+FPkoSKA/j4R4+/YFR1bsvSJjoG18R9AH67oSEDWVVMinhDNemYbs00ktum0Xot38rB5pH8U hV/tox7P2iuL+dWjx/50MqLeZIjto2ZDA+GWfK+MuK4UtHxrYSM8o7jNJQlFEYet9NQvFe5crFNQ1 7es3JFPrk6OqvgZifOyUivqBJWEBCQiPP7iafzoEA6vRlfJ5n2Ewk8KqIFV4mB9jJUn91ViLhuBeY k84gkg4Cwdq8IR2oflVUKKREJa3PFBtmSWiN+OXNvQp74hL2w+CKU5tnQn4vT1SLFzq+IrWu7gfct 31PXeMIDOw/bvbALH/KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZVH-00AMYJ-AC; Wed, 01 Dec 2021 23:59:11 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZUz-00AMOe-J1 for linux-mediatek@lists.infradead.org; Wed, 01 Dec 2021 23:58:55 +0000 Received: by mail-qt1-x835.google.com with SMTP id 8so25870327qtx.5 for ; Wed, 01 Dec 2021 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=UiQtL7PYDLYrQNpaKD6zuScFDLJgXtjIiVUSuenai/weJwHaNZGd50drPKnS644xJI FsIUoEA38p0/+CgS2GnR18T3SWsehh9cfFdQhsGcYNw83eEXy2yN0V551YDlQed1a5ia suumy0/x42VakjEbn2dWsY6UEt7ktkLXMzUVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=BTqhyYzc4yQ+JqkIZViGKlehTmKDK4hirEoMGSiR7bdnYblrtwyPd/iyYoIAR9UQDQ R21zEifwg6TDmmjC3fJr0GSpOqdkmchn50yw6i51bSnvRtWRW9in6H1LXtWcjSQrcof1 7IgMghAxkOEui0u1LNNhkv+HGPLiqjbs1hRbTvNlWWxbr22HyBmUxXxNt+x0+77Q1Y55 ujdn9IqdVdYbDVQarwJkodn2OMzRrU/soqZDSzWdOgQBdVMsrKwB8xs+NNKawCnif2nV MrfH20/UMlkq0OoewlgpnTzQczkMsGeU5BFIa1Nm0AeW1DyXvKy9RFlJr5MLd98czoSH 52iw== X-Gm-Message-State: AOAM530s7ftBY6WCUJ2UFbh6jYT/yj9OTRiocfDjXyWOJaUANr+Vdrva LX4tMat4oTpYX8H01mydtMXUO3r+GWC7A4ZIVyRfGA== X-Google-Smtp-Source: ABdhPJxjAowIZNevtYxc/JYBCkiAIs98qYglgiULGYpJOCGmpv/QaOf2gRWJM912xU3UVIlhW8QOcnJt6ZYIil4W+Lg= X-Received: by 2002:a05:622a:130e:: with SMTP id v14mr10542855qtk.458.1638403121278; Wed, 01 Dec 2021 15:58:41 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: From: Steve Cho Date: Wed, 1 Dec 2021 15:58:30 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_155853_658044_4B493D68 X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > > --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > > 3 files changed, 9 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 59caf2163349..055d50e52720 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -31,13 +31,6 @@ > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > -{ > > - ctx->int_cond = 1; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > > > - wake_up_ctx(ctx); > > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); > > Assuming setting up reason doesn't change functionality. > > > > > mtk_v4l2_debug(3, > > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 581522177308..1d2370608d0d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > > } > > > > +/* Wake up context wait_queue */ > > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > +{ > > + ctx->int_cond = 1; > > + ctx->int_type = reason; > > + wake_up_interruptible(&ctx->queue); > > +} > > + > > #endif /* _MTK_VCODEC_DRV_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > index eed67394cf46..7c3487fb3498 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > > }, > > }; > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > -{ > > - ctx->int_cond = 1; > > - ctx->int_type = reason; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > > { > > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > > -- > > 2.25.1 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3332CC433EF for ; Thu, 2 Dec 2021 00:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8eTOasCkzfbllR0fx5GXGMomLW9+bmktQDUARZZd91w=; b=hq1G/YEChAmmFq 7bUu8iEryEzzSoS5meFxVe5CkThSahtl4pi3Msj19+P8mfQsrI7XXUUR/Y9MGKOoMizu3YZGwuOtP Kf3vnEjRbLLU9QMZYZYs6taxyla1/2aADsdilU+DOowsqGWdQOjZMCXuvScpZl4iFOcwNAXUbIoOP ghdFFqXvP85octMKJ4Szi6q4ZXoi95efPNFKv+rHDnLNaFVbeAz82wknIlpuFv/ZSGZ49dJi4Epkd KZxz6AwL5Ey7nK6hsw0Z45m82w3ZA6TJp7GnOdIAkrfpfo03R5rJrzqmoW+6TeM158BdZnvZfGnKg AIRDJd0JogmbT4xxmX4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZV2-00AMTo-MY; Wed, 01 Dec 2021 23:58:56 +0000 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msZUy-00AMOd-NX for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 23:58:54 +0000 Received: by mail-qt1-x830.google.com with SMTP id q14so25823817qtx.10 for ; Wed, 01 Dec 2021 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=UiQtL7PYDLYrQNpaKD6zuScFDLJgXtjIiVUSuenai/weJwHaNZGd50drPKnS644xJI FsIUoEA38p0/+CgS2GnR18T3SWsehh9cfFdQhsGcYNw83eEXy2yN0V551YDlQed1a5ia suumy0/x42VakjEbn2dWsY6UEt7ktkLXMzUVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mKAVFtfRZpn9mek6iPysBIxAT9sFeNDh1PJVk69vAok=; b=4Jg0NhfKa9JoTWcw+vxC7/7xfAM6f5sqFAvqEEsmNFeGUFlRMk+Y/2XG+xzKyrfErU mpN0uU8Jd0m0wFwcY6errE9n3Dp6m/mcScXZmxNnAO3tW0lOh1tSZxtsbdZFvS9dn9Vt jwuZdV3zBDM/bLIfZgKIN7l5RG9/u6crJe26yXIn7Mcw54aufcB9F7adBy1lqmHzSZbB wMOFkJWI2fm20791YeN6XeMdJDNWTM0x3qLEfWzrFs6poBontQhryfpgAL/6KRdqgATy Eptu7otaXKfXg22EzB88VpfVXAlOlsFl0ORin549oeBk8SgKp/Nemq9D0L6nsuUFKF5Z ts5w== X-Gm-Message-State: AOAM531BfxVoDrrrV4iEA1XykmMnERZi/2ldbHbkd3oPLuKGgEhwBC+z jUx3K+bx7VqO07YW1/7NlwnAuGqr1W95kjY/l8yuxw== X-Google-Smtp-Source: ABdhPJxjAowIZNevtYxc/JYBCkiAIs98qYglgiULGYpJOCGmpv/QaOf2gRWJM912xU3UVIlhW8QOcnJt6ZYIil4W+Lg= X-Received: by 2002:a05:622a:130e:: with SMTP id v14mr10542855qtk.458.1638403121278; Wed, 01 Dec 2021 15:58:41 -0800 (PST) MIME-Version: 1.0 References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-3-yunfei.dong@mediatek.com> In-Reply-To: From: Steve Cho Date: Wed, 1 Dec 2021 15:58:30 -0800 Message-ID: Subject: Re: [PATCH v11, 02/19] media: mtk-vcodec: Align vcodec wake up interrupt interface To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_155852_780921_E0C9D280 X-CRM114-Status: GOOD ( 22.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reviewed-by: Steve Cho On Wed, Dec 1, 2021 at 3:55 PM Steve Cho wrote: > > LGTM. > > On Sun, Nov 28, 2021 at 7:44 PM Yunfei Dong wrote: > > > > Vdec and venc can use the same function to wake up interrupt event. > > > > Reviewed-by: Tzung-Bi Shih > > Reviewed-by: AngeloGioacchino Del Regno > > Signed-off-by: Yunfei Dong > > --- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 9 +-------- > > drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++++++++ > > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 -------- > > 3 files changed, 9 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 59caf2163349..055d50e52720 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -31,13 +31,6 @@ > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > -{ > > - ctx->int_cond = 1; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -69,7 +62,7 @@ static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > writel((readl(vdec_misc_addr) & ~VDEC_IRQ_CLR), > > dev->reg_base[VDEC_MISC] + VDEC_IRQ_CFG_REG); > > > > - wake_up_ctx(ctx); > > + wake_up_ctx(ctx, MTK_INST_IRQ_RECEIVED); > > Assuming setting up reason doesn't change functionality. > > > > > mtk_v4l2_debug(3, > > "mtk_vcodec_dec_irq_handler :wake up ctx %d, dec_done_status=%x", > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 581522177308..1d2370608d0d 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -473,4 +473,12 @@ static inline struct mtk_vcodec_ctx *ctrl_to_ctx(struct v4l2_ctrl *ctrl) > > return container_of(ctrl->handler, struct mtk_vcodec_ctx, ctrl_hdl); > > } > > > > +/* Wake up context wait_queue */ > > +static inline void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > +{ > > + ctx->int_cond = 1; > > + ctx->int_type = reason; > > + wake_up_interruptible(&ctx->queue); > > +} > > + > > #endif /* _MTK_VCODEC_DRV_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > index eed67394cf46..7c3487fb3498 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c > > @@ -65,14 +65,6 @@ static const struct mtk_video_fmt mtk_video_formats_capture_vp8[] = { > > }, > > }; > > > > -/* Wake up context wait_queue */ > > -static void wake_up_ctx(struct mtk_vcodec_ctx *ctx, unsigned int reason) > > -{ > > - ctx->int_cond = 1; > > - ctx->int_type = reason; > > - wake_up_interruptible(&ctx->queue); > > -} > > - > > static void clean_irq_status(unsigned int irq_status, void __iomem *addr) > > { > > if (irq_status & MTK_VENC_IRQ_STATUS_PAUSE) > > -- > > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel