From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buF2G-0001YX-5N for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:37:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buF2F-00072m-7y for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:37:12 -0400 MIME-Version: 1.0 In-Reply-To: <20161012082254.GA5544@noname.redhat.com> References: <1476171437-11830-1-git-send-email-ashijeetacharya@gmail.com> <20161012082254.GA5544@noname.redhat.com> From: Ashijeet Acharya Date: Wed, 12 Oct 2016 14:07:10 +0530 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: "Richard W.M. Jones" , jcody@redhat.com, Eric Blake , mreitz@redhat.com, armbru@redhat.com, QEMU Developers , qemu-block@nongnu.org On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf wrote: > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben: > Of course, we must be able to build qemu correctly both with ssh enabled > and disabled, so if you can indeed see a (different) build error with > disabled libssh2, that needs to be fixed. I am able to reproduce it when I don't apply Dan's patch with libssh2 enabled. After disabling libssh2, it compiles perfectly because then the SSH driver will get ignored I guess. libssh2 doesn't seem to be the problem. > > But I can't see how that would happen, you don't touch configure and it > already compiled the ssh driver out if libssh2 is disabled. Yes, with libssh2 disabled it builds with no error just like the first output of auto-build shows. So, I think with libssh2 enabled it throws an error (just like second output of auto-build) since Dan's patches are not merged yet. Right? Ashijeet > Kevin