From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1ssv-0005Pd-58 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:35:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1ssu-0005LR-Gw for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:35:09 -0400 MIME-Version: 1.0 In-Reply-To: <20161102103331.GC6182@noname.redhat.com> References: <1477937214-20899-1-git-send-email-ashijeetacharya@gmail.com> <20161102103331.GC6182@noname.redhat.com> From: Ashijeet Acharya Date: Wed, 2 Nov 2016 16:05:07 +0530 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] block/ssh: Fix the regression of unused parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Max Reitz , "Richard W.M. Jones" , jcody@redhat.com, QEMU Developers , qemu-block@nongnu.org On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote: > Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: >> This patch drops the unused parameter "BDRVSSHState" being passed into >> the ssh_config() function and fixes the bug. >> >> Signed-off-by: Ashijeet Acharya > > The patch looks good, but why do claim that this is a bug fix rather > than just a code cleanup? Okay, I will change the commit message and include the commit id in this one too. Ashijeet > > Kevin