From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbdB1UsQ (ORCPT ); Tue, 28 Feb 2017 15:48:16 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:36463 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdB1Uqw (ORCPT ); Tue, 28 Feb 2017 15:46:52 -0500 MIME-Version: 1.0 In-Reply-To: References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> From: Jon Mason Date: Tue, 28 Feb 2017 15:46:50 -0500 Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Hauke Mehrtens , Rob Herring , Mark Rutland , Florian Fainelli , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , bcm-kernel-feedback-list , Jon Mason Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1SKmKPk009276 On Tue, Feb 28, 2017 at 3:43 PM, Rafał Miłecki wrote: > On 28 February 2017 at 21:31, Jon Mason wrote: >> @@ -70,10 +70,19 @@ >> clocks = <&periph_clk>; >> }; >> >> - local-timer@20600 { >> + timer@20600 { > > Is there a reason for this rename? I don't really have preference for > any name, it's just we shouldn't keep renaming this depending of > personal preferences. > > It also doesn't seem like adjusting to any schema: > bcm63138.dtsi uses local-timer@1e600 > bcm-nsp.dtsi uses twd-timer@20600 > berlin2cd.dtsi uses local-timer@ad0600 > berlin2.dtsi uses local-timer@ad0600 > berlin2q.dtsi uses local-timer@ad0600 This was a suggestion from Sergei Shtylyov http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395160.html > >> compatible = "arm,cortex-a9-twd-timer"; >> - reg = <0x20600 0x100>; >> - interrupts = ; >> + reg = <0x20600 0x20>; >> + interrupts = > + IRQ_TYPE_LEVEL_HIGH)>; >> + clocks = <&periph_clk>; >> + }; > > The rest looks OK, thanks! :) > > -- > Rafał From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT Date: Tue, 28 Feb 2017 15:46:50 -0500 Message-ID: References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Mark Rutland , "devicetree@vger.kernel.org" , Florian Fainelli , Jon Mason , Hauke Mehrtens , Linux Kernel Mailing List , Rob Herring , bcm-kernel-feedback-list , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMzo0MyBQTSwgUmFmYcWCIE1pxYJlY2tpIDx6YWplYzVA Z21haWwuY29tPiB3cm90ZToKPiBPbiAyOCBGZWJydWFyeSAyMDE3IGF0IDIxOjMxLCBKb24gTWFz b24gPGpvbi5tYXNvbkBicm9hZGNvbS5jb20+IHdyb3RlOgo+PiBAQCAtNzAsMTAgKzcwLDE5IEBA Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmcGVyaXBoX2Nsaz47Cj4+ICAg ICAgICAgICAgICAgICB9Owo+Pgo+PiAtICAgICAgICAgICAgICAgbG9jYWwtdGltZXJAMjA2MDAg ewo+PiArICAgICAgICAgICAgICAgdGltZXJAMjA2MDAgewo+Cj4gSXMgdGhlcmUgYSByZWFzb24g Zm9yIHRoaXMgcmVuYW1lPyBJIGRvbid0IHJlYWxseSBoYXZlIHByZWZlcmVuY2UgZm9yCj4gYW55 IG5hbWUsIGl0J3MganVzdCB3ZSBzaG91bGRuJ3Qga2VlcCByZW5hbWluZyB0aGlzIGRlcGVuZGlu ZyBvZgo+IHBlcnNvbmFsIHByZWZlcmVuY2VzLgo+Cj4gSXQgYWxzbyBkb2Vzbid0IHNlZW0gbGlr ZSBhZGp1c3RpbmcgdG8gYW55IHNjaGVtYToKPiBiY202MzEzOC5kdHNpIHVzZXMgbG9jYWwtdGlt ZXJAMWU2MDAKPiBiY20tbnNwLmR0c2kgdXNlcyB0d2QtdGltZXJAMjA2MDAKPiBiZXJsaW4yY2Qu ZHRzaSB1c2VzIGxvY2FsLXRpbWVyQGFkMDYwMAo+IGJlcmxpbjIuZHRzaSB1c2VzIGxvY2FsLXRp bWVyQGFkMDYwMAo+IGJlcmxpbjJxLmR0c2kgdXNlcyBsb2NhbC10aW1lckBhZDA2MDAKClRoaXMg d2FzIGEgc3VnZ2VzdGlvbiBmcm9tIFNlcmdlaSBTaHR5bHlvdgpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9waXBlcm1haWwvbGludXgtYXJtLWtlcm5lbC8yMDE1LURlY2VtYmVyLzM5NTE2MC5o dG1sCgoKPgo+PiAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImFybSxjb3J0 ZXgtYTktdHdkLXRpbWVyIjsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MjA2 MDAgMHgxMDA+Owo+PiAtICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0gPEdJQ19Q UEkgMTMgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHJl ZyA9IDwweDIwNjAwIDB4MjA+Owo+PiArICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRz ID0gPEdJQ19QUEkgMTMgKEdJQ19DUFVfTUFTS19TSU1QTEUoMikgfAo+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElSUV9UWVBFX0xFVkVMX0hJR0gp PjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0gPCZwZXJpcGhfY2xrPjsKPj4g KyAgICAgICAgICAgICAgIH07Cj4KPiBUaGUgcmVzdCBsb29rcyBPSywgdGhhbmtzISA6KQo+Cj4g LS0KPiBSYWZhxYIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jon.mason@broadcom.com (Jon Mason) Date: Tue, 28 Feb 2017 15:46:50 -0500 Subject: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT In-Reply-To: References: <1488313886-17155-1-git-send-email-jon.mason@broadcom.com> <1488313886-17155-2-git-send-email-jon.mason@broadcom.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 28, 2017 at 3:43 PM, Rafa? Mi?ecki wrote: > On 28 February 2017 at 21:31, Jon Mason wrote: >> @@ -70,10 +70,19 @@ >> clocks = <&periph_clk>; >> }; >> >> - local-timer at 20600 { >> + timer at 20600 { > > Is there a reason for this rename? I don't really have preference for > any name, it's just we shouldn't keep renaming this depending of > personal preferences. > > It also doesn't seem like adjusting to any schema: > bcm63138.dtsi uses local-timer at 1e600 > bcm-nsp.dtsi uses twd-timer at 20600 > berlin2cd.dtsi uses local-timer at ad0600 > berlin2.dtsi uses local-timer at ad0600 > berlin2q.dtsi uses local-timer at ad0600 This was a suggestion from Sergei Shtylyov http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395160.html > >> compatible = "arm,cortex-a9-twd-timer"; >> - reg = <0x20600 0x100>; >> - interrupts = ; >> + reg = <0x20600 0x20>; >> + interrupts = > + IRQ_TYPE_LEVEL_HIGH)>; >> + clocks = <&periph_clk>; >> + }; > > The rest looks OK, thanks! :) > > -- > Rafa?