From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akinobu Mita Subject: Re: [PATCH v14 6/9] added support for DesignWare Controller Date: Wed, 13 Apr 2016 21:19:19 +0900 Message-ID: References: <75cb43b16231f67d1e94e174a45ad6ffc68e1df6.1459448160.git.jpinto@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-vk0-f53.google.com ([209.85.213.53]:36279 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbcDMMTU (ORCPT ); Wed, 13 Apr 2016 08:19:20 -0400 Received: by mail-vk0-f53.google.com with SMTP id c4so66376490vkb.3 for ; Wed, 13 Apr 2016 05:19:20 -0700 (PDT) In-Reply-To: <75cb43b16231f67d1e94e174a45ad6ffc68e1df6.1459448160.git.jpinto@synopsys.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Joao Pinto Cc: "linux-scsi@vger.kernel.org" Hi Joao, 2016-04-13 18:04 GMT+09:00 Joao Pinto : > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index e3931d0..c780d14 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -263,6 +263,7 @@ struct ufs_pwr_mode_info { > * @suspend: called during host controller PM callback > * @resume: called during host controller PM callback > * @dbg_register_dump: used to dump controller debug information > + * @phy_initialization: used to initialize phys > */ > struct ufs_hba_variant_ops { > const char *name; > @@ -284,6 +285,7 @@ struct ufs_hba_variant_ops { > int (*suspend)(struct ufs_hba *, enum ufs_pm_op); > int (*resume)(struct ufs_hba *, enum ufs_pm_op); > void (*dbg_register_dump)(struct ufs_hba *hba); > + int (*phy_initialization)(struct ufs_hba *); > }; This vops->phy_initialization is only called from ufs dwc specific source files and not called from ufs core. So this should not belong to ufs_hba_variant_ops. You can use hba->priv to put the controller specific data structure including phy_initialization and you also need to define vops->init callback which allocates and initialize the data structure.