From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni@dodonov.net>
Subject: Re: [PATCH 17/29] drm/i915: enable power wells on
	haswell init
Date: Fri, 13 Apr 2012 22:26:49 -0300
Message-ID: <CAC7Lmnsc00XFoPen18x_cn-WQwG=rnCAxPC9pAGhn1Vy-M0FwA@mail.gmail.com>
References: <1334347745-11743-1-git-send-email-eugeni.dodonov@intel.com>
	<1334347745-11743-18-git-send-email-eugeni.dodonov@intel.com>
	<1334351023_415839@CP5-2952>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1583552841=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-yx0-f177.google.com (mail-yx0-f177.google.com
	[209.85.213.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3106E9EB45
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 13 Apr 2012 18:27:31 -0700 (PDT)
Received: by yenm10 with SMTP id m10so2188616yen.36
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 13 Apr 2012 18:27:30 -0700 (PDT)
In-Reply-To: <1334351023_415839@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

--===============1583552841==
Content-Type: multipart/alternative; boundary=20cf304273fe23a42904bd997e15

--20cf304273fe23a42904bd997e15
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Apr 13, 2012 at 18:03, Chris Wilson <chris@chris-wilson.co.uk>wrote:

> On Fri, 13 Apr 2012 17:08:53 -0300, Eugeni Dodonov <
> eugeni.dodonov@intel.com> wrote:
> >  void intel_modeset_init(struct drm_device *dev)
> >  {
> >       struct drm_i915_private *dev_priv = dev->dev_private;
> > @@ -9652,6 +9680,9 @@ void intel_modeset_init(struct drm_device *dev)
> >
> >       intel_init_quirks(dev);
> >
> > +     if (IS_HASWELL(dev))
> > +             intel_init_power_wells(dev);
> > +
>
> Perform the gen checks in intel_init_power_wells() so that we keep the
> initialisation sequence readable.
>

Yes, makes total sense, I'll do this.

Thanks!

-- 
Eugeni Dodonov
 <http://eugeni.dodonov.net/>

--20cf304273fe23a42904bd997e15
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Fri, Apr 13, 2012 at 18:03, Chris Wilson <spa=
n dir=3D"ltr">&lt;<a href=3D"mailto:chris@chris-wilson.co.uk">chris@chris-w=
ilson.co.uk</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class=3D"im">On Fri, 13 Apr 2012 17:08:53 -0300, Eugeni Dodonov &lt;<a=
 href=3D"mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>&gt; =
wrote:<br>
&gt; =A0void intel_modeset_init(struct drm_device *dev)<br>
&gt; =A0{<br>
&gt; =A0 =A0 =A0 struct drm_i915_private *dev_priv =3D dev-&gt;dev_private;=
<br>
&gt; @@ -9652,6 +9680,9 @@ void intel_modeset_init(struct drm_device *dev)<=
br>
&gt;<br>
&gt; =A0 =A0 =A0 intel_init_quirks(dev);<br>
&gt;<br>
&gt; + =A0 =A0 if (IS_HASWELL(dev))<br>
&gt; + =A0 =A0 =A0 =A0 =A0 =A0 intel_init_power_wells(dev);<br>
&gt; +<br>
<br>
</div>Perform the gen checks in intel_init_power_wells() so that we keep th=
e<br>
initialisation sequence readable.<br></blockquote><div><br></div><div>Yes, =
makes total sense, I&#39;ll do this.</div><div><br></div><div>Thanks!</div>=
<div><br></div></div>-- <br>Eugeni Dodonov<a href=3D"http://eugeni.dodonov.=
net/" target=3D"_blank"><br>

</a><br>

--20cf304273fe23a42904bd997e15--

--===============1583552841==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1583552841==--