On Tue, Apr 17, 2012 at 07:12, Daniel Vetter <daniel@ffwll.ch> wrote:
On Fri, Apr 13, 2012 at 05:08:39PM -0300, Eugeni Dodonov wrote:
> Haswell has different DIP control registers and offsets.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

I've read a bit through Bspec wrt dip writing and it looks like hsw is
rather differen from previous chips:
- with have a data reg for every type of dip
- the bits in the ctl reg moved around completely

... so I guess this patch and the follow-on one are pretty bogus. One
thing I've noticed is that intel_infoframe_index and intel_infoframe_flags
have way too generic names, they're only useful to frob the dip ctl reg on
pre-hsw afaics. I think we should rename them to i9xx_infoframe_ctl_inde
and _flags or something similar.

Yep, I only did the minimally-required stuff to have HDMI output, so the ones willing to use Haswell could have anything on their screen besides 'No Signal' :).

But yes, those patches should receive more care for full hdmi and DIP support going forward.

--
Eugeni Dodonov