From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni@dodonov.net>
Subject: Re: [PATCH] drm/i915: create macros to handle masked
	bits
Date: Tue, 24 Apr 2012 10:46:44 -0300
Message-ID: <CAC7LmnuA1vvDMGpTM8vM4HDR_1_0R6s=dJ=t=N5uwxWpWhu7tA@mail.gmail.com>
References: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch>
	<1335273904_37656@CP5-2952>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1658410729=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-yw0-f49.google.com (mail-yw0-f49.google.com
	[209.85.213.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1A9F2A0A3B
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Apr 2012 06:47:25 -0700 (PDT)
Received: by yhjj52 with SMTP id j52so361062yhj.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 24 Apr 2012 06:47:24 -0700 (PDT)
In-Reply-To: <1335273904_37656@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

--===============1658410729==
Content-Type: multipart/alternative; boundary=20cf305e252f9f86a104be6cfebf

--20cf305e252f9f86a104be6cfebf
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Apr 24, 2012 at 10:24, Chris Wilson <chris@chris-wilson.co.uk>wrote:

> On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter <daniel.vetter@ffwll.ch>
> wrote:
> > ... and put them to so good use.
> >
> > Note that there's functional change in vlv clock gating code, we now
> > no longer spuriously read back the current value of the bit. According
> > to Bspec the high bits should always read zeror, so ORing this in
> s/zeror/zero/
> > should have no effect.
> >
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> The transforms here look fine, just a moment of concern for not
> repeating the MODE twiddling in init_render_ring after reset.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>

--20cf305e252f9f86a104be6cfebf
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Tue, Apr 24, 2012 at 10:24, Chris Wilson <spa=
n dir=3D"ltr">&lt;<a href=3D"mailto:chris@chris-wilson.co.uk">chris@chris-w=
ilson.co.uk</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class=3D"im">On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter &lt;<a =
href=3D"mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>&gt; wrote=
:<br>
&gt; ... and put them to so good use.<br>
&gt;<br>
&gt; Note that there&#39;s functional change in vlv clock gating code, we n=
ow<br>
&gt; no longer spuriously read back the current value of the bit. According=
<br>
&gt; to Bspec the high bits should always read zeror, so ORing this in<br>
</div>s/zeror/zero/<br>
<div class=3D"im">&gt; should have no effect.<br>
&gt;<br>
&gt; Cc: Jesse Barnes &lt;<a href=3D"mailto:jbarnes@virtuousgeek.org">jbarn=
es@virtuousgeek.org</a>&gt;<br>
&gt; Signed-Off-by: Daniel Vetter &lt;<a href=3D"mailto:daniel.vetter@ffwll=
.ch">daniel.vetter@ffwll.ch</a>&gt;<br>
<br>
</div>The transforms here look fine, just a moment of concern for not<br>
repeating the MODE twiddling in init_render_ring after reset.<br>
<br>
Reviewed-by: Chris Wilson &lt;<a href=3D"mailto:chris@chris-wilson.co.uk">c=
hris@chris-wilson.co.uk</a>&gt;<br></blockquote><div><br></div><div>Reviewe=
d-by: Eugeni Dodonov &lt;<a href=3D"mailto:eugeni.dodonov@intel.com">eugeni=
.dodonov@intel.com</a>&gt;</div>

<div><br></div></div>-- <br>Eugeni Dodonov<a href=3D"http://eugeni.dodonov.=
net/" target=3D"_blank"><br></a><br>

--20cf305e252f9f86a104be6cfebf--

--===============1658410729==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1658410729==--