On Mon, Apr 30, 2012 at 21:27, Jesse Barnes wrote: > We really really need to get the port detection working on HSW using > the VBT. > It is not that easy from what I've seen. VBT can give some hints on which ports can support only DP or HDMI, but it does not answers all the cases. So the best solution seems to be running a DP AUX query when we got an output, and if it succeeds - it is a DP; otherwise, it is HDMI. So my idea here is: - add both HDMI and DP connectors for each available port (those we can get via VBT and from the GPU variant - some variants don't have specific DDIs in hardware, and VBT can further say which DDI are incapable of driving HDMI when present) - add an intel_ddi_detect routine for .detect of each of them - the intel_ddi_detect would try doing the DP AUX test, and dispatch either intel_hdmi_detect or intel_dp_detect accordingly. Once the DP code will be ready, we'll put this in place. But for now, only HDMI works anyway, and I don't have any DP monitor around to play with :). Does this looks reasonable? -- Eugeni Dodonov