From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 19/24] drm/i915: detect digital outputs on Haswell Date: Mon, 30 Apr 2012 21:33:42 -0300 Message-ID: References: <1335464479-648-1-git-send-email-eugeni.dodonov@intel.com> <1335464479-648-20-git-send-email-eugeni.dodonov@intel.com> <20120430172750.2f3340f3@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0177927365==" Return-path: Received: from mail-yw0-f49.google.com (mail-yw0-f49.google.com [209.85.213.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 7769E9EB4E for ; Mon, 30 Apr 2012 17:34:22 -0700 (PDT) Received: by yhjj52 with SMTP id j52so1893227yhj.36 for ; Mon, 30 Apr 2012 17:34:22 -0700 (PDT) In-Reply-To: <20120430172750.2f3340f3@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org --===============0177927365== Content-Type: multipart/alternative; boundary=20cf300fad3b62946d04beeebb7d --20cf300fad3b62946d04beeebb7d Content-Type: text/plain; charset=ISO-8859-1 On Mon, Apr 30, 2012 at 21:27, Jesse Barnes wrote: > We really really need to get the port detection working on HSW using > the VBT. > It is not that easy from what I've seen. VBT can give some hints on which ports can support only DP or HDMI, but it does not answers all the cases. So the best solution seems to be running a DP AUX query when we got an output, and if it succeeds - it is a DP; otherwise, it is HDMI. So my idea here is: - add both HDMI and DP connectors for each available port (those we can get via VBT and from the GPU variant - some variants don't have specific DDIs in hardware, and VBT can further say which DDI are incapable of driving HDMI when present) - add an intel_ddi_detect routine for .detect of each of them - the intel_ddi_detect would try doing the DP AUX test, and dispatch either intel_hdmi_detect or intel_dp_detect accordingly. Once the DP code will be ready, we'll put this in place. But for now, only HDMI works anyway, and I don't have any DP monitor around to play with :). Does this looks reasonable? -- Eugeni Dodonov --20cf300fad3b62946d04beeebb7d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Mon, Apr 30, 2012 at 21:27, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
We really really need to get the po= rt detection working on HSW using
the VBT.

It is not that easy from what = I've seen. VBT can give some hints on which ports can support only DP o= r HDMI, but it does not answers all the cases. So the best solution seems t= o be running a DP AUX query when we got an output, and if it succeeds - it = is a DP; otherwise, it is HDMI.

So my idea here is:
=A0- add both HDMI and DP= connectors for each available port (those we can get via VBT and from the = GPU variant - some variants don't have specific DDIs in hardware, and V= BT can further say which DDI are incapable of driving HDMI when present)
=A0- add an intel_ddi_detect routine for .detect of each of them
=
=A0- the intel_ddi_detect would try doing the DP AUX test, and dispatc= h either intel_hdmi_detect or intel_dp_detect accordingly.

Once the DP code will be ready, we'll put this in place. But for n= ow, only HDMI works anyway, and I don't have any DP monitor around to p= lay with :).

Does this looks reasonable?

--
Eugeni Dodonov

--20cf300fad3b62946d04beeebb7d-- --===============0177927365== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0177927365==--