On Tue, Apr 17, 2012 at 07:49, Daniel Vetter <daniel@ffwll.ch> wrote:
On Fri, Apr 13, 2012 at 05:08:36PM -0300, Eugeni Dodonov wrote:
> Hi forks,
>
> Just in time for everyone's weekend, here comes the 3rd round of patches on
> Haswell.
>
> As major highlights, it also adds support for HDMI/DVI outputs and multi-head
> modes (I tried with VGA and HDMI).
>
> Other than that, it is the same patches with comments from the past round
> addressed (SBI locking support, proper WM calculation, better PCH items
> detection, and so on).
>
> Daniel, I think that the bits definitions, power wells, clocks programming, and
> modesetting for both FDI and HDMI modes should be good to go unless someone
> spots additional issues with them - so please, all of you who have something to
> say about them, say it now and bikeshed as you please :).

I've picked up a few more patches I couldn't find anything to bikeshed
about, the others grew some comments. I haven't looked too hard at the
actual modeset stuff given that you're already really busy reworking
things and moving stuff to intel_ddi.c

...and into intel_pm.c as well when those patches land :).

At least the power wells-related part is much more welcome there.

So I'll address the bikeshedding^w comments on the remaining patches and will resend them when intel_pm.c stuff lands.

--
Eugeni Dodonov