From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni@dodonov.net>
Subject: Re: [PATCH 00/29] Haswell round 3
Date: Tue, 17 Apr 2012 08:58:13 -0300
Message-ID: <CAC7LmnvTW0ZUDw=xY3hFUhHN5YE6=G-vTgORsTaLuJsjjqN3rw@mail.gmail.com>
References: <1334347745-11743-1-git-send-email-eugeni.dodonov@intel.com>
	<20120417104950.GK4104@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1743281320=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-gy0-f177.google.com (mail-gy0-f177.google.com
	[209.85.160.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id B73599E8CE
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Apr 2012 04:58:53 -0700 (PDT)
Received: by ghbf11 with SMTP id f11so3283196ghb.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 17 Apr 2012 04:58:53 -0700 (PDT)
In-Reply-To: <20120417104950.GK4104@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

--===============1743281320==
Content-Type: multipart/alternative; boundary=20cf303ddb90a333b204bddea9f4

--20cf303ddb90a333b204bddea9f4
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Apr 17, 2012 at 07:49, Daniel Vetter <daniel@ffwll.ch> wrote:

> On Fri, Apr 13, 2012 at 05:08:36PM -0300, Eugeni Dodonov wrote:
> > Hi forks,
> >
> > Just in time for everyone's weekend, here comes the 3rd round of patches
> on
> > Haswell.
> >
> > As major highlights, it also adds support for HDMI/DVI outputs and
> multi-head
> > modes (I tried with VGA and HDMI).
> >
> > Other than that, it is the same patches with comments from the past round
> > addressed (SBI locking support, proper WM calculation, better PCH items
> > detection, and so on).
> >
> > Daniel, I think that the bits definitions, power wells, clocks
> programming, and
> > modesetting for both FDI and HDMI modes should be good to go unless
> someone
> > spots additional issues with them - so please, all of you who have
> something to
> > say about them, say it now and bikeshed as you please :).
>
> I've picked up a few more patches I couldn't find anything to bikeshed
> about, the others grew some comments. I haven't looked too hard at the
> actual modeset stuff given that you're already really busy reworking
> things and moving stuff to intel_ddi.c
>

...and into intel_pm.c as well when those patches land :).

At least the power wells-related part is much more welcome there.

So I'll address the bikeshedding^w comments on the remaining patches and
will resend them when intel_pm.c stuff lands.

-- 
Eugeni Dodonov
 <http://eugeni.dodonov.net/>

--20cf303ddb90a333b204bddea9f4
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Tue, Apr 17, 2012 at 07:49, Daniel Vetter <sp=
an dir=3D"ltr">&lt;<a href=3D"mailto:daniel@ffwll.ch">daniel@ffwll.ch</a>&g=
t;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class=3D"im">On Fri, Apr 13, 2012 at 05:08:36PM -0300, Eugeni Dodonov =
wrote:<br>
&gt; Hi forks,<br>
&gt;<br>
&gt; Just in time for everyone&#39;s weekend, here comes the 3rd round of p=
atches on<br>
&gt; Haswell.<br>
&gt;<br>
&gt; As major highlights, it also adds support for HDMI/DVI outputs and mul=
ti-head<br>
&gt; modes (I tried with VGA and HDMI).<br>
&gt;<br>
&gt; Other than that, it is the same patches with comments from the past ro=
und<br>
&gt; addressed (SBI locking support, proper WM calculation, better PCH item=
s<br>
&gt; detection, and so on).<br>
&gt;<br>
&gt; Daniel, I think that the bits definitions, power wells, clocks program=
ming, and<br>
&gt; modesetting for both FDI and HDMI modes should be good to go unless so=
meone<br>
&gt; spots additional issues with them - so please, all of you who have som=
ething to<br>
&gt; say about them, say it now and bikeshed as you please :).<br>
<br>
</div>I&#39;ve picked up a few more patches I couldn&#39;t find anything to=
 bikeshed<br>
about, the others grew some comments. I haven&#39;t looked too hard at the<=
br>
actual modeset stuff given that you&#39;re already really busy reworking<br=
>
things and moving stuff to intel_ddi.c<br></blockquote><div><br></div><div>=
...and into intel_pm.c as well when those patches land :).</div><div><br></=
div><div>At least the power wells-related part is much more welcome there.<=
/div>

<div><br></div><div>So I&#39;ll address the bikeshedding^w comments on the =
remaining patches and will resend them when intel_pm.c stuff lands.</div><d=
iv><br></div></div>-- <br>Eugeni Dodonov<a href=3D"http://eugeni.dodonov.ne=
t/" target=3D"_blank"><br>

</a><br>

--20cf303ddb90a333b204bddea9f4--

--===============1743281320==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1743281320==--