From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni@dodonov.net>
Subject: Re: [PATCH 15/24] drm/i915: initialize DDI buffer
	translations
Date: Mon, 30 Apr 2012 21:27:05 -0300
Message-ID: <CAC7Lmnvwrko7Xu7pJezGmAOrRt52uvRjD-+Oi7tNQh8=ki5fwQ@mail.gmail.com>
References: <1335464479-648-1-git-send-email-eugeni.dodonov@intel.com>
	<1335464479-648-16-git-send-email-eugeni.dodonov@intel.com>
	<20120430172018.639e57a8@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0156478007=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-yx0-f177.google.com (mail-yx0-f177.google.com
	[209.85.213.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 940CA9EB4E
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 30 Apr 2012 17:27:45 -0700 (PDT)
Received: by yenm7 with SMTP id m7so14001yen.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 30 Apr 2012 17:27:45 -0700 (PDT)
In-Reply-To: <20120430172018.639e57a8@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

--===============0156478007==
Content-Type: multipart/alternative; boundary=20cf3040e36cbb175e04beeea343

--20cf3040e36cbb175e04beeea343
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Apr 30, 2012 at 21:20, Jesse Barnes <jbarnes@virtuousgeek.org>wrote:

> Ahh these are vswing and preemphasis values for the various types...
>
> Doesn't look like this goes up to the 19 dwords the docs specify?
>

The last pair is for HDMI, it is ignored for FDI/DP, so I write it along
with all others to already prepare DDI to work in any mode.


> Usually, double buffered means we need to write a trigger reg somewhere
> for the values to be latched in, or wait for vblank.  What's different
> here?
>

I'll double-check, it could be possible that they don't need to be
double-buffered. In the first series I split the double-buffering part
(with a delay) into a separate patch as it made things work more reliable
on my machine, but it got merged when I moved everything to intel_ddi.c.

FDI is not yet stable enough, so I need to find if the issues I was having
with it are due to that, or we really need the double-writing.

-- 
Eugeni Dodonov
 <http://eugeni.dodonov.net/>

--20cf3040e36cbb175e04beeea343
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Mon, Apr 30, 2012 at 21:20, Jesse Barnes <spa=
n dir=3D"ltr">&lt;<a href=3D"mailto:jbarnes@virtuousgeek.org" target=3D"_bl=
ank">jbarnes@virtuousgeek.org</a>&gt;</span> wrote:<br><blockquote class=3D=
"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex">

<div class=3D"HOEnZb"><div class=3D"h5">Ahh these are vswing and preemphasi=
s values for the various types...</div></div>
<br>
Doesn&#39;t look like this goes up to the 19 dwords the docs specify?<br></=
blockquote><div><br></div><div>The last pair is for HDMI, it is ignored for=
 FDI/DP, so I write it along with all others to already prepare DDI to work=
 in any mode.</div>

<div>=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">Usually, double buffered means=
 we need to write a trigger reg somewhere<br>
for the values to be latched in, or wait for vblank. =A0What&#39;s differen=
t<br>
here?<br></blockquote><div><br></div><div>I&#39;ll double-check, it could b=
e possible that they don&#39;t need to be double-buffered. In the first ser=
ies I split the double-buffering part (with a delay) into a separate patch =
as it made things work more reliable on my machine, but it got merged when =
I moved everything to intel_ddi.c.</div>

<div>=A0</div><div>FDI is not yet stable enough, so I need to find if the i=
ssues I was having with it are due to that, or we really need the double-wr=
iting.</div></div><div><br></div>-- <br>Eugeni Dodonov<a href=3D"http://eug=
eni.dodonov.net/" target=3D"_blank"><br>

</a><br>

--20cf3040e36cbb175e04beeea343--

--===============0156478007==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0156478007==--