From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D92C43382 for ; Wed, 26 Sep 2018 15:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D89E21529 for ; Wed, 26 Sep 2018 15:59:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=g.ncu.edu.tw header.i=@g.ncu.edu.tw header.b="WYjCYwJA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D89E21529 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=g.ncu.edu.tw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728562AbeIZWNG (ORCPT ); Wed, 26 Sep 2018 18:13:06 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:39361 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728492AbeIZWNF (ORCPT ); Wed, 26 Sep 2018 18:13:05 -0400 Received: by mail-oi1-f194.google.com with SMTP id y81-v6so4831367oia.6 for ; Wed, 26 Sep 2018 08:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=g.ncu.edu.tw; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mQcZ8j5UhwURpGkMn96KJZDe+STDgUlhnYmoyLS8St0=; b=WYjCYwJAEwTxGJODEnU9qeGpv//4UNecmgyVMYAHe7UC8KNEBiVtRgyPK8q4T7vWo3 lKSNjVYHXKYpyPI/ZvT0YDisogmdpgrNsegP7jZH27A2nzS4rokGF+sCS5d/eMKP8A/e TO/LD2tiyIPR1vac/JXmAOLay5YE8azvjHVn0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mQcZ8j5UhwURpGkMn96KJZDe+STDgUlhnYmoyLS8St0=; b=JRsK6kiFV+BI4qX6hOL+eS7EwY6fYu41Q5Eo7WiTs5+VjecQpCfth/iZSbycboDfK+ omTaX3YKJ/MHQoLFp53bkYnARXuO/SLQwyf+gEWn4D5KeJJ1zJ932V5MC0vQBHk3tSgs F7tlw3iTPCA80UDPrEP1ZI7OEi1APbugr8HSfH5ptWwPAlkAwClHAEIEd2xwPkLQwq/q mqb4zlfCou26sFEqQAKUM8LGhKuMcxjmLhYrSfGNPaL3H0XSyz7fLO2SsspX3o1aBuXQ aorcA/jxkJVb5dsxDTqEQxm3KpJNS0kWL5uO9/Z41kVXl2IoQl9EA5RLjkeiACGbHDxU BXfg== X-Gm-Message-State: ABuFfojOAsN/d5CdP+/Fjn1yCmOLWwwp3uqLTPC3ThJS/er9zY03mlSG n5W7ecH+ByiX1rpbyEiK9mUU3Q== X-Google-Smtp-Source: ACcGV60wc/bDFebGcbkE0L1hemn9RGjJLV3P/spC8Mre3bD3HtdkxSYrJi3euAj7OdidxgkwdxNiNA== X-Received: by 2002:aca:cc04:: with SMTP id c4-v6mr939081oig.314.1537977568879; Wed, 26 Sep 2018 08:59:28 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id o206-v6sm1871453oif.7.2018.09.26.08.59.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Sep 2018 08:59:28 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id j9-v6so28713721otl.2; Wed, 26 Sep 2018 08:59:28 -0700 (PDT) X-Received: by 2002:a9d:439b:: with SMTP id t27-v6mr4798352ote.142.1537977175406; Wed, 26 Sep 2018 08:52:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jian-Hong Pan Date: Wed, 26 Sep 2018 23:52:50 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 1/3 net] lorawan: Add LoRaWAN class module To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: netdev@vger.kernel.org, ", "linux-kernel@vger.kernel.org>," , Jiri Pirko , Marcel Holtmann , "David S. Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=C3=B6der?= , Dollar Chen , Ken Yu , =?UTF-8?Q?Konstantin_B=C3=B6hm?= , Jan Jongboom , Jon Ortego , "linux-kernel@vger.kernel.org>," , Ben Whitten , Brian Ray , lora@globalsat.com.tw, Alexander Graf , =?UTF-8?Q?Michal_Kube=C4=8Dek?= , Rob Herring , devicetree@vger.kernel.org, Steve deRosier , Mark Brown , linux-spi@vger.kernel.org, Pieter ROBYNS , Hasnain Virk , linux-wpan - ML , Stefan Schmidt , Daniele Comel , shess@hessware.de, Xue Liu , fomi@rakwireless.com, afonsobordado@az8.co Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andreas F=C3=A4rber =E6=96=BC 2018=E5=B9=B49=E6=9C=8824= =E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8812:40=E5=AF=AB=E9=81=93=EF= =BC=9A > > Hi Jian-Hong, > > [+ Afonso] > > Am 23.08.18 um 19:15 schrieb Jian-Hong Pan: > > LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices= . > > > > This patch implements part of Class A end-devices features defined in > > LoRaWAN(TM) Specification Ver. 1.0.2: > > 1. End-device receive slot timing > > 2. Only single channel and single data rate for now > > 3. Unconfirmed data up/down message types > > 4. Encryption/decryption for up/down link data messages > > > > It also implements the the functions and maps to Datagram socket for > > LoRaWAN unconfirmed data messages. > > > > On the other side, it defines the basic interface and operation > > functions for compatible LoRa device drivers. > > > > Signed-off-by: Jian-Hong Pan > > --- > > include/linux/maclorawan/lora.h | 239 +++++++++++ > > net/maclorawan/Kconfig | 14 + > > net/maclorawan/Makefile | 2 + > > net/maclorawan/lorawan.h | 219 ++++++++++ > > net/maclorawan/lrwsec.c | 237 +++++++++++ > > net/maclorawan/lrwsec.h | 57 +++ > > net/maclorawan/mac.c | 552 +++++++++++++++++++++++++ > > net/maclorawan/main.c | 665 ++++++++++++++++++++++++++++++ > > net/maclorawan/socket.c | 700 ++++++++++++++++++++++++++++++++ > > 9 files changed, 2685 insertions(+) > > create mode 100644 include/linux/maclorawan/lora.h > > Can we use include/linux/lora/lorawan.h for simplicity? Technically, yes > > create mode 100644 net/maclorawan/Kconfig > > create mode 100644 net/maclorawan/Makefile > > create mode 100644 net/maclorawan/lorawan.h > > create mode 100644 net/maclorawan/lrwsec.c > > create mode 100644 net/maclorawan/lrwsec.h > > create mode 100644 net/maclorawan/mac.c > > create mode 100644 net/maclorawan/main.c > > create mode 100644 net/maclorawan/socket.c > > This patch is much too large for me to review... > > It also doesn't seem to follow the structure I suggested: 802.15.4 has > two separate directories, net/ieee802154/ and net/mac802154/. Therefore > I had suggested net/maclorawan/ only for code that translates from > ETH_P_LORAWAN to ETH_P_LORA socket buffers, i.e. your soft MAC. Generic > socket code that applies also to hard MAC drivers I expected to go > either to net/lora/lorawan/ or better net/lorawan/ or some other clearly > separate location, with its own Kconfig symbol - any reason not to? > Consider which parts can be enabled/used independently of each other, > then you can put them into two (or more?) different patches. Maybe I misunderstood before. Besides, the header files need to be split for different paths or folders. Anyway, I will try to separate it into parts in version 2 patches. > Also please use SPDX license identifiers in your headers. > And please don't put the whole world in To, use CC. Regards, Jian-Hong Pan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jian-Hong Pan Subject: Re: [RFC 1/3 net] lorawan: Add LoRaWAN class module Date: Wed, 26 Sep 2018 23:52:50 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, ", "linux-kernel@vger.kernel.org>," , Jiri Pirko , Marcel Holtmann , "David S. Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=C3=B6der?= , Dollar Chen , Ken Yu , =?UTF-8?Q?Konstantin_B=C3=B6hm?= , Jan Jongboom , Jon Ortego , "linux-kernel@vger.kernel.org>," , Ben Whitten , Brian Ray , lora@g To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Return-path: Received: from mail-oi1-f196.google.com ([209.85.167.196]:37518 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728556AbeIZWNF (ORCPT ); Wed, 26 Sep 2018 18:13:05 -0400 Received: by mail-oi1-f196.google.com with SMTP id n1-v6so4833444oic.4 for ; Wed, 26 Sep 2018 08:59:29 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Andreas F=C3=A4rber =E6=96=BC 2018=E5=B9=B49=E6=9C=8824= =E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8812:40=E5=AF=AB=E9=81=93=EF= =BC=9A > > Hi Jian-Hong, > > [+ Afonso] > > Am 23.08.18 um 19:15 schrieb Jian-Hong Pan: > > LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices= . > > > > This patch implements part of Class A end-devices features defined in > > LoRaWAN(TM) Specification Ver. 1.0.2: > > 1. End-device receive slot timing > > 2. Only single channel and single data rate for now > > 3. Unconfirmed data up/down message types > > 4. Encryption/decryption for up/down link data messages > > > > It also implements the the functions and maps to Datagram socket for > > LoRaWAN unconfirmed data messages. > > > > On the other side, it defines the basic interface and operation > > functions for compatible LoRa device drivers. > > > > Signed-off-by: Jian-Hong Pan > > --- > > include/linux/maclorawan/lora.h | 239 +++++++++++ > > net/maclorawan/Kconfig | 14 + > > net/maclorawan/Makefile | 2 + > > net/maclorawan/lorawan.h | 219 ++++++++++ > > net/maclorawan/lrwsec.c | 237 +++++++++++ > > net/maclorawan/lrwsec.h | 57 +++ > > net/maclorawan/mac.c | 552 +++++++++++++++++++++++++ > > net/maclorawan/main.c | 665 ++++++++++++++++++++++++++++++ > > net/maclorawan/socket.c | 700 ++++++++++++++++++++++++++++++++ > > 9 files changed, 2685 insertions(+) > > create mode 100644 include/linux/maclorawan/lora.h > > Can we use include/linux/lora/lorawan.h for simplicity? Technically, yes > > create mode 100644 net/maclorawan/Kconfig > > create mode 100644 net/maclorawan/Makefile > > create mode 100644 net/maclorawan/lorawan.h > > create mode 100644 net/maclorawan/lrwsec.c > > create mode 100644 net/maclorawan/lrwsec.h > > create mode 100644 net/maclorawan/mac.c > > create mode 100644 net/maclorawan/main.c > > create mode 100644 net/maclorawan/socket.c > > This patch is much too large for me to review... > > It also doesn't seem to follow the structure I suggested: 802.15.4 has > two separate directories, net/ieee802154/ and net/mac802154/. Therefore > I had suggested net/maclorawan/ only for code that translates from > ETH_P_LORAWAN to ETH_P_LORA socket buffers, i.e. your soft MAC. Generic > socket code that applies also to hard MAC drivers I expected to go > either to net/lora/lorawan/ or better net/lorawan/ or some other clearly > separate location, with its own Kconfig symbol - any reason not to? > Consider which parts can be enabled/used independently of each other, > then you can put them into two (or more?) different patches. Maybe I misunderstood before. Besides, the header files need to be split for different paths or folders. Anyway, I will try to separate it into parts in version 2 patches. > Also please use SPDX license identifiers in your headers. > And please don't put the whole world in To, use CC. Regards, Jian-Hong Pan From mboxrd@z Thu Jan 1 00:00:00 1970 From: starnight@g.ncu.edu.tw (Jian-Hong Pan) Date: Wed, 26 Sep 2018 23:52:50 +0800 Subject: [RFC 1/3 net] lorawan: Add LoRaWAN class module In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Andreas F?rber ? 2018?9?24? ?? ??12:40??? > > Hi Jian-Hong, > > [+ Afonso] > > Am 23.08.18 um 19:15 schrieb Jian-Hong Pan: > > LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. > > > > This patch implements part of Class A end-devices features defined in > > LoRaWAN(TM) Specification Ver. 1.0.2: > > 1. End-device receive slot timing > > 2. Only single channel and single data rate for now > > 3. Unconfirmed data up/down message types > > 4. Encryption/decryption for up/down link data messages > > > > It also implements the the functions and maps to Datagram socket for > > LoRaWAN unconfirmed data messages. > > > > On the other side, it defines the basic interface and operation > > functions for compatible LoRa device drivers. > > > > Signed-off-by: Jian-Hong Pan > > --- > > include/linux/maclorawan/lora.h | 239 +++++++++++ > > net/maclorawan/Kconfig | 14 + > > net/maclorawan/Makefile | 2 + > > net/maclorawan/lorawan.h | 219 ++++++++++ > > net/maclorawan/lrwsec.c | 237 +++++++++++ > > net/maclorawan/lrwsec.h | 57 +++ > > net/maclorawan/mac.c | 552 +++++++++++++++++++++++++ > > net/maclorawan/main.c | 665 ++++++++++++++++++++++++++++++ > > net/maclorawan/socket.c | 700 ++++++++++++++++++++++++++++++++ > > 9 files changed, 2685 insertions(+) > > create mode 100644 include/linux/maclorawan/lora.h > > Can we use include/linux/lora/lorawan.h for simplicity? Technically, yes > > create mode 100644 net/maclorawan/Kconfig > > create mode 100644 net/maclorawan/Makefile > > create mode 100644 net/maclorawan/lorawan.h > > create mode 100644 net/maclorawan/lrwsec.c > > create mode 100644 net/maclorawan/lrwsec.h > > create mode 100644 net/maclorawan/mac.c > > create mode 100644 net/maclorawan/main.c > > create mode 100644 net/maclorawan/socket.c > > This patch is much too large for me to review... > > It also doesn't seem to follow the structure I suggested: 802.15.4 has > two separate directories, net/ieee802154/ and net/mac802154/. Therefore > I had suggested net/maclorawan/ only for code that translates from > ETH_P_LORAWAN to ETH_P_LORA socket buffers, i.e. your soft MAC. Generic > socket code that applies also to hard MAC drivers I expected to go > either to net/lora/lorawan/ or better net/lorawan/ or some other clearly > separate location, with its own Kconfig symbol - any reason not to? > Consider which parts can be enabled/used independently of each other, > then you can put them into two (or more?) different patches. Maybe I misunderstood before. Besides, the header files need to be split for different paths or folders. Anyway, I will try to separate it into parts in version 2 patches. > Also please use SPDX license identifiers in your headers. > And please don't put the whole world in To, use CC. Regards, Jian-Hong Pan