From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Harte <seanbh@gmail.com>
Subject: Re: [PATCH v6 6/8] net/i40e: add FDIR support for GTP-C
 and GTP-U
Date: Fri, 29 Sep 2017 11:09:47 +0100
Message-ID: <CACA5i9ZxkTMZ84vu_pFjXB0H3tV7vuD7qaosahoQWwSkV9BLug@mail.gmail.com>
References: <1506565054-67690-1-git-send-email-beilei.xing@intel.com>
 <1506662342-18966-1-git-send-email-beilei.xing@intel.com>
 <1506662342-18966-7-git-send-email-beilei.xing@intel.com>
 <CACA5i9bMUaB-LMzrfLKP6hnWFDVz7HRKufzo+2xi6=MY4UkROg@mail.gmail.com>
 <94479800C636CB44BD422CB454846E0132038E8C@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, "Chilikin,
 Andrey" <andrey.chilikin@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Xing, Beilei" <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com
 [209.85.218.66]) by dpdk.org (Postfix) with ESMTP id B69241B21F
 for <dev@dpdk.org>; Fri, 29 Sep 2017 12:09:48 +0200 (CEST)
Received: by mail-oi0-f66.google.com with SMTP id x85so1242361oix.12
 for <dev@dpdk.org>; Fri, 29 Sep 2017 03:09:48 -0700 (PDT)
In-Reply-To: <94479800C636CB44BD422CB454846E0132038E8C@SHSMSX101.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 29 September 2017 at 10:33, Xing, Beilei <beilei.xing@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: Sean Harte [mailto:seanbh@gmail.com]
>> Sent: Friday, September 29, 2017 4:15 PM
>> To: Xing, Beilei <beilei.xing@intel.com>
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Chilikin, Andrey
>> <andrey.chilikin@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v6 6/8] net/i40e: add FDIR support for GT=
P-C
>> and GTP-U
>>
>> On 29 September 2017 at 06:19, Beilei Xing <beilei.xing@intel.com> wrote=
:
>> > This patch adds FDIR support for GTP-C and GTP-U. The input set of
>> > GTP-C and GTP-U is TEID.
>> >
>> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>> > ---
>> >  drivers/net/i40e/i40e_ethdev.h |  30 +++++
>> >  drivers/net/i40e/i40e_fdir.c   | 200 ++++++++++++++++++++++---------
>> >  drivers/net/i40e/i40e_flow.c   | 263
>> +++++++++++++++++++++++++++++++++++------
>> >  3 files changed, 396 insertions(+), 97 deletions(-)
>>
>> <snip>
>>
>> > @@ -1173,10 +1196,69 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf
>> *pf,
>> >                                 rte_cpu_to_be_16(ETHER_TYPE_ARP))
>> >                         payload +=3D sizeof(struct arp_hdr);
>> >                 set_idx =3D I40E_FLXPLD_L2_IDX;
>> > -               break;
>> > -       default:
>> > -               PMD_DRV_LOG(ERR, "unknown pctype %u.", fdir_input->pct=
ype);
>> > -               return -EINVAL;
>> > +       } else if (fdir_input->flow_ext.customized_pctype) {
>> > +               /* If customized pctype is used */
>> > +               cus_pctype =3D i40e_flow_fdir_find_customized_pctype(p=
f, pctype);
>> > +               if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC ||
>> > +                   cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV4=
 ||
>> > +                   cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV6=
 ||
>> > +                   cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) {
>> > +                       udp =3D (struct udp_hdr *)(raw_pkt + len);
>> > +                       udp->dgram_len =3D
>> > +
>> > + rte_cpu_to_be_16(I40E_FDIR_UDP_DEFAULT_LEN);
>> > +
>> > +                       gtp =3D (struct rte_flow_item_gtp *)
>> > +                               ((unsigned char *)udp + sizeof(struct =
udp_hdr));
>> > +                       gtp->v_pt_rsv_flags =3D 0x30;
>>
>> 0x30 isn't valid for GTP-C, the sequence number must be present in GTP-C=
 so
>> it will be 0x32 or more. Is this byte actually matched against by the de=
vice
>> using the GTP pctypes?
>
> We construct packets and send the packet to HW  to create flow director r=
ule for GTP-C and
> GTP-U. Actually I didn=E2=80=99t get error info with 0x30. And in my test=
, GTP-C packets can hit  GTP-C
> pctype rule. Will try 0x32 later.
>
>>
>> > +                       gtp->msg_len =3D
>> > +                               rte_cpu_to_be_16(I40E_FDIR_GTP_DEFAULT=
_LEN);
>> > +                       gtp->teid =3D fdir_input->flow.gtp_flow.teid;
>> > +                       gtp->msg_type =3D 0x1;
>>
>> Why use this value?
>
> Just for constructing a GTP packet to create a fdir rule for one pctype, =
can use other values except 0xFF.
>
>>
>> > +
>> > +                       if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_G=
TPC)
>> > +                               udp->dst_port =3D
>> > + rte_cpu_to_be_16(2123);
>>
>> This will only match half of GTP-C messages. GTP-C messages have a UDP
>> port destination of 2123, or a UDP source port of 2123. To match all GTP=
-C
>> packets you need to look at both.
>
> Yes. But the GTP profile for i40e didn't support response message.

That's not clear to a user of the rte_flow API

>
>>
>> > +                       else
>> > +                               udp->dst_port =3D
>> > + rte_cpu_to_be_16(2152);
>> > +
>> > +                       if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_G=
TPU_IPV4) {
>> > +                               gtp->msg_type =3D 0xFF;
>> > +                               gtp_ipv4 =3D (struct ipv4_hdr *)
>> > +                                       ((unsigned char *)gtp +
>> > +                                        sizeof(struct
>> > + rte_flow_item_gtp));
>>
>> This is only valid if v_pt_rsv_flags is 0x30. GTP-U packets are allowed =
to have
>> a sequence number, which adds an extra 4 bytes to the GTP header.
>
> For the GTP profile, there're 4 pctypes for GTP packets: GTPC, GTPU, GTPI=
PV4, and GTPIPV6.
> HW parse which pctype the GTP packets belonge to.
> We construct packet to create a fdir rule for one pctype, after that, all=
 packets whose
> pctype matches the rule's pctype will hit the rule.

My point is that you can only assume the inner IP header starts at an
offset of sizeof(struct rte_flow_item_gtp) if v_pt_rsv_flags is
exactly 0x30. If you match only those packets then some GTP-U packets
will not be matched. That should be clear to a user of the rte_flow
API.

>
>>
>> > +                               gtp_ipv4->version_ihl =3D
>> > +                                       I40E_FDIR_IP_DEFAULT_VERSION_I=
HL;
>> > +                               gtp_ipv4->next_proto_id =3D IPPROTO_IP=
;
>> > +                               gtp_ipv4->total_length =3D
>> > +                                       rte_cpu_to_be_16(
>> > +                                               I40E_FDIR_INNER_IP_DEF=
AULT_LEN);
>> > +                               payload =3D (unsigned char *)gtp_ipv4 =
+
>> > +                                       sizeof(struct ipv4_hdr);
>> > +                       } else if (cus_pctype->index =3D=3D
>> > +                                  I40E_CUSTOMIZED_GTPU_IPV6) {
>> > +                               gtp->msg_type =3D 0xFF;
>> > +                               gtp_ipv6 =3D (struct ipv6_hdr *)
>> > +                                       ((unsigned char *)gtp +
>> > +                                        sizeof(struct
>> > + rte_flow_item_gtp));
>>
>> This is only valid if v_pt_rsv_flags is 0x30. GTP-U packets are allowed =
to have
>> a sequence number, which adds an extra 4 bytes to the GTP header.
>
> Same with above.
>
>>
>> > +                               gtp_ipv6->vtc_flow =3D
>> > +                                       rte_cpu_to_be_32(
>> > +                                              I40E_FDIR_IPv6_DEFAULT_=
VTC_FLOW |
>> > +                                              (0 << I40E_FDIR_IPv6_TC=
_OFFSET));
>> > +                               gtp_ipv6->proto =3D IPPROTO_NONE;
>> > +                               gtp_ipv6->payload_len =3D
>> > +                                       rte_cpu_to_be_16(
>> > +                                             I40E_FDIR_INNER_IPv6_DEF=
AULT_LEN);
>> > +                               gtp_ipv6->hop_limits =3D
>> > +                                       I40E_FDIR_IPv6_DEFAULT_HOP_LIM=
ITS;
>> > +                               payload =3D (unsigned char *)gtp_ipv6 =
+
>> > +                                       sizeof(struct ipv6_hdr);
>> > +                       } else
>> > +                               payload =3D (unsigned char *)gtp +
>> > +                                       sizeof(struct rte_flow_item_gt=
p);
>> > +               }
>> > +       } else {
>> > +               PMD_DRV_LOG(ERR, "unknown pctype %u.",
>> > +                           fdir_input->pctype);
>> > +               return -1;
>> >         }
>> >
>> >         /* fill the flexbytes to payload */
>>
>> <snip>