From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH] drm/nouveau/mmu: Remove unneeded semicolon Date: Thu, 30 Apr 2020 14:00:52 +1000 Message-ID: References: <20200424073601.143549-1-zhengbin13@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200424073601.143549-1-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Zheng Bin Cc: Dave Airlie , ML nouveau , ML dri-devel , Ben Skeggs , Daniel Vetter List-Id: nouveau.vger.kernel.org Thanks! On Fri, 24 Apr 2020 at 17:29, Zheng Bin wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > index 41640e0584ac..199f94e15c5f 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > @@ -580,7 +580,7 @@ nvkm_vmm_iter(struct nvkm_vmm *vmm, const struct nvkm_vmm_page *page, > it.pte[it.lvl]++; > } > } > - }; > + } > > nvkm_vmm_flush(&it); > return ~0ULL; > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > index 5e55ecbd8005..d3f8f916d0db 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > @@ -304,7 +304,7 @@ int tu102_vmm_new(struct nvkm_mmu *, bool, u64, u64, void *, u32, > FILL(VMM, PT, PTEI, _ptes, MAP, _addr); \ > PTEI += _ptes; \ > PTEN -= _ptes; \ > - }; \ > + } \ > nvkm_done((PT)->memory); \ > } while(0) > > -- > 2.26.0.106.g9fadedd > > _______________________________________________ > Nouveau mailing list > Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9532BC83001 for ; Thu, 30 Apr 2020 04:01:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64A6F2073E for ; Thu, 30 Apr 2020 04:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HlDSU8FW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A6F2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6CB956EA80; Thu, 30 Apr 2020 04:01:05 +0000 (UTC) Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41E0A6EA80; Thu, 30 Apr 2020 04:01:04 +0000 (UTC) Received: by mail-yb1-xb44.google.com with SMTP id a7so2479290ybs.4; Wed, 29 Apr 2020 21:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uigr/Bk3pctYSK4o6DhYhTgwopWjtqRs7LnV/grgN5Y=; b=HlDSU8FWDhsYKPb5rwVsizFvS0q7cSdPJi1n92iA/wCG7sSfUBU2q4+Gba+vBukyz1 5AcwvpIE3pCO81NypD9yqFzt7k2reoGPoGd9VmFZcUhxmioRZqCH2vmwxwgI+EQbDZxZ T/kn1ukQ8MxQFvoFumY4DgOVM94yR11F92ZGgUE1r+0BB4TIMrKcHIQz6yT0agLOuOZI BSfUZ5J1JOrZo5xXTNi+ZNc3xIM/a4K11SBPao6N1rfPmS5UFIL8SifVl2atYw6WGZdH XSDvD13TGin2Z0pELvo1Dh7YsYiOHT0ZTfe23XEMgYZA7Ea9Rak2+hzhafFmh68qn3/T X26A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uigr/Bk3pctYSK4o6DhYhTgwopWjtqRs7LnV/grgN5Y=; b=kMjR+6VU5f3GYNrm1KtuH3+//YSjJ190GSmXbxrO/HVUMs2uzqc9YOzCcl7ZrSEUDg xX1COnLZMJCBOlOb9mJyRvX3v58K8Qu38GDyfj86WbLz3dThRbbJnfIqYs1ZtFs8rat3 zjHA8pCAI3DxhEthnv1RJZgul0ZTfj1hU9YiXu8F9xjXwle2Rl5cbE5VryPY9iNRyxxh n3EBlN8VMoRlmpR/SvU1014GX+4K1xOibkU+IsihINmwMxVhAtsMVFSXzRuUsUjXj/LO o/uTrT8Y76S8/9xZ/2bw8Hxy0PazCA5Kblw1rUHhrISoqC29qQWssyzrG9oG13LOuVsp oo+Q== X-Gm-Message-State: AGi0Pubug1O9GP7ixPmWx89WlD+3rXg0vWQsxqQ4SY/t0KoqLjdahlgm ej9EXVUuQVBZCBT22IAnymIR1l1YQpEP4E+c9ZuyZdZe X-Google-Smtp-Source: APiQypI9ba6qHe3Ig0YTY62gqUCQsREqs/dCO0PphyN68mxloPgpa8vB4qbheHh55vuRJHLEqys/+MA6c+26curgDho= X-Received: by 2002:a25:6b46:: with SMTP id o6mr2462578ybm.147.1588219263490; Wed, 29 Apr 2020 21:01:03 -0700 (PDT) MIME-Version: 1.0 References: <20200424073601.143549-1-zhengbin13@huawei.com> In-Reply-To: <20200424073601.143549-1-zhengbin13@huawei.com> From: Ben Skeggs Date: Thu, 30 Apr 2020 14:00:52 +1000 Message-ID: Subject: Re: [Nouveau] [PATCH] drm/nouveau/mmu: Remove unneeded semicolon To: Zheng Bin X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , ML nouveau , ML dri-devel , Ben Skeggs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thanks! On Fri, 24 Apr 2020 at 17:29, Zheng Bin wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h:307:2-3: Unneeded semicolon > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c:583:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zheng Bin > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > index 41640e0584ac..199f94e15c5f 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > @@ -580,7 +580,7 @@ nvkm_vmm_iter(struct nvkm_vmm *vmm, const struct nvkm_vmm_page *page, > it.pte[it.lvl]++; > } > } > - }; > + } > > nvkm_vmm_flush(&it); > return ~0ULL; > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > index 5e55ecbd8005..d3f8f916d0db 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.h > @@ -304,7 +304,7 @@ int tu102_vmm_new(struct nvkm_mmu *, bool, u64, u64, void *, u32, > FILL(VMM, PT, PTEI, _ptes, MAP, _addr); \ > PTEI += _ptes; \ > PTEN -= _ptes; \ > - }; \ > + } \ > nvkm_done((PT)->memory); \ > } while(0) > > -- > 2.26.0.106.g9fadedd > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel