From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenz Bauer Subject: Re: [PATCH 1/3] bpf: allow zero-initializing hash map seed Date: Fri, 5 Oct 2018 08:42:22 +0100 Message-ID: References: <20181001104509.24211-1-lmb@cloudflare.com> <20181001104509.24211-2-lmb@cloudflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, linux-api@vger.kernel.org To: jannh@google.com Return-path: Received: from mail-ot1-f54.google.com ([209.85.210.54]:45090 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728170AbeJEOkD (ORCPT ); Fri, 5 Oct 2018 10:40:03 -0400 Received: by mail-ot1-f54.google.com with SMTP id u22so11788644ota.12 for ; Fri, 05 Oct 2018 00:42:34 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Oct 2018 at 21:00, Jann Horn wrote: > > If this is for testing only, you can slap a capable(CAP_SYS_ADMIN) > check in here, right? I doubt it matters, but I don't really like > seeing something like this exposed to unprivileged userspace just > because you need it for kernel testing. That would mean all tests have to run as root / with CAP_SYS_ADMIN which isn't ideal. -- Lorenz Bauer | Systems Engineer 25 Lavington St., London SE1 0NZ www.cloudflare.com