All of lore.kernel.org
 help / color / mirror / Atom feed
From: 馬克泡 <macpaul@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm, lib/board.c: Coding Style cleanup
Date: Fri, 15 Jul 2011 08:17:26 +0800	[thread overview]
Message-ID: <CACCg+XMTkdsbEvRtPRwkUQc73_exQKBV7s59a2EijFpaUMnXJw@mail.gmail.com> (raw)
In-Reply-To: <4E1F177C.3050105@aribaud.net>

Hi Heiko and Albert,

2011/7/15 Albert ARIBAUD <albert.u.boot@aribaud.net>
>
> Hi Heiko,
>
> Sorry for having kept this patch unanswered so long. I am now on
> holiday, which means *a bit* more time for U-Boot, so here comes:
>
> Re: patch title, can you make it "arm: libboard.c: ..." rather than
> "arm, libboard.c" ?

Just remind both of you here, about the clean up patches,
we have an other prefix for the patch title (subject).

http://www.denx.de/wiki/U-Boot/Patches
General Patch Submission Rules

"Non-functional changes, i.e. whitespace and reformatting changes,
should be done in separate patches marked as cosmetic. This separation
of functional and cosmetic changes greatly facilitates the review
process."

So, please use "cosmetic:" as the beginning prefix of your clear up patch.

>
> Also, make sure you rebase onto latest u-boot-arm/master for next
> version: this one does not apply cleanly ATM.

[deleted]

>
> > - ? ? ? ? ? ? ? ? ? ? printf (" ?CRC: %08X",
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? crc32 (0, (const unsigned char *) CONFIG_SYS_FLASH_BASE, flash_size)
> > + ? ? ? ? ? ? ? ? ? ? printf(" ?CRC: %08X",
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? crc32(0,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? (const unsigned char *) CONFIG_SYS_FLASH_BASE,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? flash_size)
>
> Pleas indent deeper for the last two lines that belong to the call to crc32.
>
> Amicalement,

--
Best regards,
Macpaul Lin

  reply	other threads:[~2011-07-15  0:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03  8:11 [U-Boot] [PATCH 0/2] arm: cleanup board code Heiko Schocher
2011-06-03  8:11 ` [U-Boot] [PATCH 1/2] arm, lib/board.c: Coding Style cleanup Heiko Schocher
2011-06-06 11:09   ` Detlev Zundel
2011-07-14 16:21   ` Albert ARIBAUD
2011-07-15  0:17     ` 馬克泡 [this message]
2011-07-15  6:57     ` Heiko Schocher
2011-07-15  7:03   ` [U-Boot] [PATCH v2 01/02] cosmetic: arm: libboard.c: " Heiko Schocher
2011-07-15  7:22     ` Wolfgang Denk
2011-07-15  7:43       ` Heiko Schocher
2011-07-16  5:36   ` [U-Boot] [PATCH v3 01/02] cosmetic: arm: lib/board.c: " Heiko Schocher
2011-07-27 21:40   ` [U-Boot] [PATCH 1/2] arm, " Wolfgang Denk
2011-08-04 11:40     ` Albert ARIBAUD
2011-06-03  8:11 ` [U-Boot] [PATCH 2/2] arm, lib/board.c: use gd->ram_size instead of bd->bi_memsize Heiko Schocher
2011-08-05  6:09   ` Heiko Schocher
2011-08-12 17:56   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACCg+XMTkdsbEvRtPRwkUQc73_exQKBV7s59a2EijFpaUMnXJw@mail.gmail.com \
    --to=macpaul@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.