All of lore.kernel.org
 help / color / mirror / Atom feed
From: 馬克泡 <macpaul@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework
Date: Tue, 5 Jul 2011 22:16:22 +0800	[thread overview]
Message-ID: <CACCg+XP2aXUzQ2LAZsuhVrfTkRgZArL=rAKvN2CXvRxK=Z+jbQ@mail.gmail.com> (raw)
In-Reply-To: <1309870396-26363-1-git-send-email-l.majewski@samsung.com>

Hi Lukasz Majewski,

2011/7/5 Lukasz Majewski <l.majewski@samsung.com>:
> Included commits provide Linux USB gadget support for U-boot.
> The USB Gadget infrastructure is running on top of the Samsung's
> UDC OTG controller. The code has been tested on the GONI (S5PC110)
> reference target.

It's very happy to see there is a port of USB OTG from Linux framework.
However, please remind that according to the patch rules on u-boot's wiki page:
http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign
Include git commit hash number and kernel version which you grabbed
the code from it.

I've found that you're using the #define marco to represent registers.
I'm not sure it you're using automatically generated asm-offsets.h
method to manage
these registers.
However, it's better to rewrite it into structure form whihc is easier
to read and maintain
both in u-boot and in Linux.

If there are implemented the same way in Linux kernel, I suggest you could also
improve it in Linux kernel and send cosmetic patches.

-- 
Best regards,
Macpaul Lin

  parent reply	other threads:[~2011-07-05 14:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 12:53 [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework Lukasz Majewski
2011-07-05 12:53 ` [U-Boot] [PATCH 1/2] " Lukasz Majewski
2011-07-05 12:53 ` [U-Boot] [PATCH 2/2] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-05 14:08 ` [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework Wolfgang Denk
2011-07-05 14:16 ` 馬克泡 [this message]
     [not found]   ` <20110711153117.78a90152@lmajewski.digital.local>
2011-07-11 14:12     ` 馬克泡
2011-07-05 18:46 ` Remy Bohmer
2011-07-05 13:58 Lukasz Majewski
2011-07-05 14:03 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACCg+XP2aXUzQ2LAZsuhVrfTkRgZArL=rAKvN2CXvRxK=Z+jbQ@mail.gmail.com' \
    --to=macpaul@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.