From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28E3C433F5 for ; Tue, 22 Feb 2022 02:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238963AbiBVCPo (ORCPT ); Mon, 21 Feb 2022 21:15:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230436AbiBVCPm (ORCPT ); Mon, 21 Feb 2022 21:15:42 -0500 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF1381D310; Mon, 21 Feb 2022 18:15:17 -0800 (PST) Received: by mail-vs1-xe2d.google.com with SMTP id j3so5333484vsi.7; Mon, 21 Feb 2022 18:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BlI0MZtmyrupgAgtS84tifI22v5MszPHmzBYuMorQ2Q=; b=Rk4wLpnzqfp8r0wTeL769g6XltdeX4nvtAxkmAP0nmzzlyzhVkBToHl6P9L3bbm82o wPzymBMGB+rEQFwGR8DJwzTDHH1AfiXXQ4G3WVg8xyTg4rDw36f4a9vde+nrbZMLFRkN obhvmz22sTRmEZQECLHBOUsWFeHDcv//ZAROlAsniLb64mNcoPrtPspOds/Cpc10zv9R tlzoVoiVXTQzJeY37ud3nRWtGSRkVxkLPTrz+1IlnXy1RVuGZmbZw1EdUShCLfetw6XL gmoyEgSqsicqdd0DcdTS5Hy6oWEk8F2THhQOIN57Em92cCrNL2y8X9cOknB9YN/SywK5 9dlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BlI0MZtmyrupgAgtS84tifI22v5MszPHmzBYuMorQ2Q=; b=b9y63x8HTVKEJf5yKkizS0CukIOTLY38HxJOEVeKRDEAaUX9sCNie03gtZ9eJ3y9Tw wOUqAxDEW7Wq+NDCWjGRGZ32RnoUT+MbqnJvlRsRwjKiFEq0CHrTR5IKIN06H4o4acuO bagLqFn+NBcpIkgpjB16B5AvpbuxILEqPYfIMN/qF4KUSfrZW6jzppn5YiOUbM+r6/FX HpVsVzBppFsCVy6ef7aSM8z7nbmWO482eK3LermpsKz4VOgfOsYFaARPt7xe4e8/lMxF I4P/5yDJ2GI2jgbj4zIKyw8Sm+JdqRL8+FWXM495IugiB9nUjD9mWF5x28m96ViTnubq S16Q== X-Gm-Message-State: AOAM5301fyBRgwJfNruCCDmnNzQUznvQDAaFgl2xVuv67ZyGrMzqhzyj W1CBB4b5+6f6Mfh3NPxUZ7Tvu+NLAVqEdvB5iXYnmqlR0tY4 X-Google-Smtp-Source: ABdhPJwP8hGkmey95OH9kMBmiXbTjANOhIk00QyYwbxVhv9uJZHDNcE4hSC4Qy5vlaQyfzrxkO0dro8txp6TgLSZrkQ= X-Received: by 2002:a05:6102:370f:b0:31b:60dc:4f76 with SMTP id s15-20020a056102370f00b0031b60dc4f76mr9690133vst.2.1645496116704; Mon, 21 Feb 2022 18:15:16 -0800 (PST) MIME-Version: 1.0 References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-6-warp5tw@gmail.com> In-Reply-To: From: Tyrone Ting Date: Tue, 22 Feb 2022 10:15:04 +0800 Message-ID: Subject: Re: [PATCH v2 05/11] i2c: npcm: Remove unused clock node To: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, semen.protsenko@linaro.org, yangyicong@hisilicon.com, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, digetx@gmail.com, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan: Thank you for your comments and please find my reply next to your comments. Jonathan Neusch=C3=A4fer =E6=96=BC 2022=E5=B9=B42= =E6=9C=8821=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=887:49=E5=AF=AB=E9= =81=93=EF=BC=9A > > On Sun, Feb 20, 2022 at 11:53:15AM +0800, Tyrone Ting wrote: > > From: Tali Perry > > > > Remove unused npcm750-clk node. > > You're not actually removing a node, for example in the sense of removing= a > devicetree node from a devicetree. > > So, I think "Remove unused variable clk_regmap." would be a better > description. > May I modify the description according to your input and attach "Reviewed-by: Jonathan Neusch=C3=A4fer " onto this commit in the next version of the patch set? > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller dri= ver") > > Signed-off-by: Tali Perry > > Signed-off-by: Tyrone Ting > > --- > > drivers/i2c/busses/i2c-npcm7xx.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-= npcm7xx.c > > index a51db3f50274..9ccb9958945e 100644 > > --- a/drivers/i2c/busses/i2c-npcm7xx.c > > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > > @@ -2233,7 +2233,6 @@ static int npcm_i2c_probe_bus(struct platform_dev= ice *pdev) > > struct i2c_adapter *adap; > > struct clk *i2c_clk; > > static struct regmap *gcr_regmap; > > - static struct regmap *clk_regmap; > > int irq; > > int ret; > > struct device_node *np =3D pdev->dev.of_node; > > @@ -2256,10 +2255,6 @@ static int npcm_i2c_probe_bus(struct platform_de= vice *pdev) > > return PTR_ERR(gcr_regmap); > > regmap_write(gcr_regmap, NPCM_I2CSEGCTL, NPCM_I2CSEGCTL_INIT_VAL)= ; > > > > - clk_regmap =3D syscon_regmap_lookup_by_compatible("nuvoton,npcm75= 0-clk"); > > - if (IS_ERR(clk_regmap)) > > - return PTR_ERR(clk_regmap); > > - > > The change itself looks good to me, > > Reviewed-by: Jonathan Neusch=C3=A4fer > > > bus->reg =3D devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(bus->reg)) > > return PTR_ERR(bus->reg); > > -- > > 2.17.1 > > > > > Thanks, > Jonathan Best regards, Tyrone From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5843C433F5 for ; Tue, 22 Feb 2022 02:26:37 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K2jj76jYmz3bY4 for ; Tue, 22 Feb 2022 13:26:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Rk4wLpnz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::e36; helo=mail-vs1-xe36.google.com; envelope-from=warp5tw@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Rk4wLpnz; dkim-atps=neutral Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4K2jS94f17z3bSv for ; Tue, 22 Feb 2022 13:15:21 +1100 (AEDT) Received: by mail-vs1-xe36.google.com with SMTP id g20so19487698vsb.9 for ; Mon, 21 Feb 2022 18:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BlI0MZtmyrupgAgtS84tifI22v5MszPHmzBYuMorQ2Q=; b=Rk4wLpnzqfp8r0wTeL769g6XltdeX4nvtAxkmAP0nmzzlyzhVkBToHl6P9L3bbm82o wPzymBMGB+rEQFwGR8DJwzTDHH1AfiXXQ4G3WVg8xyTg4rDw36f4a9vde+nrbZMLFRkN obhvmz22sTRmEZQECLHBOUsWFeHDcv//ZAROlAsniLb64mNcoPrtPspOds/Cpc10zv9R tlzoVoiVXTQzJeY37ud3nRWtGSRkVxkLPTrz+1IlnXy1RVuGZmbZw1EdUShCLfetw6XL gmoyEgSqsicqdd0DcdTS5Hy6oWEk8F2THhQOIN57Em92cCrNL2y8X9cOknB9YN/SywK5 9dlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BlI0MZtmyrupgAgtS84tifI22v5MszPHmzBYuMorQ2Q=; b=Q7B/lO3woY0tabmDfyFlft7L2YMHtCgF+IGTwA97YOL8033+sRrwrSC8Hv91qxbepU YFq+3Ru0ItLK4l9MvD4RkX0zk1k7VSlhp8IWCNbEZjPUcbpSF1TTT7/X1iLNl24Puu/J +40vUh9hy4whDKI118bfGT0+w+o75lUazcBHr24YNXoXYiOydBlo2nvYYUKBd7m9yfJX dUUDDtEaGjEjAZXJp3vG7EFaSRtACj/+iPWKsKFkBe/CiqBfbW9RxnvFb1B8Ec5ZNF31 domqueV1h5FH/61jkKf9AevoexsUxJ8Jk8gYw/Gfvc45jzLR4//yN+yPUnxoj2diCEXI O8Uw== X-Gm-Message-State: AOAM531Mi3i4KCUlSrGZN1E4fzI7zgf2bbtlyEdqrXl9xHHXVyKJuej6 AYl816Nx6shk/2i5U/PzPnmp5Y1p53J+di+aDA== X-Google-Smtp-Source: ABdhPJwP8hGkmey95OH9kMBmiXbTjANOhIk00QyYwbxVhv9uJZHDNcE4hSC4Qy5vlaQyfzrxkO0dro8txp6TgLSZrkQ= X-Received: by 2002:a05:6102:370f:b0:31b:60dc:4f76 with SMTP id s15-20020a056102370f00b0031b60dc4f76mr9690133vst.2.1645496116704; Mon, 21 Feb 2022 18:15:16 -0800 (PST) MIME-Version: 1.0 References: <20220220035321.3870-1-warp5tw@gmail.com> <20220220035321.3870-6-warp5tw@gmail.com> In-Reply-To: From: Tyrone Ting Date: Tue, 22 Feb 2022 10:15:04 +0800 Message-ID: Subject: Re: [PATCH v2 05/11] i2c: npcm: Remove unused clock node To: =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 22 Feb 2022 13:21:12 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmaimon77@gmail.com, devicetree@vger.kernel.org, tali.perry1@gmail.com, linux-i2c@vger.kernel.org, digetx@gmail.com, benjaminfair@google.com, krzysztof.kozlowski@canonical.com, openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com, christophe.leroy@csgroup.eu, lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, bence98@sch.bme.hu, arnd@arndb.de, sven@svenpeter.dev, robh+dt@kernel.org, Avi.Fishman@nuvoton.com, andriy.shevchenko@linux.intel.com, semen.protsenko@linaro.org, jie.deng@intel.com, avifishman70@gmail.com, venture@google.com, yangyicong@hisilicon.com, linux-kernel@vger.kernel.org, wsa@kernel.org, kfting@nuvoton.com, tali.perry@nuvoton.com, olof@lixom.net Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Jonathan: Thank you for your comments and please find my reply next to your comments. Jonathan Neusch=C3=A4fer =E6=96=BC 2022=E5=B9=B42= =E6=9C=8821=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=887:49=E5=AF=AB=E9= =81=93=EF=BC=9A > > On Sun, Feb 20, 2022 at 11:53:15AM +0800, Tyrone Ting wrote: > > From: Tali Perry > > > > Remove unused npcm750-clk node. > > You're not actually removing a node, for example in the sense of removing= a > devicetree node from a devicetree. > > So, I think "Remove unused variable clk_regmap." would be a better > description. > May I modify the description according to your input and attach "Reviewed-by: Jonathan Neusch=C3=A4fer " onto this commit in the next version of the patch set? > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller dri= ver") > > Signed-off-by: Tali Perry > > Signed-off-by: Tyrone Ting > > --- > > drivers/i2c/busses/i2c-npcm7xx.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-= npcm7xx.c > > index a51db3f50274..9ccb9958945e 100644 > > --- a/drivers/i2c/busses/i2c-npcm7xx.c > > +++ b/drivers/i2c/busses/i2c-npcm7xx.c > > @@ -2233,7 +2233,6 @@ static int npcm_i2c_probe_bus(struct platform_dev= ice *pdev) > > struct i2c_adapter *adap; > > struct clk *i2c_clk; > > static struct regmap *gcr_regmap; > > - static struct regmap *clk_regmap; > > int irq; > > int ret; > > struct device_node *np =3D pdev->dev.of_node; > > @@ -2256,10 +2255,6 @@ static int npcm_i2c_probe_bus(struct platform_de= vice *pdev) > > return PTR_ERR(gcr_regmap); > > regmap_write(gcr_regmap, NPCM_I2CSEGCTL, NPCM_I2CSEGCTL_INIT_VAL)= ; > > > > - clk_regmap =3D syscon_regmap_lookup_by_compatible("nuvoton,npcm75= 0-clk"); > > - if (IS_ERR(clk_regmap)) > > - return PTR_ERR(clk_regmap); > > - > > The change itself looks good to me, > > Reviewed-by: Jonathan Neusch=C3=A4fer > > > bus->reg =3D devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(bus->reg)) > > return PTR_ERR(bus->reg); > > -- > > 2.17.1 > > > > > Thanks, > Jonathan Best regards, Tyrone