From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F93CC433EF for ; Wed, 24 Nov 2021 08:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233244AbhKXIb7 (ORCPT ); Wed, 24 Nov 2021 03:31:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45870 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbhKXIbx (ORCPT ); Wed, 24 Nov 2021 03:31:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637742523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qC1+19qo/TZ579J4U0L2xMIl87l4fuCd0xU7MNzT7yM=; b=dOOYH98GvPluL+rsqWmXKdVEJatIC0kTw6yN3eIiqN61UYm3Ubgbr1qxFb55eLF7oqmAAY qOSjnd65JHyrWxLACUSi5xWBGCU+5iDJufSeGNONZbm+pE7rYIaXDWMh5SzhPeeSxxdms/ 3YhaTEEtIy2E2rVgjascpYuIiRKTADs= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-598-koxjANjYMo6Gh3RxhW4hgQ-1; Wed, 24 Nov 2021 03:28:42 -0500 X-MC-Unique: koxjANjYMo6Gh3RxhW4hgQ-1 Received: by mail-lf1-f72.google.com with SMTP id f15-20020a056512228f00b004037c0ab223so1037236lfu.16 for ; Wed, 24 Nov 2021 00:28:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qC1+19qo/TZ579J4U0L2xMIl87l4fuCd0xU7MNzT7yM=; b=NC3dyADq+EVa9gu1tqeR3v0//L4ElqahT5DUtLSa/74T5WiuSmY2phZEuksdXTny7e 8MHLnqASjpxW4cz+EqXila44hd+J5Kpg7r6Hs32mSVoqwrYmXSb9gvQ+d5pqzJ2nwZXc bBmeT/+WzvEXMavDs4pzNs+dMeuPpZSJHnT7bY+infdns9F2CkdgxcXeprpEe+4jEI5L I7U/6LaZi9torB9xk8xF3OOCP98QtM+n9BqjFqPZG4rI/qJKxOPZ5sISaSKEFy+Hy8si 32ZCXY0A9oP20r9YOg5ZvRMId2leKL9xsmLtQaOJfqNssRQRMhiuUY0gq539cW9Tn0VO v3uw== X-Gm-Message-State: AOAM5307D9yR30jjIAlIgLpwXZMLGNdH1n2sFSp9dEvxjZZkgbAFgqcO fYrZoR8c4teBYTvXMBxJQGJLD91ML9iLJwJbhJ49eqMIWUNDmqKPo8wv8C4aoQAnojcObobrzgy ikWMZtLAtfhqCKRh89p4UNkarpqrjayBBHLCBvAQv X-Received: by 2002:a2e:b88d:: with SMTP id r13mr12969172ljp.362.1637742520795; Wed, 24 Nov 2021 00:28:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkdOU/DH3oB9Vpmgk/WfW6E0kJ9djIqPGqTwD6VBjjg/ChJEenZLAgHbyhmMUt+De1WFKbSTDnStglGugwDWQ= X-Received: by 2002:a2e:b88d:: with SMTP id r13mr12969125ljp.362.1637742520498; Wed, 24 Nov 2021 00:28:40 -0800 (PST) MIME-Version: 1.0 References: <20211122064922.51b3678e.pasic@linux.ibm.com> <20211122212352.4a76232d.pasic@linux.ibm.com> <20211123055906-mutt-send-email-mst@kernel.org> <87zgpupcga.fsf@mpe.ellerman.id.au> <20211124022101-mutt-send-email-mst@kernel.org> <20211124032027-mutt-send-email-mst@kernel.org> In-Reply-To: <20211124032027-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Wed, 24 Nov 2021 16:28:29 +0800 Message-ID: Subject: Re: [PATCH V5 1/4] virtio_ring: validate used buffer length To: "Michael S. Tsirkin" Cc: Michael Ellerman , Halil Pasic , virtualization , "Hetzelt, Felicitas" , linux-kernel , "kaplan, david" , Konrad Rzeszutek Wilk , Stefan Hajnoczi , Stefano Garzarella , mcgrof@kernel.org, David Hildenbrand Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 24, 2021 at 4:24 PM Michael S. Tsirkin wrote: > > On Wed, Nov 24, 2021 at 03:59:12PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 3:22 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote: > > > > On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote: > > > > > > > > > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote: > > > > > > > > > > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > > > > > > >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: > > > > > > >> > > > > > > > >> > On Mon, 22 Nov 2021 14:25:26 +0800 > > > > > > >> > Jason Wang wrote: > > > > > > >> > > > > > > > >> > > I think the fixes are: > > > > > > >> > > > > > > > > >> > > 1) fixing the vhost vsock > > > > > > >> > > 2) use suppress_used_validation=true to let vsock driver to validate > > > > > > >> > > the in buffer length > > > > > > >> > > 3) probably a new feature so the driver can only enable the validation > > > > > > >> > > when the feature is enabled. > > > > > > >> > > > > > > > >> > I'm not sure, I would consider a F_DEV_Y_FIXED_BUG_X a perfectly good > > > > > > >> > feature. Frankly the set of such bugs is device implementation > > > > > > >> > specific and it makes little sense to specify a feature bit > > > > > > >> > that says the device implementation claims to adhere to some > > > > > > >> > aspect of the specification. Also what would be the semantic > > > > > > >> > of not negotiating F_DEV_Y_FIXED_BUG_X? > > > > > > >> > > > > > > >> Yes, I agree. Rethink of the feature bit, it seems unnecessary, > > > > > > >> especially considering the driver should not care about the used > > > > > > >> length for tx. > > > > > > >> > > > > > > >> > > > > > > > >> > On the other hand I see no other way to keep the validation > > > > > > >> > permanently enabled for fixed implementations, and get around the problem > > > > > > >> > with broken implementations. So we could have something like > > > > > > >> > VHOST_USED_LEN_STRICT. > > > > > > >> > > > > > > >> It's more about a choice of the driver's knowledge. For vsock TX it > > > > > > >> should be fine. If we introduce a parameter and disable it by default, > > > > > > >> it won't be very useful. > > > > > > >> > > > > > > >> > > > > > > > >> > Maybe, we can also think of 'warn and don't alter behavior' instead of > > > > > > >> > 'warn' and alter behavior. Or maybe even not having such checks on in > > > > > > >> > production, but only when testing. > > > > > > >> > > > > > > >> I think there's an agreement that virtio drivers need more hardening, > > > > > > >> that's why a lot of patches were merged. Especially considering the > > > > > > >> new requirements came from confidential computing, smart NIC and > > > > > > >> VDUSE. For virtio drivers, enabling the validation may help to > > > > > > >> > > > > > > >> 1) protect the driver from the buggy and malicious device > > > > > > >> 2) uncover the bugs of the devices (as vsock did, and probably rpmsg) > > > > > > >> 3) force the have a smart driver that can do the validation itself > > > > > > >> then we can finally remove the validation in the core > > > > > > >> > > > > > > >> So I'd like to keep it enabled. > > > > > > >> > > > > > > >> Thanks > > > > > > > > > > > > > > Let's see how far we can get. But yes, maybe we were too aggressive in > > > > > > > breaking things by default, a warning might be a better choice for a > > > > > > > couple of cycles. > > > > > > > > > > Ok, considering we saw the issues with balloons I think I can post a > > > > > patch to use warn instead. I wonder if we need to taint the kernel in > > > > > this case. > > > > > > > > Rethink this, consider we still have some time, I tend to convert the > > > > drivers to validate the length by themselves. Does this make sense? > > > > > > > > Thanks > > > > > > That's separate but let's stop crashing guests for people ASAP. > > > > Ok, will post a patch soon. > > > > Thanks > > So let's err on the side of caution now, I will just revert for this > release. > > For the next one I think a good plan is: > - no checks by default > - module param to check and warn > - keep adding validation in the drivers as appropriate Fine, I will do that. Thanks > > > > > > > > > > > > > > > > > > > > > > > > This series appears to break the virtio_balloon driver as well. > > > > > > > > > > > > The symptom is soft lockup warnings, eg: > > > > > > > > > > > > INFO: task kworker/1:1:109 blocked for more than 614 seconds. > > > > > > Not tainted 5.16.0-rc2-gcc-10.3.0 #21 > > > > > > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > > > > task:kworker/1:1 state:D stack:12496 pid: 109 ppid: 2 flags:0x00000800 > > > > > > Workqueue: events_freezable update_balloon_size_func > > > > > > Call Trace: > > > > > > [c000000003cef7c0] [c000000003cef820] 0xc000000003cef820 (unreliable) > > > > > > [c000000003cef9b0] [c00000000001e238] __switch_to+0x1e8/0x2f0 > > > > > > [c000000003cefa10] [c000000000f0a00c] __schedule+0x2cc/0xb50 > > > > > > [c000000003cefae0] [c000000000f0a8fc] schedule+0x6c/0x140 > > > > > > [c000000003cefb10] [c00000000095b6c4] tell_host+0xe4/0x130 > > > > > > [c000000003cefba0] [c00000000095d234] update_balloon_size_func+0x394/0x3f0 > > > > > > [c000000003cefc70] [c000000000178064] process_one_work+0x2c4/0x5b0 > > > > > > [c000000003cefd10] [c0000000001783f8] worker_thread+0xa8/0x640 > > > > > > [c000000003cefda0] [c000000000185444] kthread+0x1b4/0x1c0 > > > > > > [c000000003cefe10] [c00000000000cee4] ret_from_kernel_thread+0x5c/0x64 > > > > > > > > > > > > Similar backtrace reported here by Luis: > > > > > > > > > > > > https://lore.kernel.org/lkml/YY2duTi0wAyAKUTJ@bombadil.infradead.org/ > > > > > > > > > > > > Bisect points to: > > > > > > > > > > > > # first bad commit: [939779f5152d161b34f612af29e7dc1ac4472fcf] virtio_ring: validate used buffer length > > > > > > > > > > > > Adding suppress used validation to the virtio balloon driver "fixes" it, eg. > > > > > > > > > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > > > > > index c22ff0117b46..a14b82ceebb2 100644 > > > > > > --- a/drivers/virtio/virtio_balloon.c > > > > > > +++ b/drivers/virtio/virtio_balloon.c > > > > > > @@ -1150,6 +1150,7 @@ static unsigned int features[] = { > > > > > > }; > > > > > > > > > > > > static struct virtio_driver virtio_balloon_driver = { > > > > > > + .suppress_used_validation = true, > > > > > > .feature_table = features, > > > > > > .feature_table_size = ARRAY_SIZE(features), > > > > > > .driver.name = KBUILD_MODNAME, > > > > > > > > > > Looks good, we need a formal patch for this. > > > > > > > > > > And we need fix Qemu as well which advertise non zero used length for > > > > > inflate/deflate queue: > > > > > > > > > > static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq) > > > > > ... > > > > > virtqueue_push(vq, elem, offset); > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > cheers > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22713C433F5 for ; Wed, 24 Nov 2021 08:28:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 83B4040437; Wed, 24 Nov 2021 08:28:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c9OdRJbUXmr9; Wed, 24 Nov 2021 08:28:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id D99BD402FC; Wed, 24 Nov 2021 08:28:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AA07DC002E; Wed, 24 Nov 2021 08:28:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 86D04C0012 for ; Wed, 24 Nov 2021 08:28:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6BA1E400D9 for ; Wed, 24 Nov 2021 08:28:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hdaQ-n7I09Zc for ; Wed, 24 Nov 2021 08:28:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 07ED8400D6 for ; Wed, 24 Nov 2021 08:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637742523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qC1+19qo/TZ579J4U0L2xMIl87l4fuCd0xU7MNzT7yM=; b=dOOYH98GvPluL+rsqWmXKdVEJatIC0kTw6yN3eIiqN61UYm3Ubgbr1qxFb55eLF7oqmAAY qOSjnd65JHyrWxLACUSi5xWBGCU+5iDJufSeGNONZbm+pE7rYIaXDWMh5SzhPeeSxxdms/ 3YhaTEEtIy2E2rVgjascpYuIiRKTADs= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-ZOau5_pcO2Gy1Th-BlAM4Q-1; Wed, 24 Nov 2021 03:28:42 -0500 X-MC-Unique: ZOau5_pcO2Gy1Th-BlAM4Q-1 Received: by mail-lf1-f70.google.com with SMTP id c15-20020a05651200cf00b0040524451deeso1021034lfp.20 for ; Wed, 24 Nov 2021 00:28:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qC1+19qo/TZ579J4U0L2xMIl87l4fuCd0xU7MNzT7yM=; b=DEE/aijqFzReTM7C1wsreQ8Xbt97GOA21cldfePFBgwcCOgnHWw8BCjkWkBTicLlbR /ISAXVFVKG8QWDlrHo7BVmp4kgouRrQ8AeLbgMHvzJvfpFFLlpoXxRcr+oL4MoOFeBcq oJsESAsKO88xQ13lCqbL+VYpLfYNiswhkKeMyT5sJMtY5PPnF333vpdM3AbE7lUMYcN2 zvmifPhL3qoLMFYQKqbVJPbaBHuU+xvzLCVobFC2LtNiMZqDx78wIBS3lsgf6Z4+V+0/ KvKTxZ6IFJ4yMkwTjIViyJlSw5MOzR15ayNdxJh+bpTNDzbBokCevXlPqxaMXx2auGyt KHhA== X-Gm-Message-State: AOAM533/ZBAB3lCJFhpMWkfk0x9a1yBIVwZX1pMP9usEJZZS5Fl/5Wrg GuX94D/pF3MocqmqKuOrJ1/EKcm+j3yjCjlLS76UmRjdMox+qwuLUiGc8AkxowQGTiV9SKkagPt jya4VOz30CDmmx0yIvMWx1hI7j9nvxy2eiGs6/yIHWArE91w8B+y6PC7Aeg== X-Received: by 2002:a2e:b88d:: with SMTP id r13mr12969182ljp.362.1637742520821; Wed, 24 Nov 2021 00:28:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkdOU/DH3oB9Vpmgk/WfW6E0kJ9djIqPGqTwD6VBjjg/ChJEenZLAgHbyhmMUt+De1WFKbSTDnStglGugwDWQ= X-Received: by 2002:a2e:b88d:: with SMTP id r13mr12969125ljp.362.1637742520498; Wed, 24 Nov 2021 00:28:40 -0800 (PST) MIME-Version: 1.0 References: <20211122064922.51b3678e.pasic@linux.ibm.com> <20211122212352.4a76232d.pasic@linux.ibm.com> <20211123055906-mutt-send-email-mst@kernel.org> <87zgpupcga.fsf@mpe.ellerman.id.au> <20211124022101-mutt-send-email-mst@kernel.org> <20211124032027-mutt-send-email-mst@kernel.org> In-Reply-To: <20211124032027-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Wed, 24 Nov 2021 16:28:29 +0800 Message-ID: Subject: Re: [PATCH V5 1/4] virtio_ring: validate used buffer length To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: "kaplan, david" , Konrad Rzeszutek Wilk , Michael Ellerman , "Hetzelt, Felicitas" , linux-kernel , virtualization , Halil Pasic , mcgrof@kernel.org, Stefan Hajnoczi X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Nov 24, 2021 at 4:24 PM Michael S. Tsirkin wrote: > > On Wed, Nov 24, 2021 at 03:59:12PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 3:22 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote: > > > > On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote: > > > > > > > > > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote: > > > > > > > > > > > > "Michael S. Tsirkin" writes: > > > > > > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > > > > > > >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: > > > > > > >> > > > > > > > >> > On Mon, 22 Nov 2021 14:25:26 +0800 > > > > > > >> > Jason Wang wrote: > > > > > > >> > > > > > > > >> > > I think the fixes are: > > > > > > >> > > > > > > > > >> > > 1) fixing the vhost vsock > > > > > > >> > > 2) use suppress_used_validation=true to let vsock driver to validate > > > > > > >> > > the in buffer length > > > > > > >> > > 3) probably a new feature so the driver can only enable the validation > > > > > > >> > > when the feature is enabled. > > > > > > >> > > > > > > > >> > I'm not sure, I would consider a F_DEV_Y_FIXED_BUG_X a perfectly good > > > > > > >> > feature. Frankly the set of such bugs is device implementation > > > > > > >> > specific and it makes little sense to specify a feature bit > > > > > > >> > that says the device implementation claims to adhere to some > > > > > > >> > aspect of the specification. Also what would be the semantic > > > > > > >> > of not negotiating F_DEV_Y_FIXED_BUG_X? > > > > > > >> > > > > > > >> Yes, I agree. Rethink of the feature bit, it seems unnecessary, > > > > > > >> especially considering the driver should not care about the used > > > > > > >> length for tx. > > > > > > >> > > > > > > >> > > > > > > > >> > On the other hand I see no other way to keep the validation > > > > > > >> > permanently enabled for fixed implementations, and get around the problem > > > > > > >> > with broken implementations. So we could have something like > > > > > > >> > VHOST_USED_LEN_STRICT. > > > > > > >> > > > > > > >> It's more about a choice of the driver's knowledge. For vsock TX it > > > > > > >> should be fine. If we introduce a parameter and disable it by default, > > > > > > >> it won't be very useful. > > > > > > >> > > > > > > >> > > > > > > > >> > Maybe, we can also think of 'warn and don't alter behavior' instead of > > > > > > >> > 'warn' and alter behavior. Or maybe even not having such checks on in > > > > > > >> > production, but only when testing. > > > > > > >> > > > > > > >> I think there's an agreement that virtio drivers need more hardening, > > > > > > >> that's why a lot of patches were merged. Especially considering the > > > > > > >> new requirements came from confidential computing, smart NIC and > > > > > > >> VDUSE. For virtio drivers, enabling the validation may help to > > > > > > >> > > > > > > >> 1) protect the driver from the buggy and malicious device > > > > > > >> 2) uncover the bugs of the devices (as vsock did, and probably rpmsg) > > > > > > >> 3) force the have a smart driver that can do the validation itself > > > > > > >> then we can finally remove the validation in the core > > > > > > >> > > > > > > >> So I'd like to keep it enabled. > > > > > > >> > > > > > > >> Thanks > > > > > > > > > > > > > > Let's see how far we can get. But yes, maybe we were too aggressive in > > > > > > > breaking things by default, a warning might be a better choice for a > > > > > > > couple of cycles. > > > > > > > > > > Ok, considering we saw the issues with balloons I think I can post a > > > > > patch to use warn instead. I wonder if we need to taint the kernel in > > > > > this case. > > > > > > > > Rethink this, consider we still have some time, I tend to convert the > > > > drivers to validate the length by themselves. Does this make sense? > > > > > > > > Thanks > > > > > > That's separate but let's stop crashing guests for people ASAP. > > > > Ok, will post a patch soon. > > > > Thanks > > So let's err on the side of caution now, I will just revert for this > release. > > For the next one I think a good plan is: > - no checks by default > - module param to check and warn > - keep adding validation in the drivers as appropriate Fine, I will do that. Thanks > > > > > > > > > > > > > > > > > > > > > > > > This series appears to break the virtio_balloon driver as well. > > > > > > > > > > > > The symptom is soft lockup warnings, eg: > > > > > > > > > > > > INFO: task kworker/1:1:109 blocked for more than 614 seconds. > > > > > > Not tainted 5.16.0-rc2-gcc-10.3.0 #21 > > > > > > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > > > > task:kworker/1:1 state:D stack:12496 pid: 109 ppid: 2 flags:0x00000800 > > > > > > Workqueue: events_freezable update_balloon_size_func > > > > > > Call Trace: > > > > > > [c000000003cef7c0] [c000000003cef820] 0xc000000003cef820 (unreliable) > > > > > > [c000000003cef9b0] [c00000000001e238] __switch_to+0x1e8/0x2f0 > > > > > > [c000000003cefa10] [c000000000f0a00c] __schedule+0x2cc/0xb50 > > > > > > [c000000003cefae0] [c000000000f0a8fc] schedule+0x6c/0x140 > > > > > > [c000000003cefb10] [c00000000095b6c4] tell_host+0xe4/0x130 > > > > > > [c000000003cefba0] [c00000000095d234] update_balloon_size_func+0x394/0x3f0 > > > > > > [c000000003cefc70] [c000000000178064] process_one_work+0x2c4/0x5b0 > > > > > > [c000000003cefd10] [c0000000001783f8] worker_thread+0xa8/0x640 > > > > > > [c000000003cefda0] [c000000000185444] kthread+0x1b4/0x1c0 > > > > > > [c000000003cefe10] [c00000000000cee4] ret_from_kernel_thread+0x5c/0x64 > > > > > > > > > > > > Similar backtrace reported here by Luis: > > > > > > > > > > > > https://lore.kernel.org/lkml/YY2duTi0wAyAKUTJ@bombadil.infradead.org/ > > > > > > > > > > > > Bisect points to: > > > > > > > > > > > > # first bad commit: [939779f5152d161b34f612af29e7dc1ac4472fcf] virtio_ring: validate used buffer length > > > > > > > > > > > > Adding suppress used validation to the virtio balloon driver "fixes" it, eg. > > > > > > > > > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > > > > > index c22ff0117b46..a14b82ceebb2 100644 > > > > > > --- a/drivers/virtio/virtio_balloon.c > > > > > > +++ b/drivers/virtio/virtio_balloon.c > > > > > > @@ -1150,6 +1150,7 @@ static unsigned int features[] = { > > > > > > }; > > > > > > > > > > > > static struct virtio_driver virtio_balloon_driver = { > > > > > > + .suppress_used_validation = true, > > > > > > .feature_table = features, > > > > > > .feature_table_size = ARRAY_SIZE(features), > > > > > > .driver.name = KBUILD_MODNAME, > > > > > > > > > > Looks good, we need a formal patch for this. > > > > > > > > > > And we need fix Qemu as well which advertise non zero used length for > > > > > inflate/deflate queue: > > > > > > > > > > static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq) > > > > > ... > > > > > virtqueue_push(vq, elem, offset); > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > cheers > > > > > > > > > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization